feat: update release flow to make sure only runner releases are marked as latest #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeLagrange
changed the title
art049
requested changes
Dec 22, 2025
GuillaumeLagrange
force-pushed
the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
3 times, most recently
from
5bce640 to
0bd7798
Compare
GuillaumeLagrange
force-pushed
the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
from
4b38dc9 to
726225a
Compare
GuillaumeLagrange
force-pushed
the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
3 times, most recently
from
8dffce1 to
2b36468
Compare
art049
reviewed
Dec 23, 2025
GuillaumeLagrange
force-pushed
the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
2 times, most recently
from
cf0a96a to
cde85a0
Compare
GuillaumeLagrange
force-pushed
the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
3 times, most recently
from
a140828 to
69f8711
Compare
art049
reviewed
Dec 23, 2025
art049
requested changes
Dec 23, 2025
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
Looks good, except the lack of publishing of the non runner release. At the moment, they will remain as draft if I'm not mistaken
Member
|
Can you also have a look to make sure runner release are named: |
GuillaumeLagrange
force-pushed
the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
from
69f8711 to
09a2b65
Compare
art049
approved these changes
Dec 23, 2025
art049
force-pushed
the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
from
09a2b65 to
7a1b311
Compare
art049
deleted the
cod-1894-ensure-only-runner-releases-can-be-marked-as-latest-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not want to over-engineer something for the tag, so I just made it take the latest tag in
scripts/release.sh, which gives the limitation of only working with one crate per script invocation.Tested here
https://github.com/CodSpeedHQ/runner/actions/runs/20457122332
which created fake release here
https://github.com/CodSpeedHQ/runner/releases/tag/memtrack-v1.0.0-alpha.13
(Screenshot since the release will most likely be removed after merge to clean things up)