Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

@not-matthias not-matthias force-pushed the cod-1385-codspeed-node-add-perf-v2-support branch from 41d5a5d to ea75ede Compare October 3, 2025 15:09
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Performance Report

Merging #64 will improve performances by ×2.3

Comparing cod-1385-codspeed-node-add-perf-v2-support (174369c) with main (b1e4a94)

Summary

⚡ 1 improvement
✅ 129 untouched

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation short body 301.7 µs 133 µs ×2.3

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed WallTime Performance Report

Merging #64 will degrade performances by 13.33%

Comparing cod-1385-codspeed-node-add-perf-v2-support (ea75ede) with main (b1e4a94)

Summary

❌ 1 regression
✅ 47 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
switch 2 156 ns 180 ns -13.33%

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the instrument-hooks subproject to a newer commit version, moving from commit d094ae4d6aa0be555a1016cfbbea74e34b0ed555 to b3d4b78ef68498d59afd45a9c8b2ef096652f034.

  • Updates the subproject commit reference for instrument-hooks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flamegraphs are still catching up some stuff they should preferably not, maybe we need to actually use markers ?

As it stands, it's not worth it to merge IMO, as it does not really improve flamegraph on its own. Unless it fixes something broken with the latest verison of the runner.

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias force-pushed the cod-1385-codspeed-node-add-perf-v2-support branch from ea75ede to 12b1252 Compare October 30, 2025 15:02
Signed-off-by: Guillaume Lagrange <guillaume@glagrange.eu>
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1385-codspeed-node-add-perf-v2-support branch from 12b1252 to 174369c Compare October 30, 2025 16:45
@GuillaumeLagrange GuillaumeLagrange merged commit 174369c into main Oct 30, 2025
16 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1385-codspeed-node-add-perf-v2-support branch October 30, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants