Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

No description provided.

@GuillaumeLagrange GuillaumeLagrange changed the title Cod 1253 support perf profiling with vitest Add perf profiling to vitest Sep 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 14, 2025

CodSpeed Instrumentation Performance Report

Merging #55 will degrade performances by 19.02%

Comparing cod-1253-support-perf-profiling-with-vitest (453da47) with main (e31ee8b)

Summary

⚡ 1 improvement
❌ 1 regression
✅ 80 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iterative_fibo_10 423 µs 305.4 µs +38.51%
wait 500ms 10 ms 12.4 ms -19.02%

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 14, 2025

CodSpeed WallTime Performance Report

Merging #55 will improve performances by 23.08%

Comparing cod-1253-support-perf-profiling-with-vitest (453da47) with main (e31ee8b)

Summary

⚡ 6 improvements
✅ 42 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iterative_fibo_10 420 ns 372 ns +12.9%
test_iterative_fibo_100 720 ns 636 ns +13.21%
test_recursive_cached_fibo_10 1.3 µs 1.1 µs +11.7%
test sync baz 10 384 ns 312 ns +23.08%
test sync baz 100 492 ns 444 ns +10.81%
short body 1.9 µs 1.7 µs +11.35%

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch 3 times, most recently from 7545857 to b3c21b3 Compare September 15, 2025 08:50
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch from 5ef7f44 to 079d5f2 Compare September 15, 2025 09:23
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from b3c21b3 to 4f20e80 Compare September 15, 2025 09:23
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch from 079d5f2 to f070d03 Compare September 15, 2025 09:45
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 4f20e80 to 8498375 Compare September 15, 2025 09:45
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch 2 times, most recently from 66b60d2 to dc286b7 Compare September 15, 2025 13:13
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch from 69ecc14 to 0703b06 Compare September 15, 2025 13:14
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from dc286b7 to 3655d7e Compare September 15, 2025 13:14
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor changes are left.

How do we distinguish between a sync and async bench here?

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch 2 times, most recently from 3655d7e to 0994dd1 Compare September 16, 2025 16:52
@GuillaumeLagrange
Copy link
Contributor Author

How do we distinguish between a sync and async bench here?

@art049 there's no distinction currenlty because vitest does not make the distinction and runs everything using tinybench's async run entrypoint
Empirically, I've had much better results with vitest's stack traces than tinybench's. I have not narrowed down why though.

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 0994dd1 to 674b330 Compare September 17, 2025 09:11
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch 2 times, most recently from e55aee6 to 29f65e9 Compare September 17, 2025 09:22
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 674b330 to 73ebe23 Compare September 17, 2025 09:22
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch from 29f65e9 to d9c546a Compare September 17, 2025 09:30
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 73ebe23 to 6f12002 Compare September 17, 2025 09:30
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch from d9c546a to 91a7670 Compare September 18, 2025 14:43
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 6f12002 to d1fdf74 Compare September 18, 2025 14:43
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch 3 times, most recently from f052c13 to 9575172 Compare September 19, 2025 14:04
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from d1fdf74 to 80fa456 Compare September 19, 2025 14:07
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch from 9575172 to e31ee8b Compare September 19, 2025 14:20
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 80fa456 to 44a2b8d Compare September 19, 2025 14:20
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1221-support-perf-profiling-with-codspeed-node branch 3 times, most recently from 7ee6021 to e31ee8b Compare September 26, 2025 07:06
Base automatically changed from cod-1221-support-perf-profiling-with-codspeed-node to main September 26, 2025 09:41
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 44a2b8d to 453da47 Compare September 26, 2025 09:42
@GuillaumeLagrange GuillaumeLagrange merged commit 453da47 into main Sep 26, 2025
14 of 15 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1253-support-perf-profiling-with-vitest branch September 26, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants