Deprecate Submission.id and communicate its removal for Google Classroom #82
Conversation
Not sure where these changes are coming from, but committing them ahead of the actual change I'm intending to make for LMS Connect.
Will no longer be present in standalone LMS Connect. It is now empty for Google Classroom and will later be removed for Canva and Schoology.
| - Vietnamese | ||
| - Cebuano | ||
| - Hawaiian | ||
| - Kannada |
There was a problem hiding this comment.
Question: are these enums auto-generated from somewhere? Are they related to this change?
There was a problem hiding this comment.
I genuinely have no idea. They are the result of running make generate VERSION=3. I tried to document that in the first commit, but I think some changes also got in the second commit? I really do not know what is going on here without fully debugging how this works.
There was a problem hiding this comment.
I think the order of these generated enums get shuffled around somehow with each run of make generate
| properties: | ||
| id: | ||
| type: string | ||
| description: | |
There was a problem hiding this comment.
cc-ing @KatieTGardner for your thoughts on this note!
| description: | | ||
| Deprecated. The unique identifier of the submission in the upstream LMS. Will always be | ||
| empty if the upstream LMS provider is Google Classroom; it is currently still present for | ||
| Canva and Schoology LMSs but will be removed in the near future. |
There was a problem hiding this comment.
| Canva and Schoology LMSs but will be removed in the near future. | |
| Canvas and Schoology LMSs but will be removed in the near future. |
| id: | ||
| type: string | ||
| description: | | ||
| Deprecated. The unique identifier of the submission in the upstream LMS. Will always be |
There was a problem hiding this comment.
| Deprecated. The unique identifier of the submission in the upstream LMS. Will always be | |
| Deprecated. The unique identifier of the submission. Will always be |
The current submission ID actually doesn't correspond to the LMS submission ID
There was a problem hiding this comment.
Oh it's the Clever id? If so, will say that explicitly
|
some suggestions but otherwise LGTM feel free to uncommit the language enum generated changes |
Clever Coding Standards Agreement
JIRA
SHAPI-1798
Overview
Adds a
descriptiontoSubmission.idcommunicating that it is deprecated. Unclear from the ticket exactly how we would like to communicate it, or if we would like to remove it early.Testing
n/a, based on directions in the ticket. The acceptance criteria for this change should be finalized by product or partner engineering.
Rollout
To be coordinated with Partner Engineering.
Rollback
n/a