Windows Compatibility #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped script names in an expression that checks the system type and concatenates either .bat or .sh
CestDiego
reviewed
Sep 4, 2018
| (if (eq system-type 'windows-nt) | ||
| ".bat" | ||
| ".sh")) | ||
| (nand2tetris-tools-dir)))) |
Owner
There was a problem hiding this comment.
Would you consider making a function for this following the naming conventions of this package?
CestDiego
reviewed
Sep 4, 2018
|
|
||
| (defun nand2tetris/tests-current-hdl-elsewhere () | ||
| "Run `HardwareSimulator.sh' on current tst file, but on another locaion. | ||
| "Run `HardwareSimulator.bat' on current tst file, but in another location. |
Owner
There was a problem hiding this comment.
instead of the extension name. Can we use this wording instead? Run HardwareSimulator script that way it's agnostic
Owner
|
@DarkFleetOne Thanks for contributing to this emacs package. I haven't been actively maintaining it but I would love to accept your changes after a few modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped script names in an expression that checks the system type and concatenates either .bat or .sh
This allows tests to be run on Windows once the nand2tetris directory is set while preserving the .sh extension as the default.