Skip to content

Settings UI 에서 secret key management 수정 #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehddnr301 merged 1 commit into from
Nov 28, 2025
Merged

Settings UI 에서 secret key management 수정 #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions interface/app_pages/settings_sections/db_section.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,23 @@ def render_db_section() -> None:
default_secret = (existing.extra or {}).get(
k, ""
) or _prefill_from_env(new_type, k)

# 비밀키는 값을 미리 채우지 않음 (보안)
placeholder = (
"값 설정됨 (변경하려면 입력)" if default_secret else "값 없음"
)
sv = st.text_input(
label,
value=str(default_secret or ""),
value="",
type="password",
key=f"db_edit_secret_{k}",
placeholder=placeholder,
)
if sv != "":
# 입력값이 없으면 기존 값 유지, 있으면 새 값 사용
if sv:
secrets[k] = sv
elif default_secret:
secrets[k] = default_secret

cols = st.columns([1, 1, 2])
with cols[0]:
Expand Down Expand Up @@ -257,7 +266,7 @@ def render_db_section() -> None:

secrets_new: dict[str, str] = {}
for label, k in _secret_fields(db_type):
sv = st.text_input(label, key=f"db_new_secret_{k}")
sv = st.text_input(label, key=f"db_new_secret_{k}", type="password")
if sv != "":
secrets_new[k] = sv

Expand Down
67 changes: 49 additions & 18 deletions interface/app_pages/settings_sections/llm_section.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,20 +139,31 @@ def render_llm_section(config: Config | None = None) -> None:
values: dict[str, str | None] = {}
non_secret_values: dict[str, str | None] = {}
for label, env_key, is_secret in fields:
prefill = st.session_state.get(env_key) or os.getenv(env_key) or ""
current_val = st.session_state.get(env_key) or os.getenv(env_key) or ""
if is_secret:
values[env_key] = st.text_input(
label, value=prefill, type="password", key=f"llm_{env_key}"
# 비밀키는 값을 미리 채우지 않음 (보안)
# 값이 설정되어 있으면 placeholder로 표시
placeholder = (
"값 설정됨 (변경하려면 입력)" if current_val else "값 없음"
)
new_val = st.text_input(
label,
value="",
type="password",
key=f"llm_{env_key}",
placeholder=placeholder,
)
# 입력값이 없으면 기존 값 유지, 있으면 새 값 사용
values[env_key] = new_val if new_val else current_val
else:
v = st.text_input(label, value=prefill, key=f"llm_{env_key}")
v = st.text_input(label, value=current_val, key=f"llm_{env_key}")
values[env_key] = v
non_secret_values[env_key] = v

# 메시지 영역
llm_msg = st.empty()

st.markdown("**프로파일 저장 (비밀키 제외)**")
st.markdown("**프로파일 저장**")
with st.form("llm_profile_save_form"):
prof_cols = st.columns([2, 2])
with prof_cols[0]:
Expand Down Expand Up @@ -185,10 +196,16 @@ def render_llm_section(config: Config | None = None) -> None:
with st.expander("저장된 LLM 프로파일", expanded=False):
for p in reg.profiles:
if p.fields:
pairs = [
f"{k}={p.fields.get(k, '')}"
for k in sorted(p.fields.keys())
]
# 필드 정의 가져오기 (시크릿 여부 확인용)
fields_def = _llm_fields(p.provider)
secret_keys = {k for _, k, is_secret in fields_def if is_secret}

pairs = []
for k in sorted(p.fields.keys()):
val = p.fields.get(k, "")
if k in secret_keys:
val = "***"
pairs.append(f"{k}={val}")
fields_text = ", ".join(pairs)
else:
fields_text = "-"
Expand Down Expand Up @@ -217,20 +234,28 @@ def render_llm_section(config: Config | None = None) -> None:
e_fields = _embedding_fields(e_provider)
e_values: dict[str, str | None] = {}
for label, env_key, is_secret in e_fields:
prefill = st.session_state.get(env_key) or os.getenv(env_key) or ""
current_val = st.session_state.get(env_key) or os.getenv(env_key) or ""
if is_secret:
e_values[env_key] = st.text_input(
label, value=prefill, type="password", key=f"emb_{env_key}"
placeholder = (
"값 설정됨 (변경하려면 입력)" if current_val else "값 없음"
)
new_val = st.text_input(
label,
value="",
type="password",
key=f"emb_{env_key}",
placeholder=placeholder,
)
e_values[env_key] = new_val if new_val else current_val
else:
e_values[env_key] = st.text_input(
label, value=prefill, key=f"emb_{env_key}"
label, value=current_val, key=f"emb_{env_key}"
)

# 메시지 영역: 버튼 컬럼 밖(섹션 폭)
emb_msg = st.empty()

st.markdown("**Embeddings 프로파일 저장 (시크릿 포함)**")
st.markdown("**Embeddings 프로파일 저장**")
with st.form("embedding_profile_save_form"):
e_prof_cols = st.columns([2, 2])
with e_prof_cols[0]:
Expand Down Expand Up @@ -263,10 +288,16 @@ def render_llm_section(config: Config | None = None) -> None:
with st.expander("저장된 Embeddings 프로파일", expanded=False):
for p in e_reg.profiles:
if p.fields:
pairs = [
f"{k}={p.fields.get(k, '')}"
for k in sorted(p.fields.keys())
]
# 필드 정의 가져오기 (시크릿 여부 확인용)
fields_def = _embedding_fields(p.provider)
secret_keys = {k for _, k, is_secret in fields_def if is_secret}

pairs = []
for k in sorted(p.fields.keys()):
val = p.fields.get(k, "")
if k in secret_keys:
val = "***"
pairs.append(f"{k}={val}")
fields_text = ", ".join(pairs)
else:
fields_text = "-"
Expand Down