Skip to content

Fix sp_BlitzIndex error when scanning a database name of nvarchar(128) #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix sp_BlitzIndex error when scanning a database name of nvarchar(128) #3738

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
874ffe8
Fix sp_BlitzIndex error when scanning a database with name of nvarcha…
MisterZeus Nov 13, 2025
b62ce27
Update sp_BlitzIndex.sql
MisterZeus Nov 17, 2025
9b20aa8
Update sp_BlitzIndex.sql
MisterZeus Nov 17, 2025
b3365f6
Update sp_BlitzIndex.sql
MisterZeus Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 55 additions & 43 deletions sp_BlitzIndex.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2140,49 +2140,61 @@ OPTION (RECOMPILE);';
END;

SET @dsql = N'
SELECT DB_ID(@i_DatabaseName) AS [database_id],
@i_DatabaseName AS database_name,
s.name,
fk_object.name AS foreign_key_name,
parent_object.[object_id] AS parent_object_id,
parent_object.name AS parent_object_name,
referenced_object.[object_id] AS referenced_object_id,
referenced_object.name AS referenced_object_name,
fk.is_disabled,
fk.is_not_trusted,
fk.is_not_for_replication,
parent.fk_columns,
referenced.fk_columns,
[update_referential_action_desc],
[delete_referential_action_desc]
FROM ' + QUOTENAME(@DatabaseName) + N'.sys.foreign_keys fk
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.objects fk_object ON fk.object_id=fk_object.object_id
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.objects parent_object ON fk.parent_object_id=parent_object.object_id
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.objects referenced_object ON fk.referenced_object_id=referenced_object.object_id
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.schemas AS s ON fk.schema_id=s.schema_id
CROSS APPLY ( SELECT STUFF( (SELECT N'', '' + c_parent.name AS fk_columns
FROM ' + QUOTENAME(@DatabaseName) + N'.sys.foreign_key_columns fkc
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.columns c_parent ON fkc.parent_object_id=c_parent.[object_id]
AND fkc.parent_column_id=c_parent.column_id
WHERE fk.parent_object_id=fkc.parent_object_id
AND fk.[object_id]=fkc.constraint_object_id
ORDER BY fkc.constraint_column_id
FOR XML PATH('''') ,
TYPE).value(''.'', ''nvarchar(max)''), 1, 1, '''')/*This is how we remove the first comma*/ ) parent ( fk_columns )
CROSS APPLY ( SELECT STUFF( (SELECT N'', '' + c_referenced.name AS fk_columns
FROM ' + QUOTENAME(@DatabaseName) + N'.sys. foreign_key_columns fkc
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.columns c_referenced ON fkc.referenced_object_id=c_referenced.[object_id]
AND fkc.referenced_column_id=c_referenced.column_id
WHERE fk.referenced_object_id=fkc.referenced_object_id
and fk.[object_id]=fkc.constraint_object_id
ORDER BY fkc.constraint_column_id /*order by col name, we don''t have anything better*/
FOR XML PATH('''') ,
TYPE).value(''.'', ''nvarchar(max)''), 1, 1, '''') ) referenced ( fk_columns )
' + CASE WHEN @ObjectID IS NOT NULL THEN
'WHERE fk.parent_object_id=' + CAST(@ObjectID AS NVARCHAR(30)) + N' OR fk.referenced_object_id=' + CAST(@ObjectID AS NVARCHAR(30)) + N' '
ELSE N' ' END + '
ORDER BY parent_object_name, foreign_key_name
OPTION (RECOMPILE);';
SELECT
DB_ID(@i_DatabaseName) AS [database_id],
@i_DatabaseName AS database_name,
s.name,
fk_object.name AS foreign_key_name,
parent_object.[object_id] AS parent_object_id,
parent_object.name AS parent_object_name,
referenced_object.[object_id] AS referenced_object_id,
referenced_object.name AS referenced_object_name,
fk.is_disabled,
fk.is_not_trusted,
fk.is_not_for_replication,
parent.fk_columns,
referenced.fk_columns,
[update_referential_action_desc],
[delete_referential_action_desc]
FROM ' + QUOTENAME(@DatabaseName) + N'.sys.foreign_keys fk
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.objects fk_object ON fk.object_id=fk_object.object_id
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.objects parent_object ON fk.parent_object_id=parent_object.object_id
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.objects referenced_object ON fk.referenced_object_id=referenced_object.object_id
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.schemas AS s ON fk.schema_id=s.schema_id
CROSS APPLY (
SELECT STUFF( (
SELECT N'', '' + c_parent.name AS fk_columns
FROM ' + QUOTENAME(@DatabaseName) + N'.sys.foreign_key_columns fkc
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.columns c_parent
ON fkc.parent_object_id=c_parent.[object_id]
AND fkc.parent_column_id=c_parent.column_id
WHERE fk.parent_object_id=fkc.parent_object_id
AND fk.[object_id]=fkc.constraint_object_id
ORDER BY fkc.constraint_column_id
FOR XML PATH(''''),
TYPE
).value(''.'', ''nvarchar(max)''), 1, 1, '''') /*This is how we remove the first comma*/
) parent ( fk_columns )
CROSS APPLY (
SELECT STUFF( (
SELECT N'', '' + c_referenced.name AS fk_columns
FROM ' + QUOTENAME(@DatabaseName) + N'.sys.foreign_key_columns fkc
JOIN ' + QUOTENAME(@DatabaseName) + N'.sys.columns c_referenced
ON fkc.referenced_object_id=c_referenced.[object_id]
AND fkc.referenced_column_id=c_referenced.column_id
WHERE fk.referenced_object_id=fkc.referenced_object_id
AND fk.[object_id]=fkc.constraint_object_id
ORDER BY fkc.constraint_column_id /*order by col name, we don''t have anything better*/
FOR XML PATH(''''),
TYPE
).value(''.'', ''nvarchar(max)''), 1, 1, '''')
) referenced ( fk_columns )
' + CASE
WHEN @ObjectID IS NOT NULL
THEN 'WHERE fk.parent_object_id=' + CAST(@ObjectID AS NVARCHAR(30)) + N' OR fk.referenced_object_id=' + CAST(@ObjectID AS NVARCHAR(30)) + N' '
ELSE N' ' END + '
ORDER BY parent_object_name, foreign_key_name
OPTION (RECOMPILE);';
IF @dsql IS NULL
RAISERROR('@dsql is null',16,1);

Expand Down
Loading