Skip to content

asconfigc: handle creation of symbolic links when unpacking ANEs #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

asconfigc: handle creation of symbolic links when unpacking ANEs #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions asconfigc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ limitations under the License.
<artifactId>json-schema-validator</artifactId>
<version>1.5.6</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
<version>1.27.1</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-nop</artifactId>
Expand Down
23 changes: 18 additions & 5 deletions asconfigc/src/main/java/com/as3mxml/asconfigc/ASConfigC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@
import java.util.Set;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;

import org.apache.commons.compress.archivers.zip.ZipArchiveEntry;
import org.apache.commons.compress.archivers.zip.ZipFile;

import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
Expand Down Expand Up @@ -1260,10 +1261,10 @@ private void unpackANE(File aneFile) throws ASConfigCException {
}

try {
ZipFile zipFile = new ZipFile(aneFile);
Enumeration<?> zipEntries = zipFile.entries();
ZipFile zipFile = ZipFile.builder().setFile(aneFile).get();
Enumeration<?> zipEntries = zipFile.getEntries();
while (zipEntries.hasMoreElements()) {
ZipEntry zipEntry = (ZipEntry) zipEntries.nextElement();
ZipArchiveEntry zipEntry = (ZipArchiveEntry) zipEntries.nextElement();
if (zipEntry.isDirectory()) {
continue;
}
Expand All @@ -1272,6 +1273,18 @@ private void unpackANE(File aneFile) throws ASConfigCException {
File destParent = new File(destFile.getParent());
destParent.mkdirs();

if (zipEntry.isUnixSymlink()) {
Path link = destFile.toPath();
Path target = Paths.get(zipFile.getUnixSymlink(zipEntry));
try {
Files.createSymbolicLink(link, target);
continue;
} catch (Exception e) {
System.out.println("Failed to create symbolic link: " + currentAneDirectory.toPath().relativize(link)
+ " -> " + target + ", will write as regular file instead." );
}
}

BufferedInputStream inStream = new BufferedInputStream(zipFile.getInputStream(zipEntry));
FileOutputStream fileOutStream = new FileOutputStream(destFile);
byte buffer[] = new byte[2048];
Expand Down
2 changes: 2 additions & 0 deletions distribution/src/assembly/bin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@
<includes>
<include>asconfigc*.jar</include>
<include>commons-cli*.jar</include>
<include>commons-compress-*.jar</include>
<include>commons-io-*.jar</include>
<include>commons-lang*.jar</include>
</includes>
</fileSet>
Expand Down