[metrics advisor] Added mapping for metric name to metric id (Azure#13408)

* added mapping type for metric name to metric id

* Mapping

* update review file and test

* update review file and test

* recordings updated

* include Jeremy's suggestions

* added recordings

* mapping metric

* not undfined id

* update review file

* Update sdk/metricsadvisor/ai-metrics-advisor/recordings/node/aad_metricsadvisoradministrationclient_datafeed_datafeed/recording_creates_an_azure_blob_datafeed.js

Author: KarishmaGhiya

sdk/metricsadvisor/ai-metrics-advisor/review/ai-metrics-advisor.api.md

@@ -204,6 +204,7 @@ export type DataFeed = {
     creator: string;
     source: DataFeedSource;
     schema: DataFeedSchema;
+    metricIds: Map<string, string>;
     granularity: DataFeedGranularity;
     ingestionSettings: DataFeedIngestionSettings;
 } & DataFeedOptions;

sdk/metricsadvisor/ai-metrics-advisor/src/models.ts

@@ -307,6 +307,10 @@ export type DataFeed = {
    * Schema of the data in the data feed, including names of metrics, dimensions, and timestamp columns.
    */
   schema: DataFeedSchema;
+  /**
+   * Map of metric names to metric ids for quick lookup
+   */
+  metricIds: Map<string, string>;
   /**
    * Granularity of the data feed.
    */

sdk/metricsadvisor/ai-metrics-advisor/src/transforms.ts

@@ -339,10 +339,11 @@ export function toServiceGranularity(
 }
 
 export function fromServiceDataFeedDetailUnion(original: ServiceDataFeedDetailUnion): DataFeed {
+  const metricMap = new Map(original.metrics.map((x) => [x.name, x.id!]));
   const common = {
     id: original.dataFeedId!,
     name: original.dataFeedName,
-    metricIds: original.metrics.map((c) => c.id!),
+    metricIds: metricMap,
     createdOn: original.createdTime!,
     status: original.status!,
     isAdmin: original.isAdmin!,

sdk/metricsadvisor/ai-metrics-advisor/test/public/datafeed.spec.ts

@@ -185,6 +185,10 @@ matrix([[true, false]] as const, async (useAad) => {
             dataFeedIngestion,
             "Ingesting settings mismatch!"
           );
+          assert.equal(
+            actual.metricIds.get(dataFeedSchema.metrics[0].name),
+            actual.schema.metrics[0].id
+          );
 
           assert.equal(actual.description, options.description, "options.description mismatch");
           assert.equal(actual.accessMode, options.accessMode, "options.accessMode mismatch");