remove queries out of for-loop to an iterator variable (Azure#12338)

Author: KarishmaGhiya

sdk/metricsadvisor/ai-metrics-advisor/README.md

@@ -246,11 +246,8 @@ async function main() {
 async function checkIngestionStatus(adminClient, datafeedId, startTime, endTime) {
   // This shows how to use for-await-of syntax to list status
   console.log("Checking ingestion status...");
-  for await (const status of adminClient.listDataFeedIngestionStatus(
-    datafeedId,
-    startTime,
-    endTime
-  )) {
+  const iterator = adminClient.listDataFeedIngestionStatus(datafeedId, startTime, endTime);
+  for await (const status of iterator) {
     console.log(`  [${status.timestamp}] ${status.status} - ${status.message}`);
   }
 }
@@ -429,12 +426,8 @@ async function main() {
 
 async function queryAlerts(client, alertConfigId, startTime, endTime) {
   let alerts = [];
-  for await (const alert of client.listAlerts(
-    alertConfigId,
-    startTime,
-    endTime,
-    "AnomalyTime"
-  )) {
+  const iterator = client.listAlerts(alertConfigId, startTime, endTime, "AnomalyTime");
+  for await (const alert of iterator) {
     alerts.push(alert);
   }
 
@@ -445,7 +438,8 @@ async function queryAnomaliesByAlert(client, alert) {
   console.log(
     `Listing anomalies for alert configuration '${alert.alertConfigId}' and alert '${alert.id}'`
   );
-  for await (const anomaly of client.listAnomalies(alert)) {
+  const iterator = client.listAnomalies(alert);
+  for await (const anomaly of iterator) {
     console.log(
       `  Anomaly ${anomaly.severity} ${anomaly.status} ${anomaly.seriesKey.dimension} ${anomaly.timestamp}`
     );

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/alertingConfig.js

@@ -108,7 +108,8 @@ async function deleteAlertConfig(adminClient, alertConfigId) {
 async function listAlertingConfig(adminClient, detectdionConfigId) {
   console.log(`Listing alerting configurations for detection configuration ${detectdionConfigId}`);
   let i = 1;
-  for await (const config of adminClient.listAlertConfigs(detectdionConfigId)) {
+  const iterator = adminClient.listAlertConfigs(detectdionConfigId);
+  for await (const config of iterator) {
     console.log(`Alert configuration ${i++}`);
     console.log(config);
   }

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/dataFeed.js

@@ -43,7 +43,8 @@ async function listDataFeeds(client) {
 
   // second approach
   console.log("  using for-await-of loop");
-  for await (const datatFeed of client.listDataFeeds()) {
+  const iterator = client.listDataFeeds();
+  for await (const datatFeed of iterator) {
     console.log(`id :${datatFeed.id}, name: ${datatFeed.name}`);
   }
 

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/detectionConfig.js

@@ -173,7 +173,8 @@ async function deleteDetectionConfig(adminClient, detectionConfigId) {
 async function listDetectionConfig(adminClient, metricId) {
   console.log(`Listing detection configurations for metric '${metricId}'...`);
   let i = 1;
-  for await (const config of adminClient.listDetectionConfigs(metricId)) {
+  const iterator = adminClient.listDetectionConfigs(metricId);
+  for await (const config of iterator) {
     console.log(`  detection configuration ${i++}`);
     console.log(config);
   }

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/incidentsAndAlerts.js

@@ -35,14 +35,15 @@ async function main() {
 async function listIncidentsForDetectionConfig(client, detectionConfigId) {
   console.log(`Listing incidents for detection config '${detectionConfigId}'`);
   console.log("  using for-await-of syntax");
-  for await (const incident of client.listIncidents(
+  const listIterator = client.listIncidents(
     detectionConfigId,
     new Date("10/22/2020"),
     new Date("10/24/2020"),
     {
       dimensionFilter: [{ city: "Manila", category: "Shoes Handbags & Sunglasses" }]
     }
-  )) {
+  );
+  for await (const incident of listIterator) {
     console.log("    Incident");
     console.log(`      id: ${incident.id}`);
     console.log(`      severity: ${incident.severity}`);
@@ -77,14 +78,15 @@ async function listIncidentsForDetectionConfig(client, detectionConfigId) {
 async function listAnomaliesForDetectionConfig(client, detectionConfigId) {
   console.log(`Listing anomalies for detection config '${detectionConfigId}'`);
   console.log("  using for-await-of syntax");
-  for await (const anomaly of client.listAnomalies(
+  const listIterator = client.listAnomalies(
     detectionConfigId,
     new Date("10/22/2020"),
     new Date("10/24/2020"),
     {
       severityFilter: { min: "Medium", max: "High" }
     }
-  )) {
+  );
+  for await (const anomaly of listIterator) {
     console.log("    Anomaly");
     console.log(`      metric id: ${anomaly.metricId}`);
     console.log(`      detection config id: ${anomaly.detectionConfigurationId}`);
@@ -124,12 +126,13 @@ async function getRootCauses(client, detectionConfigId, incidentId) {
 async function listAlerts(client, alertConfigId) {
   console.log(`Listing alerts for alert configuration '${alertConfigId}'`);
   console.log("  using for-await-of syntax");
-  for await (const alert of client.listAlerts(
+  const listIterator = client.listAlerts(
     alertConfigId,
     new Date("11/01/2020"),
     new Date("11/05/2020"),
     "AnomalyTime"
-  )) {
+  );
+  for await (const alert of listIterator) {
     console.log("    Alert");
     console.log(`      id: ${alert.id}`);
     console.log(`      timestamp: ${alert.timestamp}`);
@@ -159,7 +162,8 @@ async function listIncidentsForAlert(client, alertConfigId, alertId) {
     `Listing incidents for alert configuration '${alertConfigId}' and alert '${alertId}'`
   );
   console.log("  using for-await-of syntax");
-  for await (const incident of client.listIncidents({ alertConfigId, id: alertId })) {
+  const listIterator = client.listIncidents({ alertConfigId, id: alertId });
+  for await (const incident of listIterator) {
     console.log("    Incident");
     console.log(`      id: ${incident.id}`);
     console.log(`      severity: ${incident.severity}`);
@@ -194,7 +198,8 @@ async function listAnomaliesForAlert(client, alertConfigId, alertId) {
     `Listing anomalies for alert configuration '${alertConfigId}' and alert '${alertId}'`
   );
   console.log("  using for-await-of syntax");
-  for await (const anomaly of client.listAnomalies({ alertConfigId, id: alertId })) {
+  const listIterator = client.listAnomalies({ alertConfigId, id: alertId });
+  for await (const anomaly of listIterator) {
     console.log("    Anomaly");
     console.log(`      metric id: ${anomaly.metricId}`);
     console.log(`      detection config id: ${anomaly.detectionConfigurationId}`);

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/ingestionStatus.js

@@ -36,11 +36,8 @@ async function main() {
 async function listIngestionStatus(adminClient, dataFeedId, startTime, endTime) {
   console.log("Listing ingestion status...");
   // iterate through all ingestions using for-await-of
-  for await (const ingestion of adminClient.listDataFeedIngestionStatus(
-    dataFeedId,
-    startTime,
-    endTime
-  )) {
+  const listIterator = adminClient.listDataFeedIngestionStatus(dataFeedId, startTime, endTime);
+  for await (const ingestion of listIterator) {
     console.log(`  ${ingestion.timestamp} ${ingestion.status}  ${ingestion.message}`);
   }
   // listing by pages

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/metricFeedback.js

@@ -85,13 +85,14 @@ async function getFeedback(client, feedbackId) {
 async function listFeedback(client, metricId, startTime, endTime) {
   console.log("Listing feedbacks...");
   console.log("  using for-await-of syntax");
-  for await (const feedback of client.listFeedback(metricId, {
+  const listIterator = client.listFeedback(metricId, {
     filter: {
       startTime: new Date("08/01/2020"),
       endTime: new Date("08/03/2020"),
       timeMode: "MetricTimestamp"
     }
-  })) {
+  });
+  for await (const feedback of listIterator) {
     console.log(`    ${feedback.feedbackType} feedback ${feedback.id}`);
     console.log(`      created time: ${feedback.createdTime}`);
     console.log(`      metric id: ${feedback.metricId}`);

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/metricQueries.js

@@ -28,10 +28,8 @@ async function main() {
 async function listMetricSeriesDefinitions(client, metricId) {
   console.log("Listing metric series definitions...");
   console.log("  with for-await-of loop");
-  for await (const definition of client.listMetricSeriesDefinitions(
-    metricId,
-    new Date("08/05/2020")
-  )) {
+  const listIterator = client.listMetricSeriesDefinitions(metricId, new Date("08/05/2020"));
+  for await (const definition of listIterator) {
     console.log(definition);
   }
 
@@ -58,11 +56,12 @@ async function listMetricSeriesDefinitions(client, metricId) {
 
 async function listEnrichmentStatus(client, metricId) {
   console.log("Listing metric enrichment status...");
-  for await (const status of client.listMetricEnrichmentStatus(
+  const listIterator = client.listMetricEnrichmentStatus(
     metricId,
     new Date("10/22/2020"),
     new Date("10/24/2020")
-  )) {
+  );
+  for await (const status of listIterator) {
     console.log("  Enrichment status");
     console.log(status.timestamp);
     console.log(status.status);
@@ -72,7 +71,8 @@ async function listEnrichmentStatus(client, metricId) {
 
 async function listMetricDimensionValues(client, metricId) {
   console.log("Listing metric dimension values...");
-  for await (const dv of client.listMetricDimensionValues(metricId, "city")) {
+  const listIterator = client.listMetricDimensionValues(metricId, "city");
+  for await (const dv of listIterator) {
     console.log(`  ${dv}`);
   }
 }

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/quickstart.js

@@ -136,11 +136,8 @@ async function createDataFeed(adminClient, sqlServerConnectionString, sqlServerQ
 async function checkIngestionStatus(adminClient, datafeedId, startTime, endTime) {
   // This shows how to use for-await-of syntax to list status
   console.log("Checking ingestion status...");
-  for await (const status of adminClient.listDataFeedIngestionStatus(
-    datafeedId,
-    startTime,
-    endTime
-  )) {
+  const listIterator = adminClient.listDataFeedIngestionStatus(datafeedId, startTime, endTime);
+  for await (const status of listIterator) {
     console.log(`  [${status.timestamp}] ${status.status} - ${status.message}`);
   }
 }
@@ -218,7 +215,8 @@ async function queryAlerts(client, alertConfigId, startTime, endTime) {
   // This shows how to use `for-await-of` syntax to list alerts
   console.log("  using for-await-of syntax");
   let alerts = [];
-  for await (const alert of client.listAlerts(alertConfigId, startTime, endTime, "AnomalyTime")) {
+  const listIterator = client.listAlerts(alertConfigId, startTime, endTime, "AnomalyTime");
+  for await (const alert of listIterator) {
     alerts.push(alert);
     console.log("    Alert");
     console.log(`      id: ${alert.id}`);
@@ -245,7 +243,8 @@ async function queryAnomaliesByAlert(client, alert) {
   console.log(
     `Listing anomalies for alert configuration '${alert.alertConfigId}' and alert '${alert.id}'`
   );
-  for await (const anomaly of client.listAnomalies(alert)) {
+  const listIterator = client.listAnomalies(alert);
+  for await (const anomaly of listIterator) {
     console.log(
       `  Anomaly ${anomaly.severity} ${anomaly.status} ${anomaly.seriesKey.dimension} ${anomaly.timestamp}`
     );

sdk/metricsadvisor/ai-metrics-advisor/samples/typescript/src/alertingConfig.ts

@@ -126,7 +126,8 @@ async function listAlertConfig(
 ) {
   console.log(`Listing alert configurations for detection configuration ${detectdionConfigId}`);
   let i = 1;
-  for await (const config of adminClient.listAlertConfigs(detectdionConfigId)) {
+  const iterator = adminClient.listAlertConfigs(detectdionConfigId);
+  for await (const config of iterator) {
     console.log(`Alert configuration ${i++}`);
     console.log(config);
   }