Skip to content

Commit 9413fb6

Browse files
Handle listing of new data feed source types (Azure#12316)
Co-authored-by: Jeremy Meng <yumeng@microsoft.com>
1 parent b92c535 commit 9413fb6

17 files changed

+196
-62
lines changed

sdk/metricsadvisor/ai-metrics-advisor/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
- `IngestionStatus.timestamp`
4747
- `latestSuccessTimestamp` and `latestActiveTimestamp` in the return type of `getDataFeedIngestionProgress()`.
4848
- Parameters of `Date` type now also accept strings. No validation is done for the strings. The SDK calls `new Date()` to convert them to `Date`.
49+
- Handle potential new data feed source types gracefully
4950

5051
## 1.0.0-beta.1 (2020-10-07)
5152

sdk/metricsadvisor/ai-metrics-advisor/recordings/browsers/metricsadvisoradministrationclient_datafeed_datafeed/recording_creates_unknown_data_feed.json

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/metricsadvisor/ai-metrics-advisor/recordings/browsers/metricsadvisoradministrationclient_datafeed_datafeed/recording_updates_data_feed_to_have_an_unknown_data_source_type.json

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/metricsadvisor/ai-metrics-advisor/recordings/browsers/metricsadvisorclient/recording_lists_alerts_for_alert_configuration_by_page.json

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/metricsadvisor/ai-metrics-advisor/recordings/node/metricsadvisoradministrationclient_datafeed_datafeed/recording_creates_unknown_data_feed.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/metricsadvisor/ai-metrics-advisor/recordings/node/metricsadvisoradministrationclient_datafeed_datafeed/recording_updates_data_feed_to_have_a_different_data_source_type.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/metricsadvisor/ai-metrics-advisor/recordings/node/metricsadvisoradministrationclient_datafeed_datafeed/recording_updates_data_feed_to_have_an_unknown_data_source_type.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/metricsadvisor/ai-metrics-advisor/recordings/node/metricsadvisorclient/recording_lists_alerts_for_alert_configuration_by_page.js

Lines changed: 15 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/metricsadvisor/ai-metrics-advisor/review/ai-metrics-advisor.api.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ export interface DataFeedSchema {
310310
}
311311

312312
// @public
313-
export type DataFeedSource = AzureApplicationInsightsDataFeedSource | AzureBlobDataFeedSource | AzureCosmosDBDataFeedSource | AzureDataExplorerDataFeedSource | AzureDataLakeStorageGen2DataFeedSource | AzureTableDataFeedSource | ElasticsearchDataFeedSource | HttpRequestDataFeedSource | InfluxDBDataFeedSource | MySqlDataFeedSource | PostgreSqlDataFeedSource | SQLServerDataFeedSource | MongoDBDataFeedSource;
313+
export type DataFeedSource = AzureApplicationInsightsDataFeedSource | AzureBlobDataFeedSource | AzureCosmosDBDataFeedSource | AzureDataExplorerDataFeedSource | AzureDataLakeStorageGen2DataFeedSource | AzureTableDataFeedSource | ElasticsearchDataFeedSource | HttpRequestDataFeedSource | InfluxDBDataFeedSource | MySqlDataFeedSource | PostgreSqlDataFeedSource | SQLServerDataFeedSource | MongoDBDataFeedSource | UnknownDataFeedSource;
314314

315315
// @public
316316
export type DataFeedSourcePatch = Omit<DataFeedSource, "dataSourceParameter"> & {
@@ -994,6 +994,12 @@ export interface TopNGroupScope {
994994
top: number;
995995
}
996996

997+
// @public
998+
export type UnknownDataFeedSource = {
999+
dataSourceType: "Unknown";
1000+
dataSourceParameter: unknown;
1001+
};
1002+
9971003
// @public (undocumented)
9981004
export interface WebhookHookParameter {
9991005
certificateKey?: string;

sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/incidentsAndAlerts.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ async function getRootCauses(client, detectionConfigId, incidentId) {
124124
async function listAlerts(client, alertConfigId) {
125125
console.log(`Listing alerts for alert configuration '${alertConfigId}'`);
126126
console.log(" using for-await-of syntax");
127-
for await (const alert of client.listAlertsForAlertConfiguration(
127+
for await (const alert of client.listAlerts(
128128
alertConfigId,
129-
new Date("10/22/2020"),
130-
new Date("10/24/2020"),
129+
new Date("11/01/2020"),
130+
new Date("11/05/2020"),
131131
"AnomalyTime"
132132
)) {
133133
console.log(" Alert");
@@ -138,10 +138,10 @@ async function listAlerts(client, alertConfigId) {
138138

139139
console.log(` by pages`);
140140
const iterator = client
141-
.listAlertsForAlertConfiguration(
141+
.listAlerts(
142142
alertConfigId,
143-
new Date("10/22/2020"),
144-
new Date("10/24/2020"),
143+
new Date("11/01/2020"),
144+
new Date("11/05/2020"),
145145
"AnomalyTime"
146146
)
147147
.byPage({ maxPageSize: 20 });

0 commit comments

Comments
 (0)