[KeyVault] - Hide LocalCryptographyClient and replace it with a local mode instead (Azure#13373)

## What

- Remove LocalCryptographyClient from public API and instead make it a mode of the Cryptography Client
- Align our API with other languages where it makes sense and is not a breaking change

## Why

- Hiding the LocalCryptographyClient came out from feedback from the arch board
- Aligning with our partners ensures consistency across APIs. There are also things we missed before so it makes sense to add them now.

resolves Azure#13365

Author: maorleger

sdk/keyvault/keyvault-admin/src/accessControlClient.ts

@@ -52,7 +52,6 @@ export class KeyVaultAccessControlClient {
 
   /**
    * @internal
-   * @hidden
    * A reference to the auto-generated Key Vault HTTP client.
    */
   private readonly client: KeyVaultClient;
@@ -245,7 +244,6 @@ export class KeyVaultAccessControlClient {
 
   /**
    * @internal
-   * @hidden
    * Deals with the pagination of {@link listRoleAssignments}.
    * @param roleScope - The scope of the role assignments.
    * @param continuationState - An object that indicates the position of the paginated request.
@@ -286,7 +284,6 @@ export class KeyVaultAccessControlClient {
 
   /**
    * @internal
-   * @hidden
    * Deals with the iteration of all the available results of {@link listRoleAssignments}.
    * @param roleScope - The scope of the role assignments.
    * @param options - Common options for the iterative endpoints.
@@ -341,7 +338,6 @@ export class KeyVaultAccessControlClient {
 
   /**
    * @internal
-   * @hidden
    * Deals with the pagination of {@link listRoleDefinitions}.
    * @param roleScope - The scope of the role definition.
    * @param continuationState - An object that indicates the position of the paginated request.
@@ -382,7 +378,6 @@ export class KeyVaultAccessControlClient {
 
   /**
    * @internal
-   * @hidden
    * Deals with the iteration of all the available results of {@link listRoleDefinitions}.
    * @param roleScope - The scope of the role definition.
    * @param options - Common options for the iterative endpoints.

sdk/keyvault/keyvault-admin/src/backupClient.ts

@@ -51,7 +51,6 @@ export class KeyVaultBackupClient {
 
   /**
    * @internal
-   * @hidden
    * A reference to the auto-generated Key Vault HTTP client.
    */
   private readonly client: KeyVaultClient;

sdk/keyvault/keyvault-keys/CHANGELOG.md

@@ -1,11 +1,12 @@
 # Release History
 
-
 ## 4.2.0-beta.3 (Unreleased)
 
 - [Breaking] Removed `dist-browser` from the published package. To bundle the Azure SDK libraries for the browsers, please read our bundling guide: [link](https://github.com/Azure/azure-sdk-for-js/blob/master/documentation/Bundling.md).
 - Updated the Key Vault Keys Long Running Operation Pollers to follow a more compact and meaningful approach moving forward.
 - Bug fix: The logging of HTTP requests wasn't properly working - now it has been fixed and tests have been written that verify the fix.
+- Add a constructor overload to `CryptographyClient` that takes a `JsonWebKey` and allows for local-only subset of operations.
+- Add `KeyId` to the public API of CryptographyClient.
 
 ## 4.2.0-beta.2 (2020-10-06)
 
@@ -19,7 +20,7 @@
 ## 4.2.0-beta.1 (2020-09-11)
 
 - Added `parseKeyVaultKeysIdentifier` and `ParsedKeyVaultKeysIdentifier` to help with parsing the unique identifiers of Key Vault Keys.
-- Added the basic structure of a new client to perform local cryptography operations, which is now called `LocalCryptographyClient`.  
+- Added the basic structure of a new client to perform local cryptography operations, which is now called `LocalCryptographyClient`.
   - The existing `CryptographyClient`, when initialized, will create one instance of a local cryptography client, which can be retrieved by calling to a new method that is part of the `CryptographyClient` class: `getLocalCryptographyClient()`.
   - The `LocalCryptographyClient` currently has limited support of the cryptography operations available on the `CryptographyClient`. More operations will be added over time.
 
@@ -30,8 +31,8 @@
 ### Changes since 4.0.4
 
 - Added the optional `serviceVersion` property to the `KeyClient` and `CryptographyClient` optional parameters to control the version of the Key Vault service being used by the clients.
-    - It defaults to the latest supported API version, which currently is `7.1`.
-    - Other supported service version at the moment is `7.0`.
+  - It defaults to the latest supported API version, which currently is `7.1`.
+  - Other supported service version at the moment is `7.0`.
 - Added `import` to the list of possible values for `KeyOperation`.
 - Added `recoverableDays` as an optional property to `KeyProperties` which denotes the number of days in which the key can be recovered after deletion. This is only applicable for Azure Key Vaults with the soft-delete setting enabled.
 - Fixed [bug 10352](https://github.com/Azure/azure-sdk-for-js/issues/10352), which caused cryptography operations on RSA-HSM keys to fail.

sdk/keyvault/keyvault-keys/karma.conf.js

@@ -1,6 +1,6 @@
 // https://github.com/karma-runner/karma-chrome-launcher
 process.env.CHROME_BIN = require("puppeteer").executablePath();
-require("dotenv").config({ path: "../.env" });
+require("dotenv").config();
 const {
   jsonRecordingFilterFunction,
   isPlaybackMode,

sdk/keyvault/keyvault-keys/package.json

@@ -106,12 +106,14 @@
     "@rollup/plugin-node-resolve": "^8.0.0",
     "@rollup/plugin-replace": "^2.2.0",
     "@types/chai": "^4.1.6",
+    "@types/chai-as-promised": "^7.1.0",
     "@types/mocha": "^7.0.2",
     "@types/node": "^8.0.0",
     "@types/query-string": "6.2.0",
     "@types/sinon": "^9.0.4",
     "assert": "^1.4.1",
     "chai": "^4.2.0",
+    "chai-as-promised": "^7.1.1",
     "cross-env": "^7.0.2",
     "dotenv": "^8.2.0",
     "eslint": "^7.15.0",