[Communication] - Authentication - PhoneNumberAdministrationClient auth using token credential (Azure#13271)

* [phoneNumberAdminstrationClient] adding new constructor for phone number to use Token Credential
* [Conflict] taking incoming recordings
* [Recording] Update the query to be true
* [README] update the examples and changelog
* [phoneNumberAdministrationClientWithToken.spec] renmae the test to be more relevant
* [recordedClient] using new common function to create endpoint
* [recordedClient] removing unused COMMUNICATION_ENDPOINT
* [tests.yml] adding the new env vars

Author: JoshuaLai

sdk/communication/communication-administration/CHANGELOG.md

@@ -14,6 +14,7 @@
 ### Added
 
 - `CommunicationIdentityClient` added a constructor that supports `TokenCredential`.
+- `PhoneNumberAdministrationClient` added a constructor that supports `TokenCredential`.
 
 ## 1.0.0-beta.3 (2020-11-16)
 

sdk/communication/communication-administration/README.md

@@ -56,18 +56,19 @@ const client = new CommunicationIdentityClient(HOST, credential);
 ### Using a connection string
 
 ```typescript
-import { PhoneNumberAdministrationClient } from "@azure/communication-administration";
+import { CommunicationIdentityClient } from "@azure/communication-administration";
 
 const connectionString = `endpoint=HOST;accessKey=KEY`;
 const client = new CommunicationIdentityClient(connectionString);
 ```
 
-### Using a `TokenCredential`
+### Using Azure Active Directory Authentication
 
 ```typescript
 import { CommunicationIdentityClient } from "@azure/communication-administration";
+import { DefaultAzureCredential } from "@azure/identity";
 
-let credential = new DefaultAzureCredential();
+const credential = new DefaultAzureCredential();
 const client = new CommunicationIdentityClient(HOST, credential);
 ```
 
@@ -134,9 +135,19 @@ await client.deleteUser(user);
 #### Creating an instance of PhoneNumberAdministrationClient
 
 ```typescript
-import { CommunicationIdentityClient } from "@azure/communication-administration";
+import { PhoneNumberAdministrationClient } from "@azure/communication-administration";
 
-const client = new CommunicationIdentityClient(CONNECTION_STRING);
+const client = new PhoneNumberAdministrationClient(CONNECTION_STRING);
+```
+
+#### Creating an instance of PhoneNumberAdministrationClient with Azure Active Directory Authentication
+
+```typescript
+import { PhoneNumberAdministrationClient } from "@azure/communication-administration";
+import { DefaultAzureCredential } from "@azure/identity";
+
+const credential = new DefaultAzureCredential();
+const client = new PhoneNumberAdministrationClient(HOST, credential);
 ```
 
 #### Getting countries

sdk/communication/communication-administration/karma.conf.js

@@ -60,10 +60,10 @@ module.exports = function(config) {
       "TEST_MODE",
       "COMMUNICATION_CONNECTION_STRING",
       "INCLUDE_PHONENUMBER_TESTS",
-      "COMMUNICATION_ENDPOINT",
       "AZURE_CLIENT_ID",
       "AZURE_CLIENT_SECRET",
-      "AZURE_TENANT_ID"
+      "AZURE_TENANT_ID",
+      "AZURE_PHONE_NUMBER"
     ],
 
     // test results reporter to use