Skip to content

Commit 40b027d

Browse files
xirzecxirzec
authored
Update karma test configuration for track2 packages (Azure#13309)
This PR removes our dependency on the unmaintained package "karma-remap-istanbul" and replaces it with a smaller karma plugin ("karma-sourcemap-loader") that allows karma-coverage to load source maps from the disk correctly. I tested and confirmed that the generated coverage data has the correct source TS files.
1 parent e75a0b7 commit 40b027d

File tree

78 files changed

+694
-841
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+694
-841
lines changed

‎common/config/rush/pnpm-lock.yaml‎

Lines changed: 313 additions & 261 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dataplane.code-workspace‎

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
"name": "communication-chat",
2121
"path": "sdk/communication/communication-chat"
2222
},
23+
{
24+
"name": "communication-common",
25+
"path": "sdk/communication/communication-common"
26+
},
2327
{
2428
"name": "communication-sms",
2529
"path": "sdk/communication/communication-sms"
@@ -70,7 +74,7 @@
7074
},
7175
{
7276
"name": "eventgrid",
73-
"path": "sdk\\eventgrid\\eventgrid"
77+
"path": "sdk/eventgrid/eventgrid"
7478
},
7579
{
7680
"name": "event-hubs",
@@ -96,6 +100,10 @@
96100
"name": "identity",
97101
"path": "sdk/identity/identity"
98102
},
103+
{
104+
"name": "keyvault-admin",
105+
"path": "sdk/keyvault/keyvault-admin"
106+
},
99107
{
100108
"name": "keyvault-certificates",
101109
"path": "sdk/keyvault/keyvault-certificates"
@@ -114,12 +122,16 @@
114122
},
115123
{
116124
"name": "metrics-advisor",
117-
"path": "sdk\\metricsadvisor\\ai-metrics-advisor"
125+
"path": "sdk/metricsadvisor/ai-metrics-advisor"
118126
},
119127
{
120128
"name": "schema-registry",
121129
"path": "sdk/schemaregistry/schema-registry"
122130
},
131+
{
132+
"name": "schema-registry-avro",
133+
"path": "sdk/schemaregistry/schema-registry-avro"
134+
},
123135
{
124136
"name": "search",
125137
"path": "sdk/search/search-documents"
@@ -209,7 +221,12 @@
209221
"path": "sdk/test-utils/multi-version"
210222
},
211223
{
212-
"path": "sdk\\digitaltwins\\digital-twins-core"
224+
"name": "digital-twins-core",
225+
"path": "sdk/digitaltwins/digital-twins-core"
226+
},
227+
{
228+
"name": "attestation",
229+
"path": "sdk/attestation/attestation"
213230
}
214231
],
215232
"settings": {

‎sdk/anomalydetector/ai-anomaly-detector/karma.conf.js‎

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module.exports = function(config) {
2626
"karma-ie-launcher",
2727
"karma-env-preprocessor",
2828
"karma-coverage",
29-
"karma-remap-istanbul",
29+
"karma-sourcemap-loader",
3030
"karma-junit-reporter",
3131
"karma-json-preprocessor",
3232
"karma-json-to-file-reporter"
@@ -44,7 +44,7 @@ module.exports = function(config) {
4444
// preprocess matching files before serving them to the browser
4545
// available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
4646
preprocessors: {
47-
"**/*.js": ["env"],
47+
"**/*.js": ["sourcemap", "env"],
4848
"recordings/browsers/**/*.json": ["json"],
4949
// IMPORTANT: COMMENT following line if you want to debug in your browsers!!
5050
// Preprocess source file to calculate code coverage, however this will make source file unreadable
@@ -56,22 +56,17 @@ module.exports = function(config) {
5656
// test results reporter to use
5757
// possible values: 'dots', 'progress'
5858
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
59-
reporters: ["mocha", "coverage", "karma-remap-istanbul", "junit", "json-to-file"],
59+
reporters: ["mocha", "coverage", "junit", "json-to-file"],
6060

6161
coverageReporter: {
6262
// specify a common output directory
6363
dir: "coverage-browser/",
64-
reporters: [{ type: "json", subdir: ".", file: "coverage.json" }]
65-
},
66-
67-
remapIstanbulReporter: {
68-
src: "coverage-browser/coverage.json",
69-
reports: {
70-
lcovonly: "coverage-browser/lcov.info",
71-
html: "coverage-browser/html/report",
72-
"text-summary": null,
73-
cobertura: "./coverage-browser/cobertura-coverage.xml"
74-
}
64+
reporters: [
65+
{ type: "json", subdir: ".", file: "coverage.json" },
66+
{ type: "lcovonly", subdir: ".", file: "lcov.info" },
67+
{ type: "html", subdir: "html" },
68+
{ type: "cobertura", subdir: ".", file: "cobertura-coverage.xml" }
69+
]
7570
},
7671

7772
junitReporter: {

‎sdk/anomalydetector/ai-anomaly-detector/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
"karma-junit-reporter": "^2.0.1",
9999
"karma-mocha": "^2.0.1",
100100
"karma-mocha-reporter": "^2.2.5",
101-
"karma-remap-istanbul": "^0.6.0",
101+
"karma-sourcemap-loader": "^0.3.8",
102102
"mocha": "^7.1.1",
103103
"mocha-junit-reporter": "^1.18.0",
104104
"nyc": "^14.0.0",

‎sdk/appconfiguration/app-configuration/karma.conf.js‎

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module.exports = function(config) {
2020
"karma-ie-launcher",
2121
"karma-env-preprocessor",
2222
"karma-coverage",
23-
"karma-remap-istanbul",
23+
"karma-sourcemap-loader",
2424
"karma-junit-reporter"
2525
],
2626

@@ -59,22 +59,17 @@ module.exports = function(config) {
5959
// test results reporter to use
6060
// possible values: 'dots', 'progress'
6161
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
62-
reporters: ["mocha", "coverage", "karma-remap-istanbul", "junit"],
62+
reporters: ["mocha", "coverage", "junit"],
6363

6464
coverageReporter: {
6565
// specify a common output directory
6666
dir: "coverage-browser/",
67-
reporters: [{ type: "json", subdir: ".", file: "coverage.json" }]
68-
},
69-
70-
remapIstanbulReporter: {
71-
src: "coverage-browser/coverage.json",
72-
reports: {
73-
lcovonly: "coverage-browser/lcov.info",
74-
html: "coverage-browser/html/report",
75-
"text-summary": null,
76-
cobertura: "./coverage-browser/cobertura-coverage.xml"
77-
}
67+
reporters: [
68+
{ type: "json", subdir: ".", file: "coverage.json" },
69+
{ type: "lcovonly", subdir: ".", file: "lcov.info" },
70+
{ type: "html", subdir: "html" },
71+
{ type: "cobertura", subdir: ".", file: "cobertura-coverage.xml" }
72+
]
7873
},
7974

8075
junitReporter: {

‎sdk/appconfiguration/app-configuration/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
"karma-junit-reporter": "^2.0.1",
125125
"karma-mocha": "^2.0.1",
126126
"karma-mocha-reporter": "^2.2.5",
127-
"karma-remap-istanbul": "^0.6.0",
127+
"karma-sourcemap-loader": "^0.3.8",
128128
"mocha": "^7.1.1",
129129
"mocha-junit-reporter": "^1.18.0",
130130
"nock": "^12.0.3",

‎sdk/attestation/attestation/karma.conf.js‎

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module.exports = function(config) {
2929
"karma-ie-launcher",
3030
"karma-env-preprocessor",
3131
"karma-coverage",
32-
"karma-remap-istanbul",
32+
"karma-sourcemap-loader",
3333
"karma-junit-reporter",
3434
"karma-json-to-file-reporter",
3535
"karma-source-map-support",
@@ -71,22 +71,17 @@ module.exports = function(config) {
7171
// test results reporter to use
7272
// possible values: 'dots', 'progress'
7373
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
74-
reporters: ["mocha", "coverage", "karma-remap-istanbul", "junit", "json-to-file"],
74+
reporters: ["mocha", "coverage", "junit", "json-to-file"],
7575

7676
coverageReporter: {
7777
// specify a common output directory
7878
dir: "coverage-browser/",
79-
reporters: [{ type: "json", subdir: ".", file: "coverage.json" }]
80-
},
81-
82-
remapIstanbulReporter: {
83-
src: "coverage-browser/coverage.json",
84-
reports: {
85-
lcovonly: "coverage-browser/lcov.info",
86-
html: "coverage-browser/html/report",
87-
"text-summary": null,
88-
cobertura: "./coverage-browser/cobertura-coverage.xml"
89-
}
79+
reporters: [
80+
{ type: "json", subdir: ".", file: "coverage.json" },
81+
{ type: "lcovonly", subdir: ".", file: "lcov.info" },
82+
{ type: "html", subdir: "html" },
83+
{ type: "cobertura", subdir: ".", file: "cobertura-coverage.xml" }
84+
]
9085
},
9186

9287
junitReporter: {

‎sdk/attestation/attestation/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"karma-junit-reporter": "^2.0.1",
5454
"karma-mocha": "^2.0.1",
5555
"karma-mocha-reporter": "^2.2.5",
56-
"karma-remap-istanbul": "^0.6.0",
56+
"karma-sourcemap-loader": "^0.3.8",
5757
"karma-source-map-support": "~1.4.0",
5858
"mocha": "^7.1.1",
5959
"nyc": "^14.0.0",

‎sdk/communication/communication-administration/karma.conf.js‎

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module.exports = function(config) {
2626
"karma-ie-launcher",
2727
"karma-env-preprocessor",
2828
"karma-coverage",
29-
"karma-remap-istanbul",
29+
"karma-sourcemap-loader",
3030
"karma-junit-reporter",
3131
"karma-json-to-file-reporter",
3232
"karma-json-preprocessor"
@@ -46,7 +46,7 @@ module.exports = function(config) {
4646
// preprocess matching files before serving them to the browser
4747
// available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
4848
preprocessors: {
49-
"**/*.js": ["env"],
49+
"**/*.js": ["sourcemap", "env"],
5050
"recordings/browsers/**/*.json": ["json"]
5151
// IMPORTANT: COMMENT following line if you want to debug in your browsers!!
5252
// Preprocess source file to calculate code coverage, however this will make source file unreadable
@@ -69,30 +69,19 @@ module.exports = function(config) {
6969
// test results reporter to use
7070
// possible values: 'dots', 'progress'
7171
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
72-
reporters: ["mocha", "coverage", "karma-remap-istanbul", "junit", "json-to-file"],
72+
reporters: ["mocha", "coverage", "junit", "json-to-file"],
7373

7474
coverageReporter: {
7575
// specify a common output directory
7676
dir: "coverage-browser/",
7777
reporters: [
78-
{
79-
type: "json",
80-
subdir: ".",
81-
file: "coverage.json"
82-
}
78+
{ type: "json", subdir: ".", file: "coverage.json" },
79+
{ type: "lcovonly", subdir: ".", file: "lcov.info" },
80+
{ type: "html", subdir: "html" },
81+
{ type: "cobertura", subdir: ".", file: "cobertura-coverage.xml" }
8382
]
8483
},
8584

86-
remapIstanbulReporter: {
87-
src: "coverage-browser/coverage.json",
88-
reports: {
89-
lcovonly: "coverage-browser/lcov.info",
90-
html: "coverage-browser/html/report",
91-
"text-summary": null,
92-
cobertura: "./coverage-browser/cobertura-coverage.xml"
93-
}
94-
},
95-
9685
junitReporter: {
9786
outputDir: "", // results will be saved as $outputDir/$browserName.xml
9887
outputFile: "test-results.browser.xml", // if included, results will be saved as $outputDir/$browserName/$outputFile

‎sdk/communication/communication-administration/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
"karma-junit-reporter": "^2.0.1",
113113
"karma-mocha-reporter": "^2.2.5",
114114
"karma-mocha": "^2.0.1",
115-
"karma-remap-istanbul": "^0.6.0",
115+
"karma-sourcemap-loader": "^0.3.8",
116116
"karma": "^5.1.0",
117117
"mocha-junit-reporter": "^1.18.0",
118118
"mocha": "^7.1.1",

0 commit comments

Comments
 (0)