[Dev tool] Support samples v2 directory structure in check node versions command (Azure#15328)

Samples v2 uses a directory structure like this `samples/v<some package version>` instead of the good old `samples`. Furthermore, it is not guaranteed that the package version is the most recent major one because a package author can decide to change it to another number. This PR adds logic to handle both samples v1 and v2 and make sure to use the appropriate corresponding path. If there is more than one samples v2 directory, the command will run the samples in the directory with the largest version number.

Author: deyaaeldeen

common/tools/dev-tool/src/commands/samples/checkNodeVersions.ts

@@ -68,19 +68,40 @@ async function cleanup(
   await deleteDockerImages(dockerImageNames);
 }
 
+function findSamplesDir(samplesDir: string, rootDir: string): string {
+  const dirs = [];
+  for (const file of fs.readdirSync(samplesDir)) {
+    const stats = fs.statSync(path.join(samplesDir, file));
+    if (stats.isDirectory()) {
+      if (file.match(/^v[0-9]*.*$/)) {
+        dirs.push(file);
+      }
+    }
+  }
+  if (dirs.length === 0) {
+    return `${rootDir}/samples`;
+  } else {
+    return `${rootDir}/samples/${dirs
+      .sort()
+      .slice(-1)
+      .pop()}`;
+  }
+}
 function buildRunSamplesScript(
   containerWorkspacePath: string,
+  samplesPath: string,
   artifactURL: string,
   envFileName: string,
   logFilePath?: string
 ) {
   function compileCMD(cmd: string, printToScreen?: boolean) {
     return printToScreen ? cmd : `${cmd} >> ${logFilePath} 2>&1`;
   }
+  const samplesDir = findSamplesDir(samplesPath, containerWorkspacePath);
   const printToScreen = logFilePath === undefined;
   const envFilePath = `${containerWorkspacePath}/${envFileName}`;
-  const javascriptSamplesPath = `${containerWorkspacePath}/samples/javascript`;
-  const typescriptCompiledSamplesPath = `${containerWorkspacePath}/samples/typescript/dist`;
+  const javascriptSamplesPath = `${samplesDir}/javascript`;
+  const typescriptCompiledSamplesPath = `${samplesDir}/typescript/dist`;
   const scriptContent = `#!/bin/sh
 
 function install_dependencies_helper() {
@@ -92,9 +113,9 @@ function install_dependencies_helper() {
 
 function install_packages() {
   echo "Using node \$(node -v) to install dependencies";
-  install_dependencies_helper ${containerWorkspacePath}/samples/javascript
-  install_dependencies_helper ${containerWorkspacePath}/samples/typescript;
-  cp ${envFilePath} ${containerWorkspacePath}/samples/javascript/;
+  install_dependencies_helper ${samplesDir}/javascript
+  install_dependencies_helper ${samplesDir}/typescript;
+  cp ${envFilePath} ${samplesDir}/javascript/;
 }
 
 function run_samples() {
@@ -108,9 +129,9 @@ function run_samples() {
 
 function build_typescript() {
   echo "Using node \$(node -v) to build the typescript samples";
-  cd ${containerWorkspacePath}/samples/typescript
+  cd ${samplesDir}/typescript
   ${compileCMD(`npm run build`, printToScreen)}
-  cp ${envFilePath} ${containerWorkspacePath}/samples/typescript/dist/
+  cp ${envFilePath} ${samplesDir}/typescript/dist/
 }
 
 function main() {
@@ -126,7 +147,7 @@ main`;
 function createDockerContextDirectory(
   dockerContextDirectory: string,
   containerWorkspacePath: string,
-  samples_path: string,
+  samplesPath: string,
   envPath: string,
   artifactPath?: string,
   logFilePath?: string
@@ -143,7 +164,7 @@ function createDockerContextDirectory(
     throw new Error("artifact_path is a required argument but it was not passed");
   }
   const envFileName = path.basename(envPath);
-  fs.copySync(samples_path, path.join(dockerContextDirectory, "samples"));
+  fs.copySync(samplesPath, path.join(dockerContextDirectory, "samples"));
   let artifactURL: string | undefined = undefined;
   if (fs.existsSync(artifactPath)) {
     const artifactName = path.basename(artifactPath);
@@ -157,7 +178,13 @@ function createDockerContextDirectory(
   fs.copyFileSync(envPath, path.join(dockerContextDirectory, envFileName));
   fs.writeFileSync(
     path.join(dockerContextDirectory, "run_samples.sh"),
-    buildRunSamplesScript(containerWorkspacePath, artifactURL, envFileName, logFilePath),
+    buildRunSamplesScript(
+      containerWorkspacePath,
+      samplesPath,
+      artifactURL,
+      envFileName,
+      logFilePath
+    ),
     { mode: S_IRWXO }
   );
 }