Skip to content

Commit 4f2c6cb

Browse files
[App Config] FeatureFlag (and SecretReference) redesign - version 8.1 (Azure#15193)
Based on option 8 at https://gist.github.com/HarshaNalluru/d4d9aa16c89eaceb50a005df800bf4ea Sample https://github.com/Azure/azure-sdk-for-js/blob/6723c01b83a888b02c4f6743c33d0d43dc26558e/sdk/appconfiguration/app-configuration/samples-dev/featureFlag.ts ### TODO - [x] New design for - [x] feature flag - [x] secret reference - [x] Api Report - [x] update tests for both, and fix playback - [x] samples for both - [x] samples-dev - [x] regenerate docs.microsoft.com samples - [x] update readmes accordingly - [x] update react sample - [x] changelog
1 parent 25386e9 commit 4f2c6cb

File tree

32 files changed

+1023
-1262
lines changed

32 files changed

+1023
-1262
lines changed

common/config/rush/common-versions.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@
7070
"@azure/ms-rest-nodeauth": ["^0.9.2"],
7171
// Idenity is moving from v1 to v2. Moving all packages to v2 is going to take a bit of time, in the mean time we could use v2 on the perf-identity tests.
7272
"@azure/identity": ["2.0.0-beta.3", "^1.1.0"],
73+
// App Config uses keyvault-secrets in a sample, switch to latest once the preview becomes GA
74+
"@azure/keyvault-secrets": ["^4.1.0", "^4.2.0-beta.4"],
7375
// Issue #14771 tracks updating to these versions
7476
"@microsoft/api-extractor": ["7.13.2"],
7577
"prettier": ["2.2.1"]

common/config/rush/pnpm-lock.yaml

Lines changed: 17 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/appconfiguration/app-configuration/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
## 1.2.0-beta.2 (Unreleased)
44

55
- With [#15136](https://github.com/Azure/azure-sdk-for-js/pull/15136), if the key of a feature flag(setting with `contentType="application/vnd.microsoft.appconfig.ff+json;charset=utf-8"`) doesn't start with `".appconfig.featureflag/"` (featureFlagPrefix), SDK adds the prefix before sending the request.
6+
- New design for feature flags and secret references,
7+
- New types for FeatureFlag and SecretReference - `ConfigurationSetting<FeatureFlagValue>` and `ConfigurationSetting<SecretReferenceValue>`
8+
- Upon using `getConfigurationSetting`(or add/update), use `parseFeatureFlag` and `parseSecretReference` methods to access the properties(to translate `ConfigurationSetting` into the types above).
9+
- Helper method `isFeatureFlag` (and `isSecretReference`) checks the contentType and return boolean values.
610

711
## 1.2.0-beta.1 (2021-04-06)
812

sdk/appconfiguration/app-configuration/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
"@azure/dev-tool": "^1.0.0",
9797
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
9898
"@azure/identity": "2.0.0-beta.3",
99-
"@azure/keyvault-secrets": "^4.2.0-beta.4",
99+
"@azure/keyvault-secrets": "^4.1.0",
100100
"@azure/test-utils-recorder": "^1.0.0",
101101
"@microsoft/api-extractor": "7.7.11",
102102
"@rollup/plugin-commonjs": "11.0.2",

sdk/appconfiguration/app-configuration/recordings/node/appconfigurationclient__featureflag_featureflag_configuration_setting/recording_can_add_and_get_featureflag.js

Lines changed: 25 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)