[AutoPR sdk/logic/mgmt-v2018_07_01_preview] [Hub Generated] Review request for Microsoft.Logic to add version stable/2019-05-01

sdk/logic/mgmt-v2018_07_01_preview/pom.xml

@@ -11,11 +11,11 @@
     <parent>
         <groupId>com.microsoft.azure</groupId>
         <artifactId>azure-arm-parent</artifactId>
-        <version>1.2.0</version>
-        <relativePath>../../parents/azure-arm-parent</relativePath>
+        <version>1.1.0</version>
+        <relativePath>../../../pom.management.xml</relativePath>
     </parent>
     <artifactId>azure-mgmt-logic</artifactId>
-    <version>1.0.0-beta-1</version>
+    <version>1.0.0-beta</version>
     <packaging>jar</packaging>
     <name>Microsoft Azure SDK for Logic Management</name>
     <description>This package contains Microsoft Logic Management SDK.</description>
@@ -71,6 +71,8 @@
             <artifactId>azure-arm-client-runtime</artifactId>
             <type>test-jar</type>
             <scope>test</scope>
+            <!--Below version for test jar needs to be removed, this will be done as part of v1-runtime 1.6.7-->
+            <version>1.6.5</version>
         </dependency>
     </dependencies>
     <build>

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/Workflow.java

@@ -104,7 +104,7 @@ interface WithGroup extends GroupableResourceCore.DefinitionStages.WithGroup<Wit
         interface WithDefinition {
             /**
              * Specifies definition.
-             * @param definition The definition
+             * @param definition The definition. See [Schema reference for Workflow Definition Language in Azure Logic Apps](https://aka.ms/logic-apps-workflow-definition-language)
              * @return the next definition stage
              */
             WithCreate withDefinition(Object definition);
@@ -182,7 +182,7 @@ interface UpdateStages {
         interface WithDefinition {
             /**
              * Specifies definition.
-             * @param definition The definition
+             * @param definition The definition. See [Schema reference for Workflow Definition Language in Azure Logic Apps](https://aka.ms/logic-apps-workflow-definition-language)
              * @return the next update stage
              */
             Update withDefinition(Object definition);

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/WorkflowRuns.java

@@ -8,8 +8,8 @@
 
 package com.microsoft.azure.management.logic.v2018_07_01_preview;
 
-import rx.Observable;
 import rx.Completable;
+import rx.Observable;
 import com.microsoft.azure.management.logic.v2018_07_01_preview.implementation.WorkflowRunsInner;
 import com.microsoft.azure.arm.model.HasInner;
 
@@ -49,4 +49,15 @@ public interface WorkflowRuns extends HasInner<WorkflowRunsInner> {
      */
     Observable<WorkflowWorkflowRun> listAsync(final String resourceGroupName, final String workflowName);
 
+    /**
+     * Deletes a workflow run.
+     *
+     * @param resourceGroupName The resource group name.
+     * @param workflowName The workflow name.
+     * @param runName The workflow run name.
+     * @throws IllegalArgumentException thrown if parameters fail the validation
+     * @return the observable for the request
+     */
+    Completable deleteAsync(String resourceGroupName, String workflowName, String runName);
+
 }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountAgreementsImpl.java

@@ -78,10 +78,14 @@ public IntegrationAccountAgreement call(IntegrationAccountAgreementInner inner)
     public Observable<IntegrationAccountAgreement> getAsync(String resourceGroupName, String integrationAccountName, String agreementName) {
         IntegrationAccountAgreementsInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, agreementName)
-        .map(new Func1<IntegrationAccountAgreementInner, IntegrationAccountAgreement>() {
+        .flatMap(new Func1<IntegrationAccountAgreementInner, Observable<IntegrationAccountAgreement>>() {
             @Override
-            public IntegrationAccountAgreement call(IntegrationAccountAgreementInner inner) {
-                return wrapModel(inner);
+            public Observable<IntegrationAccountAgreement> call(IntegrationAccountAgreementInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((IntegrationAccountAgreement)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountAssembliesImpl.java

@@ -77,10 +77,14 @@ public AssemblyDefinition call(AssemblyDefinitionInner inner) {
     public Observable<AssemblyDefinition> getAsync(String resourceGroupName, String integrationAccountName, String assemblyArtifactName) {
         IntegrationAccountAssembliesInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, assemblyArtifactName)
-        .map(new Func1<AssemblyDefinitionInner, AssemblyDefinition>() {
+        .flatMap(new Func1<AssemblyDefinitionInner, Observable<AssemblyDefinition>>() {
             @Override
-            public AssemblyDefinition call(AssemblyDefinitionInner inner) {
-                return wrapModel(inner);
+            public Observable<AssemblyDefinition> call(AssemblyDefinitionInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((AssemblyDefinition)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountBatchConfigurationsImpl.java

@@ -64,10 +64,14 @@ public BatchConfiguration call(BatchConfigurationInner inner) {
     public Observable<BatchConfiguration> getAsync(String resourceGroupName, String integrationAccountName, String batchConfigurationName) {
         IntegrationAccountBatchConfigurationsInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, batchConfigurationName)
-        .map(new Func1<BatchConfigurationInner, BatchConfiguration>() {
+        .flatMap(new Func1<BatchConfigurationInner, Observable<BatchConfiguration>>() {
             @Override
-            public BatchConfiguration call(BatchConfigurationInner inner) {
-                return wrapModel(inner);
+            public Observable<BatchConfiguration> call(BatchConfigurationInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((BatchConfiguration)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountCertificatesImpl.java

@@ -64,10 +64,14 @@ public IntegrationAccountCertificate call(IntegrationAccountCertificateInner inn
     public Observable<IntegrationAccountCertificate> getAsync(String resourceGroupName, String integrationAccountName, String certificateName) {
         IntegrationAccountCertificatesInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, certificateName)
-        .map(new Func1<IntegrationAccountCertificateInner, IntegrationAccountCertificate>() {
+        .flatMap(new Func1<IntegrationAccountCertificateInner, Observable<IntegrationAccountCertificate>>() {
             @Override
-            public IntegrationAccountCertificate call(IntegrationAccountCertificateInner inner) {
-                return wrapModel(inner);
+            public Observable<IntegrationAccountCertificate> call(IntegrationAccountCertificateInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((IntegrationAccountCertificate)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountMapsImpl.java

@@ -78,10 +78,14 @@ public IntegrationAccountMap call(IntegrationAccountMapInner inner) {
     public Observable<IntegrationAccountMap> getAsync(String resourceGroupName, String integrationAccountName, String mapName) {
         IntegrationAccountMapsInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, mapName)
-        .map(new Func1<IntegrationAccountMapInner, IntegrationAccountMap>() {
+        .flatMap(new Func1<IntegrationAccountMapInner, Observable<IntegrationAccountMap>>() {
             @Override
-            public IntegrationAccountMap call(IntegrationAccountMapInner inner) {
-                return wrapModel(inner);
+            public Observable<IntegrationAccountMap> call(IntegrationAccountMapInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((IntegrationAccountMap)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountPartnersImpl.java

@@ -78,10 +78,14 @@ public IntegrationAccountPartner call(IntegrationAccountPartnerInner inner) {
     public Observable<IntegrationAccountPartner> getAsync(String resourceGroupName, String integrationAccountName, String partnerName) {
         IntegrationAccountPartnersInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, partnerName)
-        .map(new Func1<IntegrationAccountPartnerInner, IntegrationAccountPartner>() {
+        .flatMap(new Func1<IntegrationAccountPartnerInner, Observable<IntegrationAccountPartner>>() {
             @Override
-            public IntegrationAccountPartner call(IntegrationAccountPartnerInner inner) {
-                return wrapModel(inner);
+            public Observable<IntegrationAccountPartner> call(IntegrationAccountPartnerInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((IntegrationAccountPartner)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountSchemasImpl.java

@@ -78,10 +78,14 @@ public IntegrationAccountSchema call(IntegrationAccountSchemaInner inner) {
     public Observable<IntegrationAccountSchema> getAsync(String resourceGroupName, String integrationAccountName, String schemaName) {
         IntegrationAccountSchemasInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, schemaName)
-        .map(new Func1<IntegrationAccountSchemaInner, IntegrationAccountSchema>() {
+        .flatMap(new Func1<IntegrationAccountSchemaInner, Observable<IntegrationAccountSchema>>() {
             @Override
-            public IntegrationAccountSchema call(IntegrationAccountSchemaInner inner) {
-                return wrapModel(inner);
+            public Observable<IntegrationAccountSchema> call(IntegrationAccountSchemaInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((IntegrationAccountSchema)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/IntegrationAccountSessionsImpl.java

@@ -64,10 +64,14 @@ public IntegrationAccountSession call(IntegrationAccountSessionInner inner) {
     public Observable<IntegrationAccountSession> getAsync(String resourceGroupName, String integrationAccountName, String sessionName) {
         IntegrationAccountSessionsInner client = this.inner();
         return client.getAsync(resourceGroupName, integrationAccountName, sessionName)
-        .map(new Func1<IntegrationAccountSessionInner, IntegrationAccountSession>() {
+        .flatMap(new Func1<IntegrationAccountSessionInner, Observable<IntegrationAccountSession>>() {
             @Override
-            public IntegrationAccountSession call(IntegrationAccountSessionInner inner) {
-                return wrapModel(inner);
+            public Observable<IntegrationAccountSession> call(IntegrationAccountSessionInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((IntegrationAccountSession)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/WorkflowInner.java

@@ -80,7 +80,9 @@ public class WorkflowInner extends Resource {
     private ResourceReference integrationAccount;
 
     /**
-     * The definition.
+     * The definition. See [Schema reference for Workflow Definition Language
+     * in Azure Logic
+     * Apps](https://aka.ms/logic-apps-workflow-definition-language).
      */
     @JsonProperty(value = "properties.definition")
     private Object definition;
@@ -197,7 +199,7 @@ public WorkflowInner withIntegrationAccount(ResourceReference integrationAccount
     }
 
     /**
-     * Get the definition.
+     * Get the definition. See [Schema reference for Workflow Definition Language in Azure Logic Apps](https://aka.ms/logic-apps-workflow-definition-language).
      *
      * @return the definition value
      */
@@ -206,7 +208,7 @@ public Object definition() {
     }
 
     /**
-     * Set the definition.
+     * Set the definition. See [Schema reference for Workflow Definition Language in Azure Logic Apps](https://aka.ms/logic-apps-workflow-definition-language).
      *
      * @param definition the definition value to set
      * @return the WorkflowInner object itself.

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/WorkflowRunActionRepetitionsImpl.java

@@ -73,10 +73,14 @@ public ActionRunWorkflowWorkflowRunActionRepetitionDefinition call(WorkflowRunAc
     public Observable<ActionRunWorkflowWorkflowRunActionRepetitionDefinition> getAsync(String resourceGroupName, String workflowName, String runName, String actionName, String repetitionName) {
         WorkflowRunActionRepetitionsInner client = this.inner();
         return client.getAsync(resourceGroupName, workflowName, runName, actionName, repetitionName)
-        .map(new Func1<WorkflowRunActionRepetitionDefinitionInner, ActionRunWorkflowWorkflowRunActionRepetitionDefinition>() {
+        .flatMap(new Func1<WorkflowRunActionRepetitionDefinitionInner, Observable<ActionRunWorkflowWorkflowRunActionRepetitionDefinition>>() {
             @Override
-            public ActionRunWorkflowWorkflowRunActionRepetitionDefinition call(WorkflowRunActionRepetitionDefinitionInner inner) {
-                return wrapModel(inner);
+            public Observable<ActionRunWorkflowWorkflowRunActionRepetitionDefinition> call(WorkflowRunActionRepetitionDefinitionInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((ActionRunWorkflowWorkflowRunActionRepetitionDefinition)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/WorkflowRunActionRepetitionsRequestHistoriesImpl.java

@@ -54,10 +54,14 @@ public RepetitionActionRunWorkflowRequestHistory call(RequestHistoryInner inner)
     public Observable<RepetitionActionRunWorkflowRequestHistory> getAsync(String resourceGroupName, String workflowName, String runName, String actionName, String repetitionName, String requestHistoryName) {
         WorkflowRunActionRepetitionsRequestHistoriesInner client = this.inner();
         return client.getAsync(resourceGroupName, workflowName, runName, actionName, repetitionName, requestHistoryName)
-        .map(new Func1<RequestHistoryInner, RepetitionActionRunWorkflowRequestHistory>() {
+        .flatMap(new Func1<RequestHistoryInner, Observable<RepetitionActionRunWorkflowRequestHistory>>() {
             @Override
-            public RepetitionActionRunWorkflowRequestHistory call(RequestHistoryInner inner) {
-                return wrapModel(inner);
+            public Observable<RepetitionActionRunWorkflowRequestHistory> call(RequestHistoryInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((RepetitionActionRunWorkflowRequestHistory)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/WorkflowRunActionRequestHistoriesImpl.java

@@ -54,10 +54,14 @@ public ActionRunWorkflowRequestHistory call(RequestHistoryInner inner) {
     public Observable<ActionRunWorkflowRequestHistory> getAsync(String resourceGroupName, String workflowName, String runName, String actionName, String requestHistoryName) {
         WorkflowRunActionRequestHistoriesInner client = this.inner();
         return client.getAsync(resourceGroupName, workflowName, runName, actionName, requestHistoryName)
-        .map(new Func1<RequestHistoryInner, ActionRunWorkflowRequestHistory>() {
+        .flatMap(new Func1<RequestHistoryInner, Observable<ActionRunWorkflowRequestHistory>>() {
             @Override
-            public ActionRunWorkflowRequestHistory call(RequestHistoryInner inner) {
-                return wrapModel(inner);
+            public Observable<ActionRunWorkflowRequestHistory> call(RequestHistoryInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((ActionRunWorkflowRequestHistory)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/WorkflowRunActionScopeRepetitionsImpl.java

@@ -48,10 +48,14 @@ public WorkflowRunActionRepetitionDefinitionCollection call(WorkflowRunActionRep
     public Observable<ActionRunWorkflowWorkflowRunActionRepetitionDefinitionModel> getAsync(String resourceGroupName, String workflowName, String runName, String actionName, String repetitionName) {
         WorkflowRunActionScopeRepetitionsInner client = this.inner();
         return client.getAsync(resourceGroupName, workflowName, runName, actionName, repetitionName)
-        .map(new Func1<WorkflowRunActionRepetitionDefinitionInner, ActionRunWorkflowWorkflowRunActionRepetitionDefinitionModel>() {
+        .flatMap(new Func1<WorkflowRunActionRepetitionDefinitionInner, Observable<ActionRunWorkflowWorkflowRunActionRepetitionDefinitionModel>>() {
             @Override
-            public ActionRunWorkflowWorkflowRunActionRepetitionDefinitionModel call(WorkflowRunActionRepetitionDefinitionInner inner) {
-                return wrapModel(inner);
+            public Observable<ActionRunWorkflowWorkflowRunActionRepetitionDefinitionModel> call(WorkflowRunActionRepetitionDefinitionInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((ActionRunWorkflowWorkflowRunActionRepetitionDefinitionModel)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/WorkflowRunActionsImpl.java

@@ -74,10 +74,14 @@ public WorkflowRunAction call(WorkflowRunActionInner inner) {
     public Observable<WorkflowRunAction> getAsync(String resourceGroupName, String workflowName, String runName, String actionName) {
         WorkflowRunActionsInner client = this.inner();
         return client.getAsync(resourceGroupName, workflowName, runName, actionName)
-        .map(new Func1<WorkflowRunActionInner, WorkflowRunAction>() {
+        .flatMap(new Func1<WorkflowRunActionInner, Observable<WorkflowRunAction>>() {
             @Override
-            public WorkflowRunAction call(WorkflowRunActionInner inner) {
-                return wrapModel(inner);
+            public Observable<WorkflowRunAction> call(WorkflowRunActionInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((WorkflowRunAction)wrapModel(inner));
+                }
             }
        });
     }

sdk/logic/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/logic/v2018_07_01_preview/implementation/WorkflowRunOperationsImpl.java

@@ -35,10 +35,14 @@ private RunWorkflowWorkflowRunImpl wrapModel(WorkflowRunInner inner) {
     public Observable<RunWorkflowWorkflowRun> getAsync(String resourceGroupName, String workflowName, String runName, String operationId) {
         WorkflowRunOperationsInner client = this.inner();
         return client.getAsync(resourceGroupName, workflowName, runName, operationId)
-        .map(new Func1<WorkflowRunInner, RunWorkflowWorkflowRun>() {
+        .flatMap(new Func1<WorkflowRunInner, Observable<RunWorkflowWorkflowRun>>() {
             @Override
-            public RunWorkflowWorkflowRun call(WorkflowRunInner inner) {
-                return wrapModel(inner);
+            public Observable<RunWorkflowWorkflowRun> call(WorkflowRunInner inner) {
+                if (inner == null) {
+                    return Observable.empty();
+                } else {
+                    return Observable.just((RunWorkflowWorkflowRun)wrapModel(inner));
+                }
             }
        });
     }