TFNFR11 - Category: Code Style - Null Comparison Toggle #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonegunmanb
approved these changes
May 13, 2024
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
LGTM, thanks @neil-yechenwei !
@matt-FFFFFF Would you please give this rule a review? Thanks!
matt-FFFFFF
reviewed
Jun 20, 2024
Member
matt-FFFFFF
left a comment
matt-FFFFFF
left a comment
There was a problem hiding this comment.
Some comments for discussion
| } | ||
|
|
||
| func (t *NullComparisonToggleRule) Link() string { | ||
| return "https://azure.github.io/Azure-Verified-Modules/specs/terraform/#id-tfnfr11---category-code-style---null-comparison-toggle" |
Member
There was a problem hiding this comment.
There is no mention of the local workaround in the spec here - do we need to update this as well?
| break | ||
| } | ||
|
|
||
| if v, ok := dynamicVal.(hcl.TraverseAttr); ok && strings.HasSuffix(strings.ToLower(v.Name), "_id") { |
Member
There was a problem hiding this comment.
Should we change this condition to all string values - rather than only those traversals that end with _id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- PASS: TestNullComparisonToggle/object_variable_exists,_ok (0.00s)
--- PASS: TestNullComparisonToggle/string_local_exists,_ok (0.00s)
--- PASS: TestNullComparisonToggle/string_variable_and_another_condition_exist,_not_ok (0.00s)
--- PASS: TestNullComparisonToggle/string_variable_exists,_not_ok (0.00s)
--- PASS: TestNullComparisonToggle/string_variable_exists_and_the_expression_starts_with_null,not_ok (0.00s)
--- PASS: TestNullComparisonToggle/string_variable_with
!=_exists,_not_ok (0.00s)