Skip to content

Conversation

@britaniar
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Sets up logger for controller runtime to remove stack trace.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

Refer to kubefleet-dev/kubefleet#42

@kaito-pr-agent
Copy link

kaito-pr-agent bot commented Apr 30, 2025

Title

(Describe updated until commit bb855b2)

Setup Controller Runtime Logger in Main Files


Description

  • Added controller-runtime logger setup in multiple main files

  • Configured logger to use dev mode


Changes walkthrough 📝

Relevant files
Enhancement
main.go
Added logger setup for hub-net-controller-manager               

cmd/hub-net-controller-manager/main.go

  • Imported zap package for logging
  • Set up controller-runtime logger using zap.New(zap.UseDevMode(true))
  • +4/-0     
    main.go
    Added logger setup for mcs-controller-manager                       

    cmd/mcs-controller-manager/main.go

  • Imported zap package for logging
  • Set up controller-runtime logger using zap.New(zap.UseDevMode(true))
  • +5/-0     
    main.go
    Added logger setup for member-net-controller-manager         

    cmd/member-net-controller-manager/main.go

  • Imported zap package for logging
  • Set up controller-runtime logger using zap.New(zap.UseDevMode(true))
  • +4/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @kaito-pr-agent
    Copy link

    kaito-pr-agent bot commented Apr 30, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit bb855b2)

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Logging Mode

    The logger is set to development mode (UseDevMode(true)). Ensure this is appropriate for production environments, as it may log more information than desired.

    ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
    Logging Mode

    The logger is set to development mode (UseDevMode(true)). Ensure this is appropriate for production environments, as it may log more information than desired.

    ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
    Logging Mode

    The logger is set to development mode (UseDevMode(true)). Ensure this is appropriate for production environments, as it may log more information than desired.

    ctrl.SetLogger(zap.New(zap.UseDevMode(true)))

    @kaito-pr-agent
    Copy link

    PR Code Suggestions ✨

    1 similar comment
    @kaito-pr-agent
    Copy link

    PR Code Suggestions ✨

    @codecov
    Copy link

    codecov bot commented Apr 30, 2025

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 80.55%. Comparing base (9a65071) to head (bb855b2).
    Report is 1 commits behind head on main.

    Additional details and impacted files
    @@            Coverage Diff             @@
    ##             main     #296      +/-   ##
    ==========================================
    + Coverage   80.50%   80.55%   +0.04%     
    ==========================================
      Files          29       29              
      Lines        4099     4099              
    ==========================================
    + Hits         3300     3302       +2     
      Misses        634      634              
    + Partials      165      163       -2     

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

    @britaniar britaniar merged commit c7c17c6 into Azure:main Apr 30, 2025
    10 checks passed
    @britaniar britaniar deleted the setupLogger branch April 30, 2025 22:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants