Migrate Azure.Analytics.Purview.DataMap to new code generator #54156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanCrd
requested review from
JoshLove-msft,
jorgerangel-msft and
radhgupta
Copilot finished reviewing on behalf of
JonathanCrd
November 25, 2025 23:30
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Azure.Analytics.Purview.DataMap SDK to a new code generator. The changes regenerate the src/Generated files using the updated generator, update test samples that are no longer auto-generated, and modify custom code to align with the new generator's patterns.
Key changes:
- Configuration updated to use the new TypeSpec HTTP client C# emitter
- Generated client code refactored with improved patterns (protocol methods first, convenience methods wrapper style)
- Sample test files updated to reflect renamed methods and removed API version parameters
- Model serialization updated to use newer patterns with
_additionalBinaryDataProperties
Reviewed changes
Copilot reviewed 4 out of 210 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Added emitter package configuration for new generator |
| Samples_TypeDefinition.cs | Updated samples with method name changes, removed apiVersion parameters, commented out samples for methods no longer generated |
| Samples_Relationship.cs | Renamed GetRelationship to Get, removed auto-generated comment |
| Samples_Lineage.cs | Renamed GetLineage to Get, removed apiVersion parameters |
| Samples_Glossary.cs | Renamed GetGlossary to Get |
| Samples_Entity.cs | Removed apiVersion parameters, updated ImportBusinessMetadata signature |
| Samples_Discovery.cs | Removed apiVersion parameters across all discovery samples |
| TypeDefinition.cs | Major refactoring with protocol methods first, convenience methods as wrappers, improved ordering |
| TypeDefinition.RestClient.cs | New file containing REST request creation logic separated from main client |
| TypeCategory.cs | Updated enum implementation with improved documentation |
| TimeBoundary.cs | Updated serialization field naming from _serializedAdditionalRawData to _additionalBinaryDataProperties |
| TermTemplateDef.cs | Updated model with improved property documentation |
| TermStatus.cs | Updated enum implementation pattern |
| TermSearchResultValue.cs | Updated serialization patterns |
| AzureAnalyticsPurviewDataMapContext.cs | Minor documentation link formatting update |
sdk/purview/Azure.Analytics.Purview.DataMap/api/Azure.Analytics.Purview.DataMap.net8.0.cs
Show resolved
Hide resolved
sdk/purview/Azure.Analytics.Purview.DataMap/api/Azure.Analytics.Purview.DataMap.net8.0.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates sdk/purview/Azure.Analytics.Purview.DataMap to the new code generator.
Fixes #54120