-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[HDInsight]Support new api version 2023-04-15-preview #36878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArthurMa1978
merged 32 commits into
Azure:main
from
yuc-Li:HDinsight_new_api_version_20230415
Jun 28, 2023
Merged
[HDInsight]Support new api version 2023-04-15-preview #36878
ArthurMa1978
merged 32 commits into
Azure:main
from
yuc-Li:HDinsight_new_api_version_20230415
Jun 28, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @yuc-Li! We will review the pull request and get back to you soon. |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…test runs correctly.
modify default location for cluster creation due to insufficient quotas in the eastus.
…om/yuc-Li/azure-sdk-for-net into HDinsight_new_api_version_20230415
…om/yuc-Li/azure-sdk-for-net into HDinsight_new_api_version_20230415
ArthurMa1978
approved these changes
Jun 21, 2023
ArthurMa1978
requested changes
Jun 27, 2023
Member
ArthurMa1978
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the ci errors
…o HDinsight_new_api_version_20230415
…o HDinsight_new_api_version_20230415
…om/yuc-Li/azure-sdk-for-net into HDinsight_new_api_version_20230415
…om/yuc-Li/azure-sdk-for-net into HDinsight_new_api_version_20230415
…o HDinsight_new_api_version_20230415
ArthurMa1978
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
Swagger PR link Azure/azure-rest-api-specs#24270
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run
following command:
dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModulesOld outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.