Redis track 1 .NET SDK 2022-06-01 API version updates #31799
Conversation
This reverts commit 83c1e40.
austintolani
requested review from
ArcturusZhang,
ArthurMa1978,
Yao725,
archerzz,
fengzhou-msft,
m-nash and
markcowl
as code owners
Yao725
left a comment
Yao725
left a comment
There was a problem hiding this comment.
Hi @austintolani, as we announced the deprecation for Track 1 .NET SDK, we can't release Track 1 SDK anymore. If you still need this release, you need to provide the business impact or other strong justification of this release for @ArthurMa1978.
Hello @Yao725. These changes are not for public release, they are for creating a private signed package to be used for our Azure PowerShell module. I spoke to @ArthurMa1978 about this and he said that I should merge my changes into this public repo and then run the |
Yao725
left a comment
Yao725
left a comment
There was a problem hiding this comment.
Thanks for the clarification @austintolani, approved with comment.
sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj
Outdated
Show resolved
Hide resolved
….Management.Redis.csproj Co-authored-by: Yao Kou <yaokou@microsoft.com>
|
@Yao725 thanks for the review. Could you merge the PR as well? Merging is blocked for me. |
|
@austintolani, merged. By the way, I believe if you want to release track 1 SDK, you should follow this guide and go to run the net - mgmt pipeline. Considering it is not a public release, please do not select |
|
Will do. Thanks for your help @Yao725 |
* generate Redis SDK * Update ManagedIdentityTests.cs * Update BeginCreateFunctionalTests.cs * use 'latest' as redisVersion * begin update tests * Update PatchSchedulesFunctionalTests.cs * add new properties to CreateOrUpdateTests * Update GeoReplicationFunctionalTests.cs with async + sync method testing * Rename BeginCreateFunctionalTests -> BeginCreateBeginUpdateFunctionalTests * Prevent key sanitization * disable failing geo-replication tests * session recordings * Revert "Prevent key sanitization" This reverts commit 83c1e40. * sanitized keys in RegenerateKeyTest.json * sdk release info * santize keys * regenerate session records * edit key santization in RegenerateKeyTest.json * Update sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj Co-authored-by: Yao Kou <yaokou@microsoft.com> Co-authored-by: Austin Tolani <austintolani@microsoft.com> Co-authored-by: Yao Kou <yaokou@microsoft.com>
3 participants
Summary
These changes contain the newly generated code for the
Microsoft.Azure.Management.Redispackage based on the new2022-06-01API version. This generation actually includes new code for changes made in both the2022-06-01and2022-05-01API versions:Testing
I have added unit tests and functional tests (with updated recorded session results) to test the newly generated code.