SDK tests for Restore Points using updated C# SDK #22292
Conversation
roipmsft
requested review from
YalinLi0312,
allenjzhang,
m-nash,
markcowl and
nisha-bhatia
as code owners
ghost
added
the
|
Please include eng\mgmt\mgmtmetadata\compute_resource-manager.txt so code verification can match the correct commit id. |
|
@roipmsft , as per Allen's comment, please make updates to the files needed for the release notes and version. |
roipmsft
changed the title
| /// customer wishes to exclude from the restore point. If no disks are | ||
| /// specified, all disks will be included.</param> | ||
| public RestorePoint(string id = default(string), string name = default(string), string type = default(string), RestorePointSourceMetadata sourceMetadata = default(RestorePointSourceMetadata), string provisioningState = default(string), string consistencyMode = default(string), RestorePointProvisioningDetails provisioningDetails = default(RestorePointProvisioningDetails), IList<ApiEntityReference> excludeDisks = default(IList<ApiEntityReference>)) | ||
| public RestorePoint(string id = default(string), string name = default(string), string type = default(string), IList<ApiEntityReference> excludeDisks = default(IList<ApiEntityReference>), RestorePointSourceMetadata sourceMetadata = default(RestorePointSourceMetadata), string provisioningState = default(string), string consistencyMode = default(string), RestorePointProvisioningDetails provisioningDetails = default(RestorePointProvisioningDetails)) |
There was a problem hiding this comment.
Why change the parameter orders here? It's a breaking change.
There was a problem hiding this comment.
- this was generated automatically by the AutoRest. i did not intentionally change this
- This PR (and the Swagger PR on which this PR is based) does have breaking changes. However, Jeffrey Richter and BreakingChanges Review Board team approved it (because no customers are currently using the api. this feature is still in private preview)
Swagger PR that was merged, with approval by breaking change review board: Move RestorePoint properties into new properties bag for restore point azure-rest-api-specs#14638
|
@roipmsft I see you checked the second box in the checklist, but I don't see the swagger link. Could you provide it? |
sorry here it is. i will add it to PR description too. |
4 participants
All SDK Contribution checklist:
Swagger PR Azure/azure-rest-api-specs#14638
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.