Skip to content

Commit 2cddf77

Browse files
authored
Fix for Share DeleteIfExists/Exists Error Live tests (#33284)
* Fix for share exists live tests * Create Share before attempt to delete with share only SAS * Create Share for the exists error tests too
1 parent 9e8679c commit 2cddf77

File tree

6 files changed

+233
-100
lines changed

6 files changed

+233
-100
lines changed

sdk/storage/Azure.Storage.Files.Shares/tests/FileTestBase.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,10 @@ public SasQueryParameters GetNewAccountSasCredentials(StorageSharedKeyCredential
115115
return builder.ToSasQueryParameters(sharedKeyCredentials ?? Tenants.GetNewSharedKeyCredentials());
116116
}
117117

118-
public SasQueryParameters GetNewFileServiceSasCredentialsShare(string shareName, StorageSharedKeyCredential sharedKeyCredentials = default)
118+
public SasQueryParameters GetNewFileServiceSasCredentialsShare(
119+
string shareName,
120+
StorageSharedKeyCredential sharedKeyCredentials = default,
121+
ShareSasPermissions permissions = ShareSasPermissions.All)
119122
{
120123
var builder = new ShareSasBuilder
121124
{
@@ -125,7 +128,7 @@ public SasQueryParameters GetNewFileServiceSasCredentialsShare(string shareName,
125128
ExpiresOn = Recording.UtcNow.AddHours(+1),
126129
IPRange = new SasIPRange(IPAddress.None, IPAddress.None)
127130
};
128-
builder.SetPermissions(ShareSasPermissions.All);
131+
builder.SetPermissions(permissions);
129132
return builder.ToSasQueryParameters(sharedKeyCredentials ?? Tenants.GetNewSharedKeyCredentials());
130133
}
131134

sdk/storage/Azure.Storage.Files.Shares/tests/SessionRecords/ShareClientTests/DeleteIfExistsAsync_Error.json

Lines changed: 52 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/storage/Azure.Storage.Files.Shares/tests/SessionRecords/ShareClientTests/DeleteIfExistsAsync_ErrorAsync.json

Lines changed: 52 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/storage/Azure.Storage.Files.Shares/tests/SessionRecords/ShareClientTests/ExistsAsync_Error.json

Lines changed: 52 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)