revert AzureSasCredentialSynchronousPolicy changes (#33365)

Author: christothes

sdk/core/Azure.Core/api/Azure.Core.net461.cs

@@ -40,11 +40,7 @@ public partial class AzureSasCredential
     {
         public AzureSasCredential(string signature) { }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public string PreviousSignature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
         public string Signature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public long SignatureUpdated { get { throw null; } }
         public void Update(string signature) { }
     }
     [System.FlagsAttribute]

sdk/core/Azure.Core/api/Azure.Core.net5.0.cs

@@ -40,11 +40,7 @@ public partial class AzureSasCredential
     {
         public AzureSasCredential(string signature) { }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public string PreviousSignature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
         public string Signature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public long SignatureUpdated { get { throw null; } }
         public void Update(string signature) { }
     }
     [System.FlagsAttribute]

sdk/core/Azure.Core/api/Azure.Core.net6.0.cs

@@ -40,11 +40,7 @@ public partial class AzureSasCredential
     {
         public AzureSasCredential(string signature) { }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public string PreviousSignature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
         public string Signature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public long SignatureUpdated { get { throw null; } }
         public void Update(string signature) { }
     }
     [System.FlagsAttribute]

sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs

@@ -40,11 +40,7 @@ public partial class AzureSasCredential
     {
         public AzureSasCredential(string signature) { }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public string PreviousSignature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
         public string Signature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public long SignatureUpdated { get { throw null; } }
         public void Update(string signature) { }
     }
     [System.FlagsAttribute]

sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs

@@ -40,11 +40,7 @@ public partial class AzureSasCredential
     {
         public AzureSasCredential(string signature) { }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public string PreviousSignature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
         public string Signature { get { throw null; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public long SignatureUpdated { get { throw null; } }
         public void Update(string signature) { }
     }
     [System.FlagsAttribute]

sdk/core/Azure.Core/src/AzureSasCredential.cs

@@ -17,8 +17,6 @@ namespace Azure
     public class AzureSasCredential
     {
         private string _signature;
-        private string _previousSignature;
-        private long _signatureUpdated;
 
         /// <summary>
         /// Shared access signature used to authenticate to an Azure service.
@@ -30,27 +28,6 @@ public string Signature
             private set => Volatile.Write(ref _signature, value);
         }
 
-        /// <summary>
-        /// The ticks value of the DateTimeOffset when the shared access signature was last set.
-        /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        public long SignatureUpdated
-        {
-            get => Volatile.Read(ref _signatureUpdated);
-            private set => Volatile.Write(ref _signatureUpdated, value);
-        }
-
-        /// <summary>
-        /// The previous value af <see cref="Signature"/> after <see cref="Update"/> is called.
-        /// </summary>
-        /// <returns></returns>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        public string PreviousSignature
-        {
-            get => Volatile.Read(ref _previousSignature);
-            private set => Volatile.Write(ref _previousSignature, value);
-        }
-
         /// <summary>
         /// Initializes a new instance of the <see cref="AzureSasCredential"/> class.
         /// </summary>
@@ -65,9 +42,7 @@ public string PreviousSignature
         public AzureSasCredential(string signature)
         {
             Argument.AssertNotNullOrWhiteSpace(signature, nameof(signature));
-            SignatureUpdated = DateTimeOffset.UtcNow.Ticks;
             Signature = signature;
-            PreviousSignature = signature;
         }
 #pragma warning restore CS8618 // Non-nullable field is uninitialized. Consider declaring as nullable.
 
@@ -86,9 +61,6 @@ public AzureSasCredential(string signature)
         public void Update(string signature)
         {
             Argument.AssertNotNullOrWhiteSpace(signature, nameof(signature));
-            SignatureUpdated = DateTimeOffset.UtcNow.Ticks;
-            PreviousSignature = Signature.StartsWith("?", StringComparison.InvariantCulture) ?
-                Signature.Substring(1) : Signature;
             Signature = signature;
         }
     }

sdk/core/Azure.Core/src/Shared/AzureSasCredentialSynchronousPolicy.cs

@@ -31,21 +31,7 @@ public override void OnSendingRequest(HttpMessage message)
             }
             if (!query.Contains(signature))
             {
-                bool setSignature = false;
-                // check if the signature has updated since we started processing this message
-                if (message.ProcessingContext.StartTime.Ticks < _credential.SignatureUpdated)
-                {
-                    string previousSig = _credential.PreviousSignature;
-                    if (query.Contains(previousSig))
-                    {
-                        query = query.Replace(previousSig, signature);
-                        setSignature = true;
-                    }
-                }
-                if (!setSignature)
-                {
-                    query = string.IsNullOrEmpty(query) ? '?' + signature : query + '&' + signature;
-                }
+                query = string.IsNullOrEmpty(query) ? '?' + signature : query + '&' + signature;
                 message.Request.Uri.Query = query;
             }
 

sdk/core/Azure.Core/tests/AzureSasCredentialSynchronousPolicyTests.cs

@@ -95,6 +95,7 @@ public async Task IgnoreDuplicateSas(string signatureValue)
         }
 
         [Test]
+        [Ignore("Re-enable when AzureSasCredential change merges")]
         public async Task VerifyRetryAfterSasCredentialUpdateOperation()
         {
             // Arrange