Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/* eslint-disable */
// TODO: Enable eslint, fix errors

Expand Down Expand Up @@ -253,7 +253,7 @@
folder: string,
): SkipResult {
const isRLCClient =
config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] !== true;
config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] === false;
const shouldSkip = isManagementSdk(folder) || isRLCClient;
const result: SkipResult = {
shouldSkip: shouldSkip,
Expand All @@ -265,7 +265,7 @@

function skipForModularOrManagementPlaneInTsEmitter(config: any, folder: string): SkipResult {
const isModularClient =
config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] === true;
config?.options?.["@azure-tools/typespec-ts"]?.["is-modular-library"] !== false;
const shouldSkip = isManagementSdk(folder) || isModularClient;
const result: SkipResult = {
shouldSkip: shouldSkip,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { afterEach, beforeEach, describe, it, MockInstance, vi } from "vitest";

import { contosoTspConfig } from "@azure-tools/specs-shared/test/examples";
Expand Down Expand Up @@ -247,6 +247,8 @@
"{output-dir}/{service-dir}/arm-aaa-rest",
"{output-dir}/{service-dir}/aaa--rest",
[new TspConfigTsDpEmitterOutputDirSubRule()],
false,
{ "is-modular-library": false },
);

const tsDpPackageNameTestCases = createEmitterOptionTestCases(
Expand All @@ -256,6 +258,8 @@
"@azure-rest/aaa-bbb",
"@azure/aaa-bbb",
[new TspConfigTsRlcDpPackageNameMatchPatternSubRule()],
false,
{ "is-modular-library": false },
);

const tsDpModularPackageNameTestCases = createEmitterOptionTestCases(
Expand Down
1 change: 0 additions & 1 deletion specification/ai/Azure.AI.Agents/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ options:
api-version: "v1"
generate-test: true
generate-metadata: false
is-modular-library: true
package-details:
name: "@azure/ai-agents"
flavor: azure
Expand Down
1 change: 0 additions & 1 deletion specification/ai/Azure.AI.Projects/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ options:
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/ai-projects"
api-version: "v1"
is-modular-library: true
generate-test: true
generate-metadata: false
package-details:
Expand Down
1 change: 0 additions & 1 deletion specification/ai/ContentUnderstanding/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/ai-content-understanding-rest"
is-modular-library: true
package-details:
name: "@azure-rest/ai-content-understanding"
description: "Azure Content Understanding Rest Client"
Expand Down
1 change: 0 additions & 1 deletion specification/ai/OpenAI.Assistants/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ options:
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/openai"
generate-metadata: false
is-modular-library: true
package-details:
name: "@azure/openai-assistants"
flavor: azure
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ options:
flavor: "azure"
generate-metadata: true
experimental-extensible-enums: true
is-modular-library: true
package-details:
name: "@azure/attestation"
description: "Azure Attestation"
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ options:
emitter-output-dir: "{output-dir}/{service-dir}/arm-billingbenefits"
typespec-title-map:
BillingBenefitsClient: BillingBenefitsRP
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/cdn
emitter-output-dir: "{output-dir}/{service-dir}/arm-cdn"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/edgeactions
emitter-output-dir: "{output-dir}/{service-dir}/arm-edgeactions"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ options:
output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/cloudhealth.json"
emit-common-types-schema: "never"
"@azure-tools/typespec-ts":
is-modular-library: true
experimental-extensible-enums: true
emitter-output-dir: "{output-dir}/{service-dir}/arm-cloudhealth"
flavor: "azure"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ options:
emitter-output-dir: "{output-dir}/{service-dir}/openai"
generate-metadata: false
generate-test: false
is-modular-library: true
package-details:
name: "@azure/openai"
flavor: azure
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/confidentialledger
package-dir: "arm-confidentialledger"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@ options:
"name": "@azure-rest/azure-confidentialledger"
description: "Microsoft Confidential Ledger"
"flavor": "azure"
is-modular-library: false
generate-metadata: true
generate-sample-project: false
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@ options:
"name": "@azure-rest/azure-confidentialledger-certificate"
description: "Microsoft Confidential Ledger Certificate"
"flavor": "azure"
is-modular-library: false
generate-metadata: true
generate-sample-project: false
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ options:
model-namespace: false
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/contoso-widgetmanager"
is-modular-library: true
Copy link
Member

@MaryGao MaryGao Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maririos and @mikeharder Could you help review and approve this pr?

JS has adjusted the default rule for option is-modular-library and this setting won't be necessary in our contoso project.

Copy link
Member

@mikeharder mikeharder Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the setting also be removed from our widget sample?

Also, I see a lot more hits for is-modular-library, both true and false, in existing specs in main. Why does this PR only change these 3?

Copy link
Member

@MaryGao MaryGao Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know we have other samples, @v-jiaodi Could you update config to remove all is-modular-library: true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

package-details:
name: "@azure/contoso-widgetmanager"
flavor: azure
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/dashboard
emitter-output-dir: "{output-dir}/{service-dir}/arm-dashboard"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-databoxedge"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
1 change: 0 additions & 1 deletion specification/datadog/Datadog.Management/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/datadog
emitter-output-dir: "{output-dir}/{service-dir}/arm-datadog"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ options:
collection: ProjectCatalogs
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-devcenter"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ options:
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-dynatrace"
package-dir: "arm-dynatrace"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-edgeorder"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ options:
package-details:
name: "@azure/eventgrid-systemevents"
flavor: azure
is-modular-library: true
"@azure-tools/typespec-go":
module: "github.com/Azure/azure-sdk-for-go/{service-dir}/azsystemevents"
service-dir: "sdk/messaging/eventgrid"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ options:
name: "@azure/eventgrid-namespaces"
flavor: azure
experimental-extensible-enums: true
is-modular-library: true
"@azure-tools/typespec-go":
module: "github.com/Azure/azure-sdk-for-go/{service-dir}/aznamespaces"
service-dir: "sdk/messaging/eventgrid"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-eventhub"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-fileshares"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/guestconfiguration
emitter-output-dir: "{output-dir}/{service-dir}/arm-guestconfiguration"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/healthbot
emitter-output-dir: "{output-dir}/{service-dir}/arm-healthbot"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ options:
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-selfhelp"
"service-dir": "sdk/selfhelp"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
typespec-title-map:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-hybridkubernetes"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ options:
generate-metadata: true
src-folder: "src/generated"
experimental-extensible-enums: true
is-modular-library: true
package-details:
name: "@azure/keyvault-admin"
description: "Azure Key Vault Administration"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ options:
generate-metadata: true
src-folder: "src/generated"
experimental-extensible-enums: true
is-modular-library: true
package-details:
name: "@azure/keyvault-certificates"
description: "Azure Key Vault Certificates"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ options:
generate-metadata: true
src-folder: "src/generated"
experimental-extensible-enums: true
is-modular-library: true
package-details:
name: "@azure/keyvault-keys"
description: "Azure Key Vault Keys"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ options:
generate-metadata: true
src-folder: "src/generated"
experimental-extensible-enums: true
is-modular-library: true
package-details:
name: "@azure/keyvault-secrets"
description: "Azure Key Vault Secrets"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ options:
generate-sample: true
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/ai-chat-protocol"
is-modular-library: true
package-details:
name: "@azure/ai-chat-protocol"
flavor: azure
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-maintenance"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ options:
inject-spans: true
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-managednetworkfabric"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-reviews"
is-modular-library: true
flavor: "azure"
experimentalExtensibleEnums: true
experimental-extensible-enums: true
Expand Down
1 change: 0 additions & 1 deletion specification/monitor/Monitor.Ingestion/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ options:
emitter-output-dir: "{output-dir}/{service-dir}/{namespace}"
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/monitor-ingestion"
is-modular-library: true
package-details:
name: "@azure/monitor-ingestion"
description: "Azure Monitor Ingestion library"
Expand Down
1 change: 0 additions & 1 deletion specification/monitor/Monitor.Query.Logs/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ options:
model-namespace: true
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/monitor-query-logs"
is-modular-library: true
package-details:
name: "@azure/monitor-query-logs"
description: "Azure Monitor Query Logs library"
Expand Down
1 change: 0 additions & 1 deletion specification/monitor/Monitor.Query.Metrics/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ options:
model-namespace: true
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/monitor-query-metrics"
is-modular-library: true
package-details:
name: "@azure/monitor-query-metrics"
description: "Azure Monitor Query Metrics library"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: "sdk/newrelicobservability"
emitter-output-dir: "{output-dir}/{service-dir}/arm-newrelicobservability"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
typespec-title-map:
Expand Down
1 change: 0 additions & 1 deletion specification/nginx/Nginx.Management/tspconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ options:
"@azure-tools/typespec-ts":
service-dir: sdk/nginx
emitter-output-dir: "{output-dir}/{service-dir}/arm-nginx"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-notificationhubs"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-planetarycomputer"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-relationships"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ options:
flavor: azure
"@azure-tools/typespec-ts":
emitter-output-dir: "{output-dir}/{service-dir}/arm-resourceconnector"
is-modular-library: true
flavor: "azure"
experimental-extensible-enums: true
package-details:
Expand Down
Loading
Loading