Skip to content

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2023-02-01 #23428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 6 commits into from
Apr 11, 2023
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2023-02-01 #23428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
338f38a
Update description for managed HSM properties in resource manager for…
neeerajaakula Apr 3, 2023
be562b2
Fix model validation failures for LRO_Response_Header rule in managed…
neeerajaakula Apr 4, 2023
95533ed
Fix model validation failures for LRO_Response_Header rule in managed…
neeerajaakula Apr 4, 2023
92214f3
Revert change of location header to delete in managed HSM resource ma…
neeerajaakula Apr 4, 2023
d65aa96
Fix S360 issue with additional property being returned for managed HS…
neeerajaakula Apr 5, 2023
abe4d3c
Fix S360 alert for enum mismatch in Managed HSM resource manager for …
neeerajaakula Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...rce-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/ManagedHsm_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
Copy link
Contributor

@riteshchitlangia1 riteshchitlangia1 Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please confirm from code to see if RP returns this header in 2020-04-01-preview version? Just to make sure service code and swagger are in sync.

Copy link
Contributor Author

@neeerajaakula neeerajaakula Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting this change as RP does not return the location header for this version.

}
},
"204": {}
}
}
8 changes: 7 additions & 1 deletion ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,13 @@
"description": "Request successful. Resource does not exist."
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
}
},
"200": {
"description": "Delete successful."
Expand Down