Skip to content

fix keyvault enum #23368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msyyc wants to merge 2 commits into from
Closed

fix keyvault enum #23368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2be313
fix
msyyc Mar 30, 2023
7052888
update
msyyc Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2016-10-01/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,17 @@
"enum": [
"resourceType eq 'Microsoft.KeyVault/vaults'"
],
"x-ms-enum": {
"name": "VaultListFilterTypes",
"modelAsString": false,
"values": [
{
"value": "resourceType eq 'Microsoft.KeyVault/vaults'",
"description": "Keyvault resource type",
"name": "ResourceTypeKeyVault"
}
]
},
Copy link
Member

@heaths heaths Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also use the "values" property to give this a better friendly name for code generation. Same as the ResourceManagerApiVersions enum below. For date-based versions we prefer "V2025_11_01". For this expression...I'm not sure. Feel free to come up with something.

Copy link
Member Author

@msyyc msyyc Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

"description": "The filter to apply on the operation."
},
{
Expand All @@ -591,6 +602,17 @@
"enum": [
"2015-11-01"
],
"x-ms-enum": {
"name": "ResourceManagerApiVersions",
"modelAsString": false,
"values": [
{
"value": "2015-11-01",
"description": "Api version",
"name": "V2015_11_01"
}
]
},
"description": "Azure Resource Manager Api Version."
},
{
Expand Down