Skip to content

Update operation ids for Microsoft.DBforPostgreSQL for version stable/2022-11-08 #23100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 1 commit into from
Mar 17, 2023
Merged

Update operation ids for Microsoft.DBforPostgreSQL for version stable/2022-11-08 #23100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...gresqlhsc/resource-manager/Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"tags": [
"Clusters"
],
"operationId": "Clusters_CreateOrUpdate",
"operationId": "Clusters_Create",
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "azure-async-operation"
Expand Down Expand Up @@ -641,7 +641,7 @@
"tags": [
"Configurations"
],
"operationId": "Configurations_CreateOrUpdateCoordinator",
"operationId": "Configurations_UpdateOnCoordinator",
Copy link
Member

@mikekistler mikekistler Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest removing "on":

Suggested change
"operationId": "Configurations_UpdateOnCoordinator",
"operationId": "Configurations_UpdateCoordinator",

"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "azure-async-operation"
Expand Down Expand Up @@ -756,7 +756,7 @@
"tags": [
"Configurations"
],
"operationId": "Configurations_CreateOrUpdateNode",
"operationId": "Configurations_UpdateOnNode",
Copy link
Member

@mikekistler mikekistler Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest removing "on"

Suggested change
"operationId": "Configurations_UpdateOnNode",
"operationId": "Configurations_UpdateNode",

Copy link
Member Author

@senatol senatol Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, our PM team requested this change since the previous version, "Configurations - Update Node" could cause misunderstanding, it doesn't really update the node, only updates configuration on the node or coordinator.

"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "azure-async-operation"
Expand Down
5 changes: 5 additions & 0 deletions specification/postgresqlhsc/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ directive:
- suppress: EnumInsteadOfBoolean
from: postgresqlhsc.json
reason: It's been used as boolean since 2019 by internal teams and also private preview customers like Azure Portal and we have no plans to use any values other than true/false.
- suppress: PutInOperationName
where:
- $..paths[($..operationId["Configurations_Update*"])]
from: postgresqlhsc.json
reason: Configurations have preset default values and customers can only update them, they can't create. So we don't need "Create" in operation id.
```

---
Expand Down