[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-01-01-preview #22777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jikuma Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| containerregistry.json | 2023-01-01-preview(d084756) | 2023-01-01-preview(main) |
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L18:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L66:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L297:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L348:5 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2023-01-preview | package-2023-01-preview(d084756) | package-2023-01-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/containerregistry/resource-manager/readme.md tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-01-preview |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 109 Errors, 0 Warnings failed [Detail]
Tag package-2023-01-preview; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 104, untested: 0, failed: 59, passed: 45
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
statusCode: 404, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: Registries_GetPrivateLinkResource |
|
Invalid Content-Type (application/octet-stream). These are supported: application/json Source: response OperationId: Registries_GetPrivateLinkResource |
|
Body is required in response but not provided Source: response OperationId: Registries_GetPrivateLinkResource |
|
statusCode: 400, errorCode: InvalidExpiry, errorMessage: Expiry Date '12/31/2020 3:59:59 PM +00:00' is invalid. The expiration date should be in the future. For more information on repository permissions, please visit https://aka.ms/acr/repo-permissions. Source: runtime OperationId: Registries_GenerateCredentials |
|
Additional properties not allowed: status Source: response OperationId: Registries_GenerateCredentials |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.ContainerRegistry/registries/read' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-WUVCHV-22777/providers/Microsoft.ContainerRegistry/registries/registrysonb1t', however the linked subscription '10000000-0000-0000-0000-000000000000' was not found. Source: runtime OperationId: Registries_ImportImage |
|
The swagger file does not define '403' response code Source: response OperationId: Registries_ImportImage |
|
statusCode: 503, errorCode: ServiceUnavailable, errorMessage: Unable to perform put/subscriptions/resourceGroups/registries/packages/. Please try after some time. Source: runtime OperationId: Archives_Create |
|
String does not match pattern ^[a-zA-Z]*$: packagetfo48l5 Source: request OperationId: Archives_Create |
|
Additional properties not allowed: status Source: response OperationId: Archives_Create |
|
statusCode: 503, errorCode: ServiceUnavailable, errorMessage: Unable to perform get/subscriptions/resourceGroups/registries/packages/. Please try after some time. Source: runtime OperationId: Archives_List |
|
String does not match pattern ^[a-zA-Z]*$: packagetfo48l5 Source: request OperationId: Archives_List |
|
Additional properties not allowed: status Source: response OperationId: Archives_List |
|
statusCode: 503, errorCode: ServiceUnavailable, errorMessage: Unable to perform get/subscriptions/resourceGroups/registries/packages/. Please try after some time. Source: runtime OperationId: Archives_Get |
|
String does not match pattern ^[a-zA-Z]*$: packagetfo48l5 Source: request OperationId: Archives_Get |
|
Additional properties not allowed: status Source: response OperationId: Archives_Get |
|
statusCode: 503, errorCode: ServiceUnavailable, errorMessage: Unable to perform patch/subscriptions/resourceGroups/registries/packages/. Please try after some time. Source: runtime OperationId: Archives_Update |
|
String does not match pattern ^[a-zA-Z]*$: packagetfo48l5 Source: request OperationId: Archives_Update |
|
Additional properties not allowed: status Source: response OperationId: Archives_Update |
|
statusCode: 400, errorCode: InvalidScopeString, errorMessage: Scope value myRepository is invalid. The acceptable patterns are 'repository', 'repository:tag', 'repository:', 'repository/', 'repository/*:tag' or an empty string. The respository and tag names follow the standardized docker repository and tag naming conventions. For more information, please visit https://docs.microsoft.com/en-us/rest/api/containerregistry/webhooks/create#webhook Source: runtime OperationId: Webhooks_Create |
|
The swagger file does not define '400' response code Source: response OperationId: Webhooks_Create |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerRegistry/registries/registrysonb1t/webhooks/webhookn48kcb4' under resource group 'apiTest-WUVCHV-22777' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Webhooks_Get |
|
The swagger file does not define '404' response code Source: response OperationId: Webhooks_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerRegistry/registries/registrysonb1t/webhooks/webhookn48kcb4' under resource group 'apiTest-WUVCHV-22777' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Webhooks_Update |
|
The swagger file does not define '404' response code Source: response OperationId: Webhooks_Update |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'registrysonb1t/webhookn48kcb4' not found. Source: runtime OperationId: Webhooks_Ping |
|
The swagger file does not define '404' response code Source: response OperationId: Webhooks_Ping |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'registrysonb1t/webhookn48kcb4' not found. Source: runtime OperationId: Webhooks_GetCallbackConfig |
|
The swagger file does not define '404' response code Source: response OperationId: Webhooks_GetCallbackConfig |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'registrysonb1t/webhookn48kcb4' not found. Source: runtime OperationId: Webhooks_ListEvents |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌PrettierCheck: 8 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json |
|
Code style issues found path: preview/2023-01-01-preview/examples/ArchiveCreate.json |
|
Code style issues found path: preview/2023-01-01-preview/examples/ArchiveGet.json |
|
Code style issues found path: preview/2023-01-01-preview/examples/ArchiveList.json |
|
Code style issues found path: preview/2023-01-01-preview/examples/ArchiveUpdate.json |
|
Code style issues found path: preview/2023-01-01-preview/examples/ArchiveVersionCreate.json |
|
Code style issues found path: preview/2023-01-01-preview/examples/ArchiveVersionGet.json |
|
Code style issues found path: preview/2023-01-01-preview/examples/ArchiveVersionList.json |
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
This was referenced Feb 23, 2023
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
This was referenced Feb 23, 2023
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
This was referenced Feb 23, 2023
AzureRestAPISpecReview
added
the
ReadyForApiTest
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Contributor
|
@jikuma can you fix the BreakingChange and PrettierCheck error? |
See this response, you should try to fix the lint error |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Contributor
Author
|
Since the change is marked as breaking changes, I had to create a new api version. OpenApi created a new PR for new api version. |
11 tasks
Contributor
|
Hi, @jikuma. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.