Skip to content

Conversation

@Dylan-MSFT
Copy link
Contributor

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify - Removing field from example which is not an accepted field
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. Feature is already public. This is just fixing an example
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. Already done
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Dylan-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 21, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
    Url: Microsoft.Sql/stable/2014-04-01/serverAzureADAdministrators.json#L18:17
    ExampleUrl: stable/2014-04-01/examples/ServerAdminCreateUpdate.json#L8:19
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.Sql/stable/2014-04-01/serverAzureADAdministrators.json#L57:22
    ExampleUrl: stable/2014-04-01/examples/ServerAdminCreateUpdate.json#L18:16
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.Sql/stable/2014-04-01/serverAzureADAdministrators.json#L57:22
    ExampleUrl: stable/2014-04-01/examples/ServerAdminCreateUpdate.json#L18:16
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.Sql/stable/2014-04-01/serverAzureADAdministrators.json#L107:22
    ExampleUrl: stable/2014-04-01/examples/ServerAdminDelete.json#L9:16
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.Sql/stable/2014-04-01/serverAzureADAdministrators.json#L107:22
    ExampleUrl: stable/2014-04-01/examples/ServerAdminDelete.json#L9:16
    INVALID_TYPE Expected type object but found type string
    Url: Microsoft.Sql/stable/2014-04-01/serverAzureADAdministrators.json#L107:22
    ExampleUrl: stable/2014-04-01/examples/ServerAdminDelete.json#L9:16
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 21, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/sql/armsql - 2.0.0-beta.1
    +	Field `Family` of struct `VirtualClusterProperties` has been removed
    +	Field `MaintenanceConfigurationID` of struct `VirtualClusterProperties` has been removed
    +	Function `*ServerDevOpsAuditSettingsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ServerDevOpsAuditingSettings, *ServerDevOpsAuditSettingsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, DevOpsAuditingSettingsName, ServerDevOpsAuditingSettings, *ServerDevOpsAuditSettingsClientBeginCreateOrUpdateOptions)`
    +	Function `*ServerDevOpsAuditSettingsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *ServerDevOpsAuditSettingsClientGetOptions)` to `(context.Context, string, string, DevOpsAuditingSettingsName, *ServerDevOpsAuditSettingsClientGetOptions)`
    +	Operation `*ReplicationLinksClient.Delete` has been changed to LRO, use `*ReplicationLinksClient.BeginDelete` instead.
    +	Operation `*TransparentDataEncryptionsClient.CreateOrUpdate` has been changed to LRO, use `*TransparentDataEncryptionsClient.BeginCreateOrUpdate` instead.
    +	Operation `*VirtualClustersClient.UpdateDNSServers` has been changed to LRO, use `*VirtualClustersClient.BeginUpdateDNSServers` instead.
    +	Struct `DNSRefreshConfigurationProperties` has been removed
    +	Struct `UpdateManagedInstanceDNSServersOperation` has been removed
    +	Type alias `DNSRefreshConfigurationPropertiesStatus` has been removed
    +	Type of `ManagedDatabaseRestoreDetailsProperties.NumberOfFilesDetected` has been changed from `*int64` to `*int32`
    +	Type of `ManagedDatabaseRestoreDetailsProperties.PercentCompleted` has been changed from `*float64` to `*int32`
    +	Type of `ManagedDatabaseRestoreDetailsProperties.UnrestorableFiles` has been changed from `[]*string` to `[]*ManagedDatabaseRestoreDetailsUnrestorableFileProperties`
    +	Type of `ServerPrivateEndpointConnection.Properties` has been changed from `*PrivateEndpointConnectionProperties` to `*PrivateEndpointConnectionPropertiesAutoGenerated`
    +	Type of `ServerProperties.PublicNetworkAccess` has been changed from `*ServerNetworkAccessFlag` to `*ServerPublicNetworkAccessFlag`
    azure-sdk-for-js - @azure/arm-sql - 10.0.0-beta.1
    +	Class SqlManagementClient no longer has parameter operationsHealthOperations
    +	Interface Database no longer has parameter primaryDelegatedIdentityClientId
    +	Interface DatabaseIdentity no longer has parameter delegatedResources
    +	Interface DatabaseUpdate no longer has parameter primaryDelegatedIdentityClientId
    +	Interface VirtualCluster no longer has parameter family
    +	Interface VirtualCluster no longer has parameter maintenanceConfigurationId
    +	Interface VirtualClusterUpdate no longer has parameter family
    +	Interface VirtualClusterUpdate no longer has parameter maintenanceConfigurationId
    +	Operation ServerDevOpsAuditSettings.beginCreateOrUpdate has a new signature
    +	Operation ServerDevOpsAuditSettings.beginCreateOrUpdateAndWait has a new signature
    +	Operation ServerDevOpsAuditSettings.get has a new signature
    +	Operation SyncGroups.listLogs has a new signature
    +	Removed Enum KnownDnsRefreshConfigurationPropertiesStatus
    +	Removed Enum KnownEnum60
    +	Removed operation ReplicationLinks.beginUnlink
    +	Removed operation ReplicationLinks.beginUnlinkAndWait
    +	Removed operation ReplicationLinks.delete
    +	Removed operation TransparentDataEncryptions.createOrUpdate
    +	Removed operation VirtualClusters.updateDnsServers
    +	Removed operation group OperationsHealthOperations
    +	Type of parameter publicNetworkAccess of interface Server is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
    +	Type of parameter publicNetworkAccess of interface ServerUpdate is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
    +	Type of parameter unrestorableFiles of interface ManagedDatabaseRestoreDetailsResult is changed from string[] to ManagedDatabaseRestoreDetailsUnrestorableFileProperties[]

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 80d422b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.5.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-sql [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️🔄 azure-sdk-for-net-track2 inProgress [Detail]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 80d422b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 80d422b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/sql/armsql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentScanResultClient`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentScansClient`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentsSettingsClient`
      info	[Changelog] - New struct `EndpointDependency`
      info	[Changelog] - New struct `EndpointDetail`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClient`
      info	[Changelog] - New struct `ManagedDatabaseMoveDefinition`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationListResult`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationResult`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationResultProperties`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationsClient`
      info	[Changelog] - New struct `ManagedDatabaseRestoreDetailsBackupSetProperties`
      info	[Changelog] - New struct `ManagedDatabaseRestoreDetailsUnrestorableFileProperties`
      info	[Changelog] - New struct `ManagedDatabaseStartMoveDefinition`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClient`
      info	[Changelog] - New struct `ManagedInstanceDtc`
      info	[Changelog] - New struct `ManagedInstanceDtcListResult`
      info	[Changelog] - New struct `ManagedInstanceDtcProperties`
      info	[Changelog] - New struct `ManagedInstanceDtcSecuritySettings`
      info	[Changelog] - New struct `ManagedInstanceDtcTransactionManagerCommunicationSettings`
      info	[Changelog] - New struct `ManagedInstanceDtcsClient`
      info	[Changelog] - New struct `ManagedLedgerDigestUploads`
      info	[Changelog] - New struct `ManagedLedgerDigestUploadsClient`
      info	[Changelog] - New struct `ManagedLedgerDigestUploadsListResult`
      info	[Changelog] - New struct `ManagedLedgerDigestUploadsProperties`
      info	[Changelog] - New struct `ManagedServerDNSAlias`
      info	[Changelog] - New struct `ManagedServerDNSAliasAcquisition`
      info	[Changelog] - New struct `ManagedServerDNSAliasCreation`
      info	[Changelog] - New struct `ManagedServerDNSAliasListResult`
      info	[Changelog] - New struct `ManagedServerDNSAliasProperties`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClient`
      info	[Changelog] - New struct `OutboundEnvironmentEndpoint`
      info	[Changelog] - New struct `OutboundEnvironmentEndpointCollection`
      info	[Changelog] - New struct `PrivateEndpointConnectionPropertiesAutoGenerated`
      info	[Changelog] - New struct `QueryCheck`
      info	[Changelog] - New struct `RefreshExternalGovernanceStatusOperationResult`
      info	[Changelog] - New struct `RefreshExternalGovernanceStatusOperationResultProperties`
      info	[Changelog] - New struct `Remediation`
      info	[Changelog] - New struct `ScheduleItem`
      info	[Changelog] - New struct `ServerConfigurationOption`
      info	[Changelog] - New struct `ServerConfigurationOptionListResult`
      info	[Changelog] - New struct `ServerConfigurationOptionProperties`
      info	[Changelog] - New struct `ServerConfigurationOptionsClient`
      info	[Changelog] - New struct `StartStopManagedInstanceSchedule`
      info	[Changelog] - New struct `StartStopManagedInstanceScheduleListResult`
      info	[Changelog] - New struct `StartStopManagedInstanceScheduleProperties`
      info	[Changelog] - New struct `StartStopManagedInstanceSchedulesClient`
      info	[Changelog] - New struct `SynapseLinkWorkspace`
      info	[Changelog] - New struct `SynapseLinkWorkspaceInfoProperties`
      info	[Changelog] - New struct `SynapseLinkWorkspaceListResult`
      info	[Changelog] - New struct `SynapseLinkWorkspaceProperties`
      info	[Changelog] - New struct `SynapseLinkWorkspacesClient`
      info	[Changelog] - New struct `UpdateVirtualClusterDNSServersOperation`
      info	[Changelog] - New struct `VaRule`
      info	[Changelog] - New struct `VirtualClusterDNSServersProperties`
      info	[Changelog] - New struct `VulnerabilityAssessment`
      info	[Changelog] - New struct `VulnerabilityAssessmentBaselineClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentBaselinesClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentExecuteScanClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentListResult`
      info	[Changelog] - New struct `VulnerabilityAssessmentPolicyProperties`
      info	[Changelog] - New struct `VulnerabilityAssessmentRuleBaselineClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentRuleBaselinesClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanForSQLError`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanListResult`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQL`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLListResult`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLProperties`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanResultClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanResultProperties`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanResults`
      info	[Changelog] - New struct `VulnerabilityAssessmentScansClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentsClient`
      info	[Changelog] - New struct `VulnerabilityAssessmentsSettingsClient`
      info	[Changelog] - New field `AvailabilityZone` in struct `DatabaseProperties`
      info	[Changelog] - New field `EncryptionProtector` in struct `DatabaseProperties`
      info	[Changelog] - New field `Keys` in struct `DatabaseProperties`
      info	[Changelog] - New field `ManualCutover` in struct `DatabaseProperties`
      info	[Changelog] - New field `PerformCutover` in struct `DatabaseProperties`
      info	[Changelog] - New field `PreferredEnclaveType` in struct `DatabaseProperties`
      info	[Changelog] - New field `EncryptionProtector` in struct `DatabaseUpdateProperties`
      info	[Changelog] - New field `Keys` in struct `DatabaseUpdateProperties`
      info	[Changelog] - New field `ManualCutover` in struct `DatabaseUpdateProperties`
      info	[Changelog] - New field `PerformCutover` in struct `DatabaseUpdateProperties`
      info	[Changelog] - New field `PreferredEnclaveType` in struct `DatabaseUpdateProperties`
      info	[Changelog] - New field `Expand` in struct `DatabasesClientGetOptions`
      info	[Changelog] - New field `Filter` in struct `DatabasesClientGetOptions`
      info	[Changelog] - New field `SecondaryType` in struct `InstanceFailoverGroupProperties`
      info	[Changelog] - New field `CrossSubscriptionRestorableDroppedDatabaseID` in struct `ManagedDatabaseProperties`
      info	[Changelog] - New field `CrossSubscriptionSourceDatabaseID` in struct `ManagedDatabaseProperties`
      info	[Changelog] - New field `CrossSubscriptionTargetManagedInstanceID` in struct `ManagedDatabaseProperties`
      info	[Changelog] - New field `StorageContainerIdentity` in struct `ManagedDatabaseProperties`
      info	[Changelog] - New field `CurrentBackupType` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `CurrentRestorePlanSizeMB` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `CurrentRestoredSizeMB` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `DiffBackupSets` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `FullBackupSets` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `LogBackupSets` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `NumberOfFilesQueued` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `NumberOfFilesRestored` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `NumberOfFilesRestoring` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `NumberOfFilesSkipped` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `NumberOfFilesUnrestorable` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `Type` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New field `NextLink` in struct `RecoverableDatabaseListResult`
      info	[Changelog] - New field `Keys` in struct `RecoverableDatabaseProperties`
      info	[Changelog] - New field `Expand` in struct `RecoverableDatabasesClientGetOptions`
      info	[Changelog] - New field `Filter` in struct `RecoverableDatabasesClientGetOptions`
      info	[Changelog] - New field `Keys` in struct `RestorableDroppedDatabaseProperties`
      info	[Changelog] - New field `Expand` in struct `RestorableDroppedDatabasesClientGetOptions`
      info	[Changelog] - New field `Filter` in struct `RestorableDroppedDatabasesClientGetOptions`
      info	[Changelog] - New field `IsManagedIdentityInUse` in struct `ServerDevOpsAuditSettingsProperties`
      info	[Changelog] - New field `ExternalGovernanceStatus` in struct `ServerProperties`
      info	[Changelog] - New field `Version` in struct `VirtualClusterProperties`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 367 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 80d422b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias StartStopScheduleName
      info	[Changelog]   - Added Type Alias SynapseLinkWorkspacesListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias SynapseLinkWorkspacesListByDatabaseResponse
      info	[Changelog]   - Added Type Alias SyncGroupsType
      info	[Changelog]   - Interface Database has a new optional parameter availabilityZone
      info	[Changelog]   - Interface Database has a new optional parameter encryptionProtector
      info	[Changelog]   - Interface Database has a new optional parameter keys
      info	[Changelog]   - Interface Database has a new optional parameter manualCutover
      info	[Changelog]   - Interface Database has a new optional parameter performCutover
      info	[Changelog]   - Interface Database has a new optional parameter preferredEnclaveType
      info	[Changelog]   - Interface Database has a new optional parameter sourceResourceId
      info	[Changelog]   - Interface DatabaseBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
      info	[Changelog]   - Interface DatabasesGetOptionalParams has a new optional parameter expand
      info	[Changelog]   - Interface DatabasesGetOptionalParams has a new optional parameter filter
      info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter encryptionProtector
      info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter keys
      info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter manualCutover
      info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter performCutover
      info	[Changelog]   - Interface DatabaseUpdate has a new optional parameter preferredEnclaveType
      info	[Changelog]   - Interface ElasticPool has a new optional parameter highAvailabilityReplicaCount
      info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter highAvailabilityReplicaCount
      info	[Changelog]   - Interface ExtendedDatabaseBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
      info	[Changelog]   - Interface ExtendedServerBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
      info	[Changelog]   - Interface InstanceFailoverGroup has a new optional parameter secondaryType
      info	[Changelog]   - Interface ManagedDatabase has a new optional parameter crossSubscriptionRestorableDroppedDatabaseId
      info	[Changelog]   - Interface ManagedDatabase has a new optional parameter crossSubscriptionSourceDatabaseId
      info	[Changelog]   - Interface ManagedDatabase has a new optional parameter crossSubscriptionTargetManagedInstanceId
      info	[Changelog]   - Interface ManagedDatabase has a new optional parameter storageContainerIdentity
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter currentBackupType
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter currentRestoredSizeMB
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter currentRestorePlanSizeMB
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter diffBackupSets
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter fullBackupSets
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter logBackupSets
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesQueued
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesRestored
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesRestoring
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesSkipped
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter numberOfFilesUnrestorable
      info	[Changelog]   - Interface ManagedDatabaseRestoreDetailsResult has a new optional parameter typePropertiesType
      info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter crossSubscriptionRestorableDroppedDatabaseId
      info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter crossSubscriptionSourceDatabaseId
      info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter crossSubscriptionTargetManagedInstanceId
      info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter storageContainerIdentity
      info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds
      info	[Changelog]   - Interface RecoverableDatabase has a new optional parameter keys
      info	[Changelog]   - Interface RecoverableDatabaseListResult has a new optional parameter nextLink
      info	[Changelog]   - Interface RecoverableDatabasesGetOptionalParams has a new optional parameter expand
      info	[Changelog]   - Interface RecoverableDatabasesGetOptionalParams has a new optional parameter filter
      info	[Changelog]   - Interface ReplicationLinksDeleteOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface ReplicationLinksDeleteOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface RestorableDroppedDatabase has a new optional parameter keys
      info	[Changelog]   - Interface RestorableDroppedDatabasesGetOptionalParams has a new optional parameter expand
      info	[Changelog]   - Interface RestorableDroppedDatabasesGetOptionalParams has a new optional parameter filter
      info	[Changelog]   - Interface Server has a new optional parameter externalGovernanceStatus
      info	[Changelog]   - Interface ServerBlobAuditingPolicy has a new optional parameter isManagedIdentityInUse
      info	[Changelog]   - Interface ServerDevOpsAuditingSettings has a new optional parameter isManagedIdentityInUse
      info	[Changelog]   - Interface ServerUpdate has a new optional parameter externalGovernanceStatus
      info	[Changelog]   - Interface TransparentDataEncryptionsCreateOrUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface TransparentDataEncryptionsCreateOrUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface VirtualCluster has a new optional parameter version
      info	[Changelog]   - Interface VirtualClustersUpdateDnsServersOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface VirtualClustersUpdateDnsServersOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface VirtualClusterUpdate has a new optional parameter version
      info	[Changelog]   - Added Enum KnownAdvancedThreatProtectionName
      info	[Changelog]   - Added Enum KnownAlwaysEncryptedEnclaveType
      info	[Changelog]   - Added Enum KnownAvailabilityZoneType
      info	[Changelog]   - Added Enum KnownBaselineName
      info	[Changelog]   - Added Enum KnownDatabaseKeyType
      info	[Changelog]   - Added Enum KnownDevOpsAuditingSettingsName
      info	[Changelog]   - Added Enum KnownDNSRefreshOperationStatus
      info	[Changelog]   - Added Enum KnownDtcName
      info	[Changelog]   - Added Enum KnownExternalGovernanceStatus
      info	[Changelog]   - Added Enum KnownManagedLedgerDigestUploadsName
      info	[Changelog]   - Added Enum KnownManagedLedgerDigestUploadsState
      info	[Changelog]   - Added Enum KnownMoveOperationMode
      info	[Changelog]   - Added Enum KnownReplicationMode
      info	[Changelog]   - Added Enum KnownRuleSeverity
      info	[Changelog]   - Added Enum KnownRuleStatus
      info	[Changelog]   - Added Enum KnownRuleType
      info	[Changelog]   - Added Enum KnownSecondaryInstanceType
      info	[Changelog]   - Added Enum KnownServerConfigurationOptionName
      info	[Changelog]   - Added Enum KnownServerPublicNetworkAccessFlag
      info	[Changelog]   - Added Enum KnownSQLVulnerabilityAssessmentName
      info	[Changelog]   - Added Enum KnownSqlVulnerabilityAssessmentName
      info	[Changelog]   - Added Enum KnownStartStopScheduleName
      info	[Changelog]   - Added Enum KnownSyncGroupsType
      info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value DbCopying
      info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value DbMoving
      info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value Starting
      info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value Stopped
      info	[Changelog]   - Enum KnownManagedDatabaseStatus has a new value Stopping
      info	[Changelog]   - Enum KnownReplicationLinkType has a new value Standby
      info	[Changelog]   - Enum KnownSecondaryType has a new value Standby
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group OperationsHealthOperations
      info	[Changelog]   - Removed operation ReplicationLinks.beginUnlink
      info	[Changelog]   - Removed operation ReplicationLinks.beginUnlinkAndWait
      info	[Changelog]   - Removed operation ReplicationLinks.delete
      info	[Changelog]   - Removed operation TransparentDataEncryptions.createOrUpdate
      info	[Changelog]   - Removed operation VirtualClusters.updateDnsServers
      info	[Changelog]   - Operation ServerDevOpsAuditSettings.beginCreateOrUpdate has a new signature
      info	[Changelog]   - Operation ServerDevOpsAuditSettings.beginCreateOrUpdateAndWait has a new signature
      info	[Changelog]   - Operation ServerDevOpsAuditSettings.get has a new signature
      info	[Changelog]   - Operation SyncGroups.listLogs has a new signature
      info	[Changelog]   - Interface Database no longer has parameter primaryDelegatedIdentityClientId
      info	[Changelog]   - Interface DatabaseIdentity no longer has parameter delegatedResources
      info	[Changelog]   - Interface DatabaseUpdate no longer has parameter primaryDelegatedIdentityClientId
      info	[Changelog]   - Interface VirtualCluster no longer has parameter family
      info	[Changelog]   - Interface VirtualCluster no longer has parameter maintenanceConfigurationId
      info	[Changelog]   - Interface VirtualClusterUpdate no longer has parameter family
      info	[Changelog]   - Interface VirtualClusterUpdate no longer has parameter maintenanceConfigurationId
      info	[Changelog]   - Type of parameter unrestorableFiles of interface ManagedDatabaseRestoreDetailsResult is changed from string[] to ManagedDatabaseRestoreDetailsUnrestorableFileProperties[]
      info	[Changelog]   - Type of parameter publicNetworkAccess of interface Server is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
      info	[Changelog]   - Type of parameter publicNetworkAccess of interface ServerUpdate is changed from ServerNetworkAccessFlag to ServerPublicNetworkAccessFlag
      info	[Changelog]   - Class SqlManagementClient no longer has parameter operationsHealthOperations
      info	[Changelog]   - Removed Enum KnownDnsRefreshConfigurationPropertiesStatus
      info	[Changelog]   - Removed Enum KnownEnum60
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 80d422b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️sql [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 80d422b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the SQL label Feb 21, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 21, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/sql/armsql https://apiview.dev/Assemblies/Review/3b517cb5aeaf49d8a9d3827cc44c6666
    JavaScript @azure/arm-sql https://apiview.dev/Assemblies/Review/a737a06bf265465a84d3dace9c45315a

    @openapi-workflow-bot
    Copy link

    Hi @Dylan-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @raych1
    Copy link
    Member

    raych1 commented Feb 22, 2023

    @Dylan-MSFT , can you fix other modelvalidation errors either?

    @raych1 raych1 added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Feb 22, 2023
    Copy link
    Member

    @ericshape ericshape left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    the author removed id line in the example file due to the security reason.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants