Review request for Microsoft.RecoveryServicesSiteRecovery to add version stable/2023-02-01 #22613

shesamian · 2023-02-14T18:36:11Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…/2022-10-01 to version 2023-01-01

Fixing swagger linting issue.

Swagger correctness fix.

This reverts commit 9831058.

openapi-workflow-bot · 2023-02-14T18:36:15Z

Hi, @shesamian Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-02-14T18:36:23Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
service.json	2023-02-01(16e1473)	2023-01-01(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 272 Errors, 0 Warnings failed [Detail]

Tag package-2023-02; Prod region: Deployed

Test run on region: westcentralus; Operation coverage: total: 137, untested: 0, failed: 136, passed: 1

Service API Readiness Test failed. Check pipeline artifact for detail report.

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_Create
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_Create
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_List
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_List
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_Get
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_Get
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_MigrateToAad
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_MigrateToAad
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_ReassociateGateway
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_ReassociateGateway
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_CheckConsistency
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_CheckConsistency
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_Delete
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_Delete
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationFabrics_RenewCertificate
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationFabrics_RenewCertificate
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationProtectionContainers_Create
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationProtectionContainers_Create
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationProtectionContainers_ListByReplicationFabrics
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationProtectionContainers_ListByReplicationFabrics
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationProtectionContainers_Get
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationProtectionContainers_Get
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationProtectionContainers_List
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationProtectionContainers_List
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationProtectionContainers_DiscoverProtectableItem
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationProtectionContainers_DiscoverProtectableItem
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationProtectionContainers_Delete
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationProtectionContainers_Delete
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.RecoveryServices/vaults/resource6wjrpm' under resource group 'apiTest-epCHQh-22613' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ReplicationProtectionContainers_SwitchProtection
`❌` INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: ReplicationProtectionContainers_SwitchProtection

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-14T18:36:24Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 539c2fd5385a294c167e1c058f127c11bbc2ac31. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.RecoveryServicesSiteRecovery [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.RecoveryServicesSiteRecovery.1.0.0-alpha.20230306.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 539c2fd5385a294c167e1c058f127c11bbc2ac31. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.6.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-recoveryservicessiterecovery [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model AzureFabricSpecificDetails has a new parameter location_details
info	[Changelog]   - Model FabricQueryParameter has a new parameter extended_location_mappings
info	[Changelog]   - Model FabricQueryParameter has a new parameter location_details
info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter confidential_vm_key_vault_id
info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter target_vm_security_profile
info	[Changelog]   - Model VMwareCbtMigrateInput has a new parameter os_upgrade_version
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter confidential_vm_key_vault_id
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter os_name
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter supported_os_versions
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter target_vm_security_profile
info	[Changelog]   - Model VMwareCbtProtectionContainerMappingDetails has a new parameter excluded_skus
info	[Changelog]   - Model VMwareCbtTestMigrateInput has a new parameter os_upgrade_version

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 539c2fd5385a294c167e1c058f127c11bbc2ac31. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-recoveryservicessiterecovery [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 539c2fd5385a294c167e1c058f127c11bbc2ac31. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `SecurityType` with values `SecurityTypeConfidentialVM`, `SecurityTypeNone`, `SecurityTypeTrustedLaunch`
info	[Changelog] - New struct `A2AFabricSpecificLocationDetails`
info	[Changelog] - New struct `VMwareCbtSecurityProfileProperties`
info	[Changelog] - New field `LocationDetails` in struct `AzureFabricSpecificDetails`
info	[Changelog] - New field `ExtendedLocationMappings` in struct `FabricQueryParameter`
info	[Changelog] - New field `LocationDetails` in struct `FabricQueryParameter`
info	[Changelog] - New field `ConfidentialVMKeyVaultID` in struct `VMwareCbtEnableMigrationInput`
info	[Changelog] - New field `TargetVMSecurityProfile` in struct `VMwareCbtEnableMigrationInput`
info	[Changelog] - New field `OSUpgradeVersion` in struct `VMwareCbtMigrateInput`
info	[Changelog] - New field `ConfidentialVMKeyVaultID` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `OSName` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `SupportedOSVersions` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `TargetVMSecurityProfile` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `ExcludedSKUs` in struct `VMwareCbtProtectionContainerMappingDetails`
info	[Changelog] - New field `OSUpgradeVersion` in struct `VMwareCbtTestMigrateInput`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 15 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 539c2fd5385a294c167e1c058f127c11bbc2ac31. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-recoveryservices-siterecovery [View full logs] [Preview SDK Changes]

azure-arm-recoveryservices-siterecovery-5.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface A2AFabricSpecificLocationDetails
info	[Changelog]   - Added Interface VMwareCbtSecurityProfileProperties
info	[Changelog]   - Added Type Alias SecurityType
info	[Changelog]   - Interface AzureFabricSpecificDetails has a new optional parameter locationDetails
info	[Changelog]   - Interface FabricQueryParameter has a new optional parameter extendedLocationMappings
info	[Changelog]   - Interface FabricQueryParameter has a new optional parameter locationDetails
info	[Changelog]   - Interface VMwareCbtEnableMigrationInput has a new optional parameter confidentialVmKeyVaultId
info	[Changelog]   - Interface VMwareCbtEnableMigrationInput has a new optional parameter targetVmSecurityProfile
info	[Changelog]   - Interface VMwareCbtMigrateInput has a new optional parameter osUpgradeVersion
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter confidentialVmKeyVaultId
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter osName
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter supportedOSVersions
info	[Changelog]   - Interface VMwareCbtMigrationDetails has a new optional parameter targetVmSecurityProfile
info	[Changelog]   - Interface VMwareCbtProtectionContainerMappingDetails has a new optional parameter excludedSkus
info	[Changelog]   - Interface VMwareCbtTestMigrateInput has a new optional parameter osUpgradeVersion
info	[Changelog]   - Added Enum KnownSecurityType

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 539c2fd5385a294c167e1c058f127c11bbc2ac31. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️recoveryservicessiterecovery [View full logs] [Preview Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from bbf213c11e0ad22b3e2ca65380cf358792fccce6. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.SiteRecovery [View full logs] [Preview SDK Changes]
- Az.SiteRecovery.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-02-14T18:36:25Z

Generated ApiView

Language	Package Name	ApiView Link
swagger	Microsoft.RecoveryServices	https://apiview.dev/Assemblies/Review/68127afb44c343cbb89a4827034318a1
Go	sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery	https://apiview.dev/Assemblies/Review/1f35fdab1c5e460b930e00bff1a8ba08
Java	azure-resourcemanager-recoveryservicessiterecovery	https://apiview.dev/Assemblies/Review/68e9eb09a28a47c89d4cc3f6cdd53dff
.Net	Azure.ResourceManager.RecoveryServicesSiteRecovery	https://apiview.dev/Assemblies/Review/8c48c46423ed45b88db48fbde52b8512
JavaScript	@azure/arm-recoveryservices-siterecovery	https://apiview.dev/Assemblies/Review/e46ccdd274284133a0fd720de681f7d0

shesamian · 2023-02-14T19:49:12Z

This PR is waiting for 2023-01-01 to complete first:
#22076

openapi-workflow-bot · 2023-02-15T05:14:42Z

Hi, @shesamian, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

…ery-Microsoft.RecoveryServices-2023-01-01' into release-recoveryservicessiterecovery-Microsoft.RecoveryServices-2023-02-01

shesamian · 2023-03-02T19:04:23Z

/azp run

azure-pipelines · 2023-03-02T19:04:30Z

Commenter does not have sufficient privileges for PR 22613 in repo Azure/azure-rest-api-specs

viananth · 2023-03-02T19:06:18Z

/azp run

azure-pipelines · 2023-03-02T19:06:28Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-workflow-bot · 2023-03-02T19:13:58Z

Hi @shesamian, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2023-03-03T17:34:38Z

Hi, @shesamian your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

…cessiterecovery-Microsoft.RecoveryServices-2023-02-01

viananth · 2023-03-06T17:23:26Z

/azp run

azure-pipelines · 2023-03-06T17:23:37Z

Azure Pipelines successfully started running 1 pipeline(s).

singhabh27 and others added 15 commits January 4, 2023 15:05

Adds base for updating Microsoft.RecoveryServices from version stable…

3b45feb

…/2022-10-01 to version 2023-01-01

Updates readme

29bfedf

Updates API version in new specs and examples

f5f721f

CVM and OS Upgrade changes

c7d7b97

Update ReplicationProtectionContainers_SwitchProtection.json

f237138

Fixing swagger linting issue.

Update service.json

6f53906

Swagger correctness fix.

Updated supportedOSVersions description.

ef17979

Taken up ARM feedback

f63c4d8

model validation fix

9831058

Revert "model validation fix"

43204ba

This reverts commit 9831058.

Fixing model validations

4afadba

Fixing ReplicationFabrics_Purge.json

70b86b2

Fixing model validations

52f563f

RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE fix

9b80d30

Started the work

d63f60c

ghost added the Recovery Services Site-Recovery label Feb 14, 2023

shesamian changed the title ~~Release recoveryservicessiterecovery microsoft.recovery services 2023 02 01~~ Release recoveryservicessiterecovery microsoft.recovery services 2023-02-01 Feb 14, 2023

shesamian changed the title ~~Release recoveryservicessiterecovery microsoft.recovery services 2023-02-01~~ Review request for Microsoft.RecoveryServices to add version stable/2023-02-01 Feb 14, 2023

Added fabric controller's specific changes

54a4eca

azure-sdk mentioned this pull request Feb 15, 2023

[AutoPR sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery] Review request for Microsoft.RecoveryServicesSiteRecovery to add version stable/2023-02-01 azure-sdk/azure-sdk-for-go#4443

Closed

AzureRestAPISpecReview added CI-MissingBaseCommit new-api-version resource-manager labels Feb 15, 2023

azure-sdk mentioned this pull request Feb 15, 2023

[AutoPR azure-resourcemanager-recoveryservicessiterecovery] Review request for Microsoft.RecoveryServicesSiteRecovery to add version stable/2023-02-01 azure-sdk/azure-sdk-for-java#3939

Closed

singhabh27 and others added 4 commits February 15, 2023 12:15

Adding Azure-AsyncOperation in header

04ad4e3

Fixing examples

c7dab5e

Merge remote-tracking branch 'singh/release-recoveryservicessiterecov…

f3206be

…ery-Microsoft.RecoveryServices-2023-01-01' into release-recoveryservicessiterecovery-Microsoft.RecoveryServices-2023-02-01

sync branches

b1f8156

azure-sdk mentioned this pull request Feb 22, 2023

[AutoPR Az.recoveryservicessiterecovery] Review request for Microsoft.RecoveryServices to add version stable/2023-02-01 azure-sdk/azure-powershell#4445

Closed

shesamian force-pushed the release-recoveryservicessiterecovery-Microsoft.RecoveryServices-2023-02-01 branch from 00dac0e to b1f8156 Compare February 22, 2023 09:06

shesamian changed the title ~~Review request for Microsoft.RecoveryServices to add version stable/2023-02-01~~ Review request for Microsoft.RecoveryServicesSiteRecovery to add version stable/2023-02-01 Feb 22, 2023

shesamian marked this pull request as ready for review February 27, 2023 18:46

openapi-assignment-bot bot assigned jianyexi Feb 27, 2023

AzureRestAPISpecReview added ARMReview CI-FixRequiredOnFailure WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 2, 2023

Added x-ms-identifiers to location details

3b52833

AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Mar 2, 2023

shesamian added 2 commits March 6, 2023 07:26

Merge remote-tracking branch 'origin/main' into release-recoveryservi…

4328766

…cessiterecovery-Microsoft.RecoveryServices-2023-02-01

Updated readme

16e1473

shesamian closed this Mar 6, 2023

Review request for Microsoft.RecoveryServicesSiteRecovery to add version stable/2023-02-01 #22613

Review request for Microsoft.RecoveryServicesSiteRecovery to add version stable/2023-02-01 #22613

Uh oh!

Conversation

shesamian commented Feb 14, 2023 • edited by singhabh27 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Feb 14, 2023

Uh oh!

openapi-pipeline-app bot commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

shesamian commented Feb 14, 2023

Uh oh!

openapi-workflow-bot bot commented Feb 15, 2023

Uh oh!

shesamian commented Mar 2, 2023

Uh oh!

azure-pipelines bot commented Mar 2, 2023

Uh oh!

viananth commented Mar 2, 2023

Uh oh!

azure-pipelines bot commented Mar 2, 2023

Uh oh!

openapi-workflow-bot bot commented Mar 2, 2023

Uh oh!

openapi-workflow-bot bot commented Mar 3, 2023

Uh oh!

viananth commented Mar 6, 2023

Uh oh!

azure-pipelines bot commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shesamian commented Feb 14, 2023 •

edited by singhabh27

Loading

openapi-pipeline-app bot commented Feb 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 14, 2023 •

edited

Loading

openapi-pipeline-app bot commented Feb 14, 2023 •

edited

Loading