Skip to content

Sasolank/more review comments #21025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solankisamir merged 2 commits into from
Oct 6, 2022
Merged

Sasolank/more review comments #21025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
521744a
XML
solankisamir Oct 6, 2022
9e27850
proxy to gateway
solankisamir Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ent/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimbackends.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@
"BackendReconnect"
],
"operationId": "Backend_Reconnect",
"description": "Notifies the APIM proxy to create a new connection to the backend after the specified timeout. If no timeout was specified, timeout of 2 minutes is used.",
"description": "Notifies the API Management gateway to create a new connection to the backend after the specified timeout. If no timeout was specified, timeout of 2 minutes is used.",
"x-ms-examples": {
"ApiManagementBackendReconnect": {
"$ref": "./examples/ApiManagementBackendReconnect.json"
Expand Down
2 changes: 1 addition & 1 deletion ...t/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimdeployment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@
},
"defaultSslBinding": {
"type": "boolean",
"description": "Specify true to setup the certificate associated with this Hostname as the Default SSL Certificate. If a client does not send the SNI header, then this will be the certificate that will be challenged. The property is useful if a service has multiple custom hostname enabled and it needs to decide on the default ssl certificate. The setting only applied to Proxy Hostname Type.",
"description": "Specify true to setup the certificate associated with this Hostname as the Default SSL Certificate. If a client does not send the SNI header, then this will be the certificate that will be challenged. The property is useful if a service has multiple custom hostname enabled and it needs to decide on the default ssl certificate. The setting only applied to gateway Hostname Type.",
"default": false
},
"negotiateClientCertificate": {
Expand Down
2 changes: 1 addition & 1 deletion .../resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimdiagnostics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"swagger": "2.0",
"info": {
"title": "ApiManagementClient",
"description": "Use these REST APIs for performing operations on Diagnostic entity associated with your Azure API Management deployment. Diagnostics are used to log requests/responses in the APIM proxy.",
"description": "Use these REST APIs for performing operations on Diagnostic entity associated with your Azure API Management deployment. Diagnostics are used to log requests/responses in the API Management proxy.",
"version": "2022-04-01-preview"
},
"host": "management.azure.com",
Expand Down
16 changes: 8 additions & 8 deletions ...ment/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1835,7 +1835,7 @@
},
"proxy": {
"$ref": "#/definitions/BackendProxyContract",
"description": "Backend Proxy Contract Properties"
"description": "Backend gateway Contract Properties"
},
"tls": {
"$ref": "#/definitions/BackendTlsProperties",
Expand Down Expand Up @@ -4282,7 +4282,7 @@
},
{
"value": "rawxml-link",
"description": "The policy document is not Xml encoded and is hosted on a http endpoint accessible from the API Management service."
"description": "The policy document is not XML encoded and is hosted on a http endpoint accessible from the API Management service."
}
]
},
Expand Down Expand Up @@ -4332,7 +4332,7 @@
"items": {
"$ref": "#/definitions/PolicyDescriptionContract"
},
"description": "Descriptions of APIM policies."
"description": "Descriptions of API Management policies."
},
"count": {
"type": "integer",
Expand All @@ -4341,7 +4341,7 @@
"description": "Total record count number."
}
},
"description": "Descriptions of APIM policies."
"description": "Descriptions of API Management policies."
},
"PolicyFragmentCollection": {
"type": "object",
Expand Down Expand Up @@ -4672,7 +4672,7 @@
"items": {
"$ref": "#/definitions/PortalSettingsContract"
},
"description": "Descriptions of APIM policies."
"description": "Descriptions of API Management policies."
},
"count": {
"type": "integer",
Expand All @@ -4681,7 +4681,7 @@
"description": "Total record count number."
}
},
"description": "Descriptions of APIM policies."
"description": "Descriptions of API Management policies."
},
"PortalSettingsContract": {
"properties": {
Expand Down Expand Up @@ -5399,7 +5399,7 @@
"callCountFailed": {
"type": "integer",
"format": "int32",
"description": "Number of calls failed due to proxy or backend errors. This includes calls returning HttpStatusCode.BadRequest(400) and any Code between HttpStatusCode.InternalServerError (500) and 600"
"description": "Number of calls failed due to gateway or backend errors. This includes calls returning HttpStatusCode.BadRequest(400) and any Code between HttpStatusCode.InternalServerError (500) and 600"
},
"callCountOther": {
"type": "integer",
Expand Down Expand Up @@ -5858,7 +5858,7 @@
"values": [
{
"value": "xml",
"description": "Xml schema type.",
"description": "XML schema type.",
"name": "Xml"
},
{
Expand Down