Skip to content

[Microsoft.DeviceUpdate] (Internal only) Added Private Endpoint Proxy Private Endpoint Update #18281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 16 commits into from
Mar 19, 2022
Merged

[Microsoft.DeviceUpdate] (Internal only) Added Private Endpoint Proxy Private Endpoint Update #18281

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8e9f27f
(Internal only) Added Private Endpoint Proxy Private Endpoint Update
darkoa-msft Mar 16, 2022
362fb66
The existing resource also needs a change
darkoa-msft Mar 16, 2022
f8b893f
Renamed example
darkoa-msft Mar 17, 2022
f6b3ae0
Fixing more copy and paste errors
darkoa-msft Mar 17, 2022
3a20ede
Removed read only, formatted new file
darkoa-msft Mar 17, 2022
414d0c6
Move provisioning state inside proxy properties
darkoa-msft Mar 18, 2022
e4e46e0
Revert "Move provisioning state inside proxy properties"
darkoa-msft Mar 18, 2022
e662e78
Moved proxy provisioning state into properties, try #2
darkoa-msft Mar 18, 2022
067ff1b
Moved proxy provisioning state into properties, try number 3
darkoa-msft Mar 18, 2022
a541f80
Moved proxy provisioning state into properties, try number 4
darkoa-msft Mar 18, 2022
73d8c35
Moved Proxy provisioningState to top level, removed property bag
darkoa-msft Mar 18, 2022
6947905
Fixed a naming error
darkoa-msft Mar 18, 2022
6e47697
Linter fixes
darkoa-msft Mar 18, 2022
52e66c5
Removed flatten in Proxy properties
darkoa-msft Mar 19, 2022
c1cb68f
Reverted all provisioningState changes
darkoa-msft Mar 19, 2022
9456331
Swapped properties to match the old swagger
darkoa-msft Mar 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 95 additions & 7 deletions ...date/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,55 @@
"deprecated": false
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}/updatePrivateEndpointProperties": {
"post": {
"description": "(INTERNAL - DO NOT USE) Updates a private endpoint inside the private endpoint connection proxy object.",
"operationId": "PrivateEndpointConnectionProxies_PrivateEndpointUpdate",
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/AccountNameParameter"
},
{
"$ref": "#/parameters/PrivateEndpointConnectionProxyIdParameter"
},
{
"name": "privateEndpointUpdate",
"in": "body",
"description": "The parameters for updating a private endpoint connection proxy.",
"required": true,
"schema": {
"$ref": "#/definitions/PrivateEndpointUpdate"
}
}
],
"responses": {
"200": {
"description": "Update private endpoint in private endpoint connection proxy empty response."
},
"default": {
"description": "Error response describing the reason for operation failure.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
}
}
},
"x-ms-examples": {
"PrivateEndpointConnectionProxyPrivateEndpointUpdate": {
"$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json"
}
},
"deprecated": false
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}": {
"get": {
"tags": [
Expand Down Expand Up @@ -1548,7 +1597,13 @@
{
"$ref": "#/definitions/PrivateEndpointConnectionProxyProperties"
}
]
],
"properties": {
"provisioningState": {
Copy link
Member

@raych1 raych1 Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace provisioningState by properties to clean up the errors.

"$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState",
"description": "The provisioning state of the private endpoint connection proxy resource."
}
}
},
"PrivateEndpointConnectionProxyProperties": {
"description": "Private endpoint connection proxy object properties.",
Expand All @@ -1564,10 +1619,6 @@
"description": "Remote private endpoint details.",
"$ref": "#/definitions/RemotePrivateEndpoint"
},
"provisioningState": {
"$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState",
"description": "The provisioning state of the private endpoint connection proxy resource."
},
"status": {
"description": "Operation status.",
"type": "string"
Expand All @@ -1582,10 +1633,21 @@
"description": "Remote endpoint resource ID.",
"type": "string"
},
"location": {
"description": "ARM location of the remote private endpoint.",
"type": "string"
},
"immutableSubscriptionId": {
"description": "Original subscription ID needed by Microsoft.Network.",
"type": "string"
},
"immutableResourceId": {
"description": "Original resource ID needed by Microsoft.Network.",
"type": "string"
},
"vnetTrafficTag": {
"description": "Virtual network traffic tag.",
"type": "string",
"readOnly": true
"type": "string"
},
"manualPrivateLinkServiceConnections": {
"description": "List of private link service connections that need manual approval.",
Expand Down Expand Up @@ -1617,6 +1679,32 @@
}
}
},
"PrivateEndpointUpdate": {
"description": "Private endpoint update details.",
"type": "object",
"properties": {
"id": {
"description": "Remote endpoint resource ID.",
"type": "string"
},
"location": {
"description": "ARM location of the remote private endpoint.",
"type": "string"
},
"immutableSubscriptionId": {
"description": "Original subscription ID needed by Microsoft.Network.",
"type": "string"
},
"immutableResourceId": {
"description": "Original resource ID needed by Microsoft.Network.",
"type": "string"
},
"vnetTrafficTag": {
"description": "Virtual network traffic tag.",
"type": "string"
}
}
},
"PrivateLinkServiceConnection": {
"description": "Private link service connection details.",
"type": "object",
Expand Down
10 changes: 8 additions & 2 deletions ...mples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
"api-version": "2020-03-01-preview",
"privateEndpointConnectionProxy": {
"remotePrivateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}",
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"location": "westus2",
"immutableSubscriptionId": "00000000-0000-0000-0000-000000000000",
"immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"manualPrivateLinkServiceConnections": [
{
"name": "{privateEndpointConnectionProxyId}",
Expand All @@ -33,7 +36,10 @@
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies",
"remotePrivateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}",
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"location": "westus2",
"immutableSubscriptionId": "00000000-0000-0000-0000-000000000000",
"immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"manualPrivateLinkServiceConnections": [
{
"name": "{plsConnectionName}",
Expand Down
5 changes: 4 additions & 1 deletion ...preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies",
"remotePrivateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}",
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"location": "westus2",
"immutableSubscriptionId": "00000000-0000-0000-0000-000000000000",
"immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"manualPrivateLinkServiceConnections": [
{
"name": "{plsConnectionName}",
Expand Down
5 changes: 4 additions & 1 deletion ...amples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies",
"remotePrivateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}",
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"location": "westus2",
"immutableSubscriptionId": "00000000-0000-0000-0000-000000000000",
"immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"manualPrivateLinkServiceConnections": [
{
"name": "{plsConnectionName}",
Expand Down
19 changes: 19 additions & 0 deletions ...rivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_PrivateEndpointUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "test-rg",
"accountName": "contoso",
"privateEndpointConnectionProxyId": "peexample01",
"api-version": "2020-03-01-preview",
"privateEndpointUpdate": {
"id": "/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"location": "westus2",
"immutableSubscriptionId": "00000000-0000-0000-0000-000000000000",
"immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"vnetTrafficTag": "12345678"
}
},
"responses": {
"200": {}
}
}
3 changes: 3 additions & 0 deletions ...ew/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"privateEndpointConnectionProxy": {
"remotePrivateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}",
"location": "westus2",
"immutableSubscriptionId": "00000000-0000-0000-0000-000000000000",
"immutableResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}",
"manualPrivateLinkServiceConnections": [
{
"name": "{privateEndpointConnectionProxyId}",
Expand Down