Skip to content

Adding xms ids to Advisor #17713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruowan merged 9 commits into from
Feb 10, 2022
Merged

Adding xms ids to Advisor #17713

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
832ef5a
Adding x-ms-identifiers for Advisor
agalerrotaru Feb 1, 2022
927f88a
adding the preview xms ids
agalerrotaru Feb 1, 2022
9a5f928
reverting preview file changes
agalerrotaru Feb 1, 2022
60fea5e
Merge branch 'Azure:main' into dev/agalerrotaru/xms-id-advisor
agalerrotaru Feb 2, 2022
e529849
fix model validation errors
agalerrotaru Feb 7, 2022
ea1c7bb
prettier fix
agalerrotaru Feb 8, 2022
591d97e
Merge branch 'Azure:main' into dev/agalerrotaru/xms-id-advisor
agalerrotaru Feb 8, 2022
d19e5aa
revert additional fixes
agalerrotaru Feb 9, 2022
71e2f05
Merge branch 'dev/agalerrotaru/xms-id-advisor' of https://github.com/…
agalerrotaru Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/DigestConfig"
}
},
"x-ms-identifiers": [
"name"
]
}
}
},
Expand Down Expand Up @@ -1164,7 +1167,8 @@
"additionalProperties": {
"type": "object"
}
}
},
"x-ms-identifiers": []
},
"remediation": {
"description": "The automated way to apply recommendation.",
Expand Down Expand Up @@ -1259,7 +1263,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/OperationEntity"
}
},
"x-ms-identifiers": [
"name"
]
}
}
},
Expand Down