Add new 2021-11-01-preview API to support SystemData and managedByTenantId query filtering #16859

skayani · 2021-11-23T19:14:03Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…/2020-02-01-preview to version 2021-11-01-preview

openapi-workflow-bot · 2021-11-23T19:14:10Z

Hi, @skayani Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-11-23T19:14:11Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 2 Errors, 0 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- managedservices/resource-manager/readme.md tag:package-preview-2021-11
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- managedservices/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'MarketplaceRegistrationDefinitions_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L483
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'MarketplaceRegistrationDefinitionsWithoutScope_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L522

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ManagedServices/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L557
`❌` R4037 - MissingTypeObject	The schema 'RegistrationDefinitionList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L701
`❌` R4037 - MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L782
`❌` R4037 - MissingTypeObject	The schema 'RegistrationAssignmentList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L882
`❌` R4037 - MissingTypeObject	The schema 'MarketplaceRegistrationDefinitionList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L969
`❌` R4037 - MissingTypeObject	The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L1022
`❌` R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L1195
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L594
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L721
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L782
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L902
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L558
⚠️ R4021 - DescriptionAndTitleMissing	'MarketplaceRegistrationDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L900
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Registration Definitions Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L436
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Registration Definitions Location: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L514

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` API Readiness check failed. Please make sure your service is deployed.	"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.ManagedServices' for api version '2021-11-01-preview'. The supported api-versions are '2018-06-01-preview, 2019-04-01-preview, 2019-06-01, 2019-09-01, 2020-02-01-preview'."

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️❌Cross-Version Breaking Changes: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.1)
- current:preview/2021-11-01-preview/managedservices.json compared with base:stable/2019-09-01/managedservices.json
- current:preview/2021-11-01-preview/managedservices.json compared with base:preview/2020-02-01-preview/managedservices.json

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'registrationDefinitionIdParameter' removed or renamed? New: Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json#L1239:3 Old: Microsoft.ManagedServices/stable/2019-09-01/managedservices.json#L1064:3

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

managedservices/resource-manager/readme.md#package-preview-2021-11

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-23T19:14:11Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-11-23T19:14:11Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-managedservices - 6.0.0

+	Operation RegistrationAssignmentsOperations.list has a new signature
+	Operation RegistrationDefinitionsOperations.list has a new signature

️✔️azure-sdk-for-go - managedservices/mgmt/2019-06-01/managedservices - v59.3.0
️✔️azure-sdk-for-go - preview/managedservices/mgmt/2019-04-01/managedservices - v59.3.0
️✔️azure-sdk-for-go - preview/managedservices/mgmt/2018-06-01/managedservices - v59.3.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 0e6644c54a38a59abdf495fcdc2be6298583a194. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/managedservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ManagedServices [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.ManagedServices.1.1.0.nupkg
- Microsoft.Azure.Management.ManagedServices.1.1.0.symbols.nupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from 0e6644c54a38a59abdf495fcdc2be6298583a194. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] opencensus-ext-azure 1.1.0 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-identity 1.7.1 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-managedservices [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationAssignmentPropertiesRegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationAssignment has a new parameter system_data
info	[Changelog]   - Model RegistrationAssignmentPropertiesRegistrationDefinitionProperties has a new parameter eligible_authorizations
info	[Changelog]   - Model Authorization has a new parameter principal_id_display_name
info	[Changelog]   - Model Authorization has a new parameter delegated_role_definition_ids
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_id
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter eligible_authorizations
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_name
info	[Changelog]   - Added operation group MarketplaceRegistrationDefinitionsWithoutScopeOperations
info	[Changelog]   - Added operation group MarketplaceRegistrationDefinitionsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation RegistrationAssignmentsOperations.list has a new signature
info	[Changelog]   - Operation RegistrationDefinitionsOperations.list has a new signature

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 0e6644c54a38a59abdf495fcdc2be6298583a194. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-managedservices [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_id
info	[Changelog]   - Model RegistrationDefinitionProperties has a new parameter managee_tenant_name
info	[Changelog]   - Model RegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationAssignmentPropertiesRegistrationDefinition has a new parameter system_data
info	[Changelog]   - Model RegistrationAssignment has a new parameter system_data
info	[Changelog]   - Model JustInTimeAccessPolicy has a new parameter managed_by_tenant_approvers
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation RegistrationAssignmentsOperations.list has a new signature
info	[Changelog]   - Operation RegistrationDefinitionsOperations.list has a new signature

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 0e6644c54a38a59abdf495fcdc2be6298583a194. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-11-23 19:55:29 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-managedservices"
cmderr	[generate.py] 2021-11-23 19:55:29 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-11-23 19:55:29 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.40 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/managedservices/azure-resourcemanager-managedservices --java.namespace=com.azure.resourcemanager.managedservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/managedservices/resource-manager/readme.md
cmderr	[generate.py] 2021-11-23 19:55:56 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-11-23 19:55:56 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-11-23 19:55:56 INFO [POM][Skip] pom already has module azure-resourcemanager-managedservices
cmderr	[generate.py] 2021-11-23 19:55:56 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-11-23 19:55:56 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-11-23 19:55:56 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-managedservices [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-11-23 19:57:34 DEBUG Got artifact_id: azure-resourcemanager-managedservices
cmderr	[Inst] 2021-11-23 19:57:34 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-11-23 19:57:34 DEBUG Got artifact: azure-resourcemanager-managedservices-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-11-23 19:57:34 DEBUG Got artifact: azure-resourcemanager-managedservices-1.0.0-beta.1.jar
cmderr	[Inst] 2021-11-23 19:57:34 DEBUG Match jar package: azure-resourcemanager-managedservices-1.0.0-beta.1.jar
cmderr	[Inst] 2021-11-23 19:57:34 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16859/azure-sdk-for-java/azure-resourcemanager-managedservices/azure-resourcemanager-managedservices-1.0.0-beta.1.jar\" -o azure-resourcemanager-managedservices-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-managedservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-managedservices-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 0e6644c54a38a59abdf495fcdc2be6298583a194. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️managedservices/mgmt/2019-06-01/managedservices [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/managedservices/mgmt/2019-04-01/managedservices [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/managedservices/mgmt/2018-06-01/managedservices [View full logs]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs] Generate from 0e6644c54a38a59abdf495fcdc2be6298583a194. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/managedservices/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 0e6644c54a38a59abdf495fcdc2be6298583a194. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-23T19:16:18Z

Hi @skayani, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

...s/resource-manager/Microsoft.ManagedServices/preview/2021-11-01-preview/managedservices.json

dramuy · 2021-12-09T05:28:09Z

...nagedServices/preview/2021-11-01-preview/examples/GetMarketplaceRegistrationDefinitions.json

+{
+  "parameters": {
+    "scope": "subscription/0afefe50-734e-4610-8a82-a144ahf49dea",
+    "$filter": "planIdentifier eq 'publisher.offerIdentifier.planName.version'",


publisher.offerIdentifier.planName.version

would it be good if these match with the plan details in the response ?

Generally I try to avoid changing existing examples but I guess it wouldn't be a bad idea as we are using GUIDs instead of placeholders

...nagedServices/preview/2021-11-01-preview/examples/GetMarketplaceRegistrationDefinitions.json

...iew/2021-11-01-preview/examples/GetRegistrationAssignmentsWithManagedByTenantIdEqFilter.json

...iew/2021-11-01-preview/examples/GetRegistrationAssignmentsWithManagedByTenantIdInFilter.json

skayani · 2021-12-14T20:18:52Z

@dramuy Please review #17089 instead as I changed the API version as per your suggestion

skayani added 8 commits November 22, 2021 14:48

Adds base for updating Microsoft.ManagedServices from version preview…

dcea8fb

…/2020-02-01-preview to version 2021-11-01-preview

Updates readme

4b5fb35

Updates API version in new specs and examples

afbea17

Add systemdata + query filtering

d3d9640

Syntax fix

715df3e

Fix examples

85ebb35

Remove managedByTenantId filtering examples

ccd2f4a

Fix references + update examples

a6c5165

openapi-assignment-bot bot assigned msyyc Nov 23, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Nov 23, 2021

openapi-sdkautomation bot mentioned this pull request Nov 23, 2021

[AutoPR azure-mgmt-managedservices] Add new 2021-11-01-preview API to support SystemData and managedByTenantId query filtering AzureSDKAutomation/azure-sdk-for-python#8171

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Python label Nov 23, 2021

openapi-sdkautomation bot mentioned this pull request Nov 23, 2021

[AutoPR track2_azure-mgmt-managedservices] Add new 2021-11-01-preview API to support SystemData and managedByTenantId query filtering AzureSDKAutomation/azure-sdk-for-python#8172

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Nov 23, 2021

skayani changed the title ~~Microsoft.managed services 2021 11 01 preview~~ Add new 2021-11-01-preview API to support SystemData and managedByTenantId query filterin Nov 23, 2021

skayani changed the title ~~Add new 2021-11-01-preview API to support SystemData and managedByTenantId query filterin~~ Add new 2021-11-01-preview API to support SystemData and managedByTenantId query filtering Nov 23, 2021

skayani added 2 commits November 23, 2021 11:39

Validation fixes

187826d

Validation fixes

4e88b32