Skip to content

[Hub Generated] Review request for Microsoft.Cache to add version stable/2020-12-01 #16214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArcturusZhang merged 2 commits into from
Oct 1, 2021
Merged

[Hub Generated] Review request for Microsoft.Cache to add version stable/2020-12-01 #16214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
752dbed
s360 swagger correctness issue fix
Sep 29, 2021
57a6f39
Correcting description of staticIP
Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion specification/redis/resource-manager/Microsoft.Cache/stable/2020-06-01/redis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1935,7 +1935,11 @@
"staticIP": {
"type": "string",
"pattern": "^\\d+\\.\\d+\\.\\d+\\.\\d+$",
"description": "Static IP address. Required when deploying a Redis cache inside an existing Azure Virtual Network."
"description": "Static IP address. Required when deploying a Redis cache inside an existing Azure Virtual Network.",
Copy link
Member

@TimLovellSmith TimLovellSmith Sep 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not required. Its Optional. The address is autoassigned by default.

Copy link
Contributor Author

@gorandom gorandom Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add "readOnly" or "x-ms-mutability" or "default" to fix s360 issue.
Else we have to suppress the error.
"x-ms-mutability" seems more suitable here, since we can set It on creation and we can read.

Copy link
Member

@TimLovellSmith TimLovellSmith Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the IP address is not required. So the description should be "Static IP address. Optionally, may be specified when deploying a Redis cache inside an existing Azure Virtual Network; autoassigned by default."

Copy link
Contributor Author

@gorandom gorandom Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified

"x-ms-mutability": [
"read",
"create"
]
}
},
"required": [
Expand Down
6 changes: 5 additions & 1 deletion specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1947,7 +1947,11 @@
"staticIP": {
"type": "string",
"pattern": "^\\d+\\.\\d+\\.\\d+\\.\\d+$",
"description": "Static IP address. Required when deploying a Redis cache inside an existing Azure Virtual Network."
"description": "Static IP address. Required when deploying a Redis cache inside an existing Azure Virtual Network.",
Copy link
Member

@TimLovellSmith TimLovellSmith Sep 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not required. Its Optional. The address is autoassigned by default.

"x-ms-mutability": [
"read",
"create"
]
}
},
"required": [
Expand Down