Skip to content

fix the directive to exclude changes for track 2 #15084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 3 commits into from
Jul 6, 2021
Merged

fix the directive to exclude changes for track 2 #15084

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7fa3a2
fix the directive to exclude changes for track 2
ArcturusZhang Jul 6, 2021
14472a0
add model-deduplication
ArcturusZhang Jul 6, 2021
0b338bc
fix
ArcturusZhang Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specification/monitor/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ directive:
where: "$.definitions.Resource"
transform: >
$["x-ms-client-name"] = "TrackedEntityResource";

modelerfour:
lenient-model-deduplication: true
```

### Go multi-api
Expand Down
4 changes: 2 additions & 2 deletions specification/monitor/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,15 +759,15 @@ directive:

```

``` yaml $(go) || $(csharp) || $(validation) || $(typescript)
``` yaml ($(go) && !$(track2)) || $(csharp) || $(validation) || $(typescript)
directive:
- from: activityLogAlerts_API.json
where: $.definitions
transform: delete $["Resource"]
reason: Missing kind, etag
```

``` yaml !$(python) && !$(go) && !$(java) && $(tag) == 'package-2021-04'
``` yaml !$(python) && (!$(go) && !$(track2)) && !$(java) && $(tag) == 'package-2021-04'
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one previously appears already exclude for all golang (track1 or track2) by !$(go)?

Copy link
Member Author

@ArcturusZhang ArcturusZhang Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I will remove this

Copy link
Member Author

@ArcturusZhang ArcturusZhang Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

directive:
- from: scheduledQueryRule_API.json
where: $.parameters
Expand Down