Skip to content

BugFix: Set readonly flag to false for non-read only properties in Guest Configuration #14999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArcturusZhang merged 6 commits into from
Jul 7, 2021
Merged

BugFix: Set readonly flag to false for non-read only properties in Guest Configuration #14999

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee62d41
Bug-Fix: Remove read-only properties from Guest Configuration objects
Jun 25, 2021
eb97ace
Merge branch 'master' of https://github.com/aashish1987/azure-rest-ap…
Jun 25, 2021
5a71ad9
Merge branch 'master' of https://github.com/aashish1987/azure-rest-ap…
Jun 29, 2021
150769b
Resolved PR comments. Updated examples
Jun 29, 2021
31e74a6
Add Assignment Type
Jun 30, 2021
d5a3a6c
Fix Prettier check
Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...tConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
3 changes: 3 additions & 0 deletions ...figuration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationHCRPAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
20 changes: 16 additions & 4 deletions ...n/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,16 +802,28 @@
"type": "string",
"description": "Version of the guest configuration."
},
"contentUri": {
"readOnly": true,
"contentUri": {
"type": "string",
"description": "Uri of the storage where guest configuration package is uploaded."
},
"contentHash": {
"readOnly": true,
"contentHash": {
"type": "string",
"description": "Combined hash of the guest configuration package and configuration parameters."
},
"assignmentType": {
"type": "string",
"description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.",
"x-ms-enum": {
"name": "assignmentType",
"modelAsString": true
},
"enum": [
"Audit",
"DeployAndAutoCorrect",
"ApplyAndAutoCorrect",
"ApplyAndMonitor"
]
},
"configurationParameter": {
"type": "array",
"items": {
Expand Down
3 changes: 3 additions & 0 deletions ...tConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
3 changes: 3 additions & 0 deletions ...figuration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
20 changes: 16 additions & 4 deletions ...n/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,16 +802,28 @@
"type": "string",
"description": "Version of the guest configuration."
},
"contentUri": {
"readOnly": true,
"contentUri": {
"type": "string",
"description": "Uri of the storage where guest configuration package is uploaded."
},
"contentHash": {
"readOnly": true,
"contentHash": {
"type": "string",
"description": "Combined hash of the guest configuration package and configuration parameters."
},
"assignmentType": {
Copy link

@neil-yechenwei neil-yechenwei Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this assignmentType property is same with the configurationMode property, does it mean the configurationMode property needs to be removed in this PR?

Copy link
Member Author

@aashish1987 aashish1987 Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never used configurationMode.
But since we already have it in swagger spec - we cannot delete it. BreakingChange team wont allow us to remove it.
I will work with my team and come up with a plan to remove the configurationMode section. Right now it wont harm it.

"type": "string",
"description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.",
"x-ms-enum": {
"name": "assignmentType",
"modelAsString": true
},
"enum": [
"Audit",
"DeployAndAutoCorrect",
"ApplyAndAutoCorrect",
"ApplyAndMonitor"
]
},
"configurationParameter": {
"type": "array",
"items": {
Expand Down
3 changes: 3 additions & 0 deletions ...tConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
3 changes: 3 additions & 0 deletions ...figuration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
20 changes: 16 additions & 4 deletions ...n/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,16 +1087,28 @@
"type": "string",
"description": "Version of the guest configuration."
},
"contentUri": {
"readOnly": true,
"contentUri": {
"type": "string",
"description": "Uri of the storage where guest configuration package is uploaded."
},
"contentHash": {
"readOnly": true,
"contentHash": {
"type": "string",
"description": "Combined hash of the guest configuration package and configuration parameters."
},
"assignmentType": {
"type": "string",
"description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.",
"x-ms-enum": {
"name": "assignmentType",
"modelAsString": true
},
"enum": [
"Audit",
"DeployAndAutoCorrect",
"ApplyAndAutoCorrect",
"ApplyAndMonitor"
]
},
"configurationParameter": {
"type": "array",
"items": {
Expand Down