Skip to content

Fix SecurityInsights Go SDK versioning #14030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 3 commits into from
Apr 26, 2021
Merged

Fix SecurityInsights Go SDK versioning #14030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd2b99d
Fix SecurityInsights Go SDK versioning
ityankel Apr 20, 2021
f768a30
rename stable api version tag
ityankel Apr 20, 2021
e463f7e
remove 'only' from tags with full functionality
ityankel Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions specification/securityinsights/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,32 +13,24 @@ go:

```yaml $(go) && $(multiapi)
batch:
- tag: package-composite-v1
- tag: package-2019-01-preview-only
- tag: package-2020-01
- tag: package-2019-01-preview
```

### Tag: package-composite-v1 and go
### Tag: package-2020-01 and go

These settings apply only when `--tag=package-composite-v1 --go` is specified on the command line.
These settings apply only when `--tag=package-2020-01 --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

```yaml $(tag) == 'package-composite-v1' && $(go)
output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/v1.0/$(namespace)
```yaml $(tag) == 'package-2020-01' && $(go)
output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2020-01-01/$(namespace)
```
### Tag: package-2021-03-preview-only and go

These settings apply only when `--tag=package-2021-03-preview-only --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

```yaml $(tag) == 'package-2019-01-preview-only' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-01-01-preview/$(namespace)
```

### Tag: package-2019-01-preview-only and go
### Tag: package-2019-01-preview and go

These settings apply only when `--tag=package-2019-01-preview-only --go` is specified on the command line.
These settings apply only when `--tag=package-2019-01-preview --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

```yaml $(tag) == 'package-2019-01-preview-only' && $(go)
```yaml $(tag) == 'package-2019-01-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-01-01-preview/$(namespace)
```
14 changes: 7 additions & 7 deletions specification/securityinsights/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ These are the global settings for the SecurityInsights API.

```yaml
openapi-type: arm
tag: package-composite-v1
tag: package-2020-01
```

### Tag: package-composite-v1
### Tag: package-2020-01

These settings apply only when `--tag=package-composite-v1` is specified on the command line.
These settings apply only when `--tag=package-2020-01` is specified on the command line.

```yaml $(tag) == 'package-composite-v1'
```yaml $(tag) == 'package-2020-01'
input-file:
- Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json
directive:
Expand Down Expand Up @@ -62,11 +62,11 @@ directive:

---

### Tag: package-2019-01-preview-only
### Tag: package-2019-01-preview

These settings apply only when `--tag=package-2019-01-preview-only` is specified on the command line.
These settings apply only when `--tag=package-2019-01-preview` is specified on the command line.

```yaml $(tag) == 'package-2019-01-preview-only'
```yaml $(tag) == 'package-2019-01-preview'
input-file:
- Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
directive:
Expand Down