Skip to content

s360 fixes for Azure DNS #11591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lirenhe merged 9 commits into from
Nov 18, 2020
Merged

s360 fixes for Azure DNS #11591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
59c7821
s360 fixes for Azure DNS
vladrai Nov 6, 2020
f8be6b6
Additional property
vladrai Nov 7, 2020
455d6da
Property fix
vladrai Nov 7, 2020
acf3ec5
Readonly property
vladrai Nov 7, 2020
9813b71
CloudError fix
vladrai Nov 9, 2020
86e99c3
Examples. cloud error
vladrai Nov 9, 2020
f3242dd
Avocado fix
vladrai Nov 9, 2020
636b74b
read.md
vladrai Nov 9, 2020
23bcbdb
Prettier
vladrai Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions specification/dns/resource-manager/Microsoft.Network/preview/2018-03-01-preview/dns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,6 +1384,12 @@
"description": "The maximum number of record sets that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"maxNumberOfRecordsPerRecordSet": {
"type": "integer",
"format": "int64",
"description": "The maximum number of records per record set that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"numberOfRecordSets": {
"type": "integer",
"format": "int64",
Expand Down Expand Up @@ -1487,40 +1493,40 @@
},
"CloudError": {
"type": "object",
"x-ms-external": true,
"properties": {
"error": {
"$ref": "#/definitions/CloudErrorBody",
"description": "The error message body"
"description": "Cloud error body."
}
},
"x-ms-external": true,
"description": "An error message"
"description": "An error response from the service."
},
"CloudErrorBody": {
"type": "object",
"x-ms-external": true,
"properties": {
"code": {
"type": "string",
"description": "The error code"
"description": "An identifier for the error. Codes are invariant and are intended to be consumed programmatically."
},
"message": {
"type": "string",
"description": "A description of what caused the error"
"description": "A message describing the error, intended to be suitable for display in a user interface."
},
"target": {
"type": "string",
"description": "The target resource of the error message"
"description": "The target of the particular error. For example, the name of the property in error."
},
"details": {
"type": "array",
"items": {
"$ref": "#/definitions/CloudErrorBody"
},
"description": "Extra error information"
"description": "A list of additional details about the error."
}
},
"x-ms-external": true,
"description": "The body of an error message"
"description": "An error response from the service."
}
},
"parameters": {}
Expand Down
32 changes: 25 additions & 7 deletions specification/dns/resource-manager/Microsoft.Network/stable/2016-04-01/dns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,11 @@
"format": "int64",
"description": "The TTL (time-to-live) of the records in the record set."
},
"fqdn": {
"type": "string",
Copy link
Contributor

@j5lim j5lim Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new properties requires changing the api-version according to Azure API guidline. However, since this is for s360 compliance, it should be acceptable.

"description": "Fully qualified domain name of the record set.",
"readOnly": true
},
"ARecords": {
"type": "array",
"items": {
Expand Down Expand Up @@ -1018,6 +1023,12 @@
"format": "int64",
"description": "The maximum number of record sets that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored."
},
"maxNumberOfRecordsPerRecordSet": {
"type": "integer",
"format": "int64",
"description": "The maximum number of records per record set that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"numberOfRecordSets": {
"type": "integer",
"format": "int64",
Expand Down Expand Up @@ -1160,33 +1171,40 @@
},
"CloudError": {
"type": "object",
"x-ms-external": true,
"properties": {
"error": {
"$ref": "#/definitions/CloudErrorBody"
"$ref": "#/definitions/CloudErrorBody",
"description": "Cloud error body."
}
},
"x-ms-external": true
"description": "An error response from the service."
},
"CloudErrorBody": {
"type": "object",
"x-ms-external": true,
"properties": {
"code": {
"type": "string"
"type": "string",
"description": "An identifier for the error. Codes are invariant and are intended to be consumed programmatically."
},
"message": {
"type": "string"
"type": "string",
"description": "A message describing the error, intended to be suitable for display in a user interface."
},
"target": {
"type": "string"
"type": "string",
"description": "The target of the particular error. For example, the name of the property in error."
},
"details": {
"type": "array",
"items": {
"$ref": "#/definitions/CloudErrorBody"
}
},
"description": "A list of additional details about the error."
}
},
"x-ms-external": true
"description": "An error response from the service."
}
},
"parameters": {}
Expand Down
24 changes: 15 additions & 9 deletions specification/dns/resource-manager/Microsoft.Network/stable/2017-09-01/dns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,12 @@
"description": "The maximum number of record sets that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"maxNumberOfRecordsPerRecordSet": {
"type": "integer",
"format": "int64",
"description": "The maximum number of records per record set that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"numberOfRecordSets": {
"type": "integer",
"format": "int64",
Expand Down Expand Up @@ -1188,40 +1194,40 @@
},
"CloudError": {
"type": "object",
"x-ms-external": true,
"properties": {
"error": {
"$ref": "#/definitions/CloudErrorBody",
"description": "The error message body"
"description": "Cloud error body."
}
},
"x-ms-external": true,
"description": "An error message"
"description": "An error response from the service."
},
"CloudErrorBody": {
"type": "object",
"x-ms-external": true,
"properties": {
"code": {
"type": "string",
"description": "The error code"
"description": "An identifier for the error. Codes are invariant and are intended to be consumed programmatically."
},
"message": {
"type": "string",
"description": "A description of what caused the error"
"description": "A message describing the error, intended to be suitable for display in a user interface."
},
"target": {
"type": "string",
"description": "The target resource of the error message"
"description": "The target of the particular error. For example, the name of the property in error."
},
"details": {
"type": "array",
"items": {
"$ref": "#/definitions/CloudErrorBody"
},
"description": "Extra error information"
"description": "A list of additional details about the error."
}
},
"x-ms-external": true,
"description": "The body of an error message"
"description": "An error response from the service."
}
},
"parameters": {}
Expand Down
24 changes: 15 additions & 9 deletions specification/dns/resource-manager/Microsoft.Network/stable/2017-10-01/dns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,6 +1381,12 @@
"description": "The maximum number of record sets that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"maxNumberOfRecordsPerRecordSet": {
"type": "integer",
"format": "int64",
"description": "The maximum number of records per record set that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"numberOfRecordSets": {
"type": "integer",
"format": "int64",
Expand Down Expand Up @@ -1458,40 +1464,40 @@
},
"CloudError": {
"type": "object",
"x-ms-external": true,
"properties": {
"error": {
"$ref": "#/definitions/CloudErrorBody",
"description": "The error message body"
"description": "Cloud error body."
}
},
"x-ms-external": true,
"description": "An error message"
"description": "An error response from the service."
},
"CloudErrorBody": {
"type": "object",
"x-ms-external": true,
"properties": {
"code": {
"type": "string",
"description": "The error code"
"description": "An identifier for the error. Codes are invariant and are intended to be consumed programmatically."
},
"message": {
"type": "string",
"description": "A description of what caused the error"
"description": "A message describing the error, intended to be suitable for display in a user interface."
},
"target": {
"type": "string",
"description": "The target resource of the error message"
"description": "The target of the particular error. For example, the name of the property in error."
},
"details": {
"type": "array",
"items": {
"$ref": "#/definitions/CloudErrorBody"
},
"description": "Extra error information"
"description": "A list of additional details about the error."
}
},
"x-ms-external": true,
"description": "The body of an error message"
"description": "An error response from the service."
}
},
"parameters": {}
Expand Down
24 changes: 15 additions & 9 deletions specification/dns/resource-manager/Microsoft.Network/stable/2018-05-01/dns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,6 +1483,12 @@
"description": "The maximum number of record sets that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"maxNumberOfRecordsPerRecordSet": {
"type": "integer",
"format": "int64",
"description": "The maximum number of records per record set that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored.",
"readOnly": true
},
"numberOfRecordSets": {
"type": "integer",
"format": "int64",
Expand Down Expand Up @@ -1685,40 +1691,40 @@
},
"CloudError": {
"type": "object",
"x-ms-external": true,
"properties": {
"error": {
"$ref": "#/definitions/CloudErrorBody",
"description": "The error message body"
"description": "Cloud error body."
}
},
"x-ms-external": true,
"description": "An error message"
"description": "An error response from the service."
},
"CloudErrorBody": {
"type": "object",
"x-ms-external": true,
"properties": {
"code": {
"type": "string",
"description": "The error code"
"description": "An identifier for the error. Codes are invariant and are intended to be consumed programmatically."
},
"message": {
"type": "string",
"description": "A description of what caused the error"
"description": "A message describing the error, intended to be suitable for display in a user interface."
},
"target": {
"type": "string",
"description": "The target resource of the error message"
"description": "The target of the particular error. For example, the name of the property in error."
},
"details": {
"type": "array",
"items": {
"$ref": "#/definitions/CloudErrorBody"
},
"description": "Extra error information"
"description": "A list of additional details about the error."
}
},
"x-ms-external": true,
"description": "The body of an error message"
"description": "An error response from the service."
}
},
"parameters": {
Expand Down
12 changes: 7 additions & 5 deletions ...esource-manager/Microsoft.Network/stable/2018-05-01/examples/GetDnsResourceReference.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@
"api-version": "2018-05-01",
"subscriptionId": "subid",
"parameters": {
"targetResources": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/trafficManagerProfiles/testpp2"
}
]
"properties": {
"targetResources": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/trafficManagerProfiles/testpp2"
}
]
}
}
},
"responses": {
Expand Down
18 changes: 9 additions & 9 deletions ...ification/privatedns/resource-manager/Microsoft.Network/stable/2018-09-01/privatedns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1864,40 +1864,40 @@
},
"CloudError": {
"type": "object",
"x-ms-external": true,
"properties": {
"error": {
"$ref": "#/definitions/CloudErrorBody",
"description": "The error message body"
"description": "Cloud error body."
}
},
"x-ms-external": true,
"description": "An error message"
"description": "An error response from the service."
},
"CloudErrorBody": {
"type": "object",
"x-ms-external": true,
"properties": {
"code": {
"type": "string",
"description": "The error code"
"description": "An identifier for the error. Codes are invariant and are intended to be consumed programmatically."
},
"message": {
"type": "string",
"description": "A description of what caused the error"
"description": "A message describing the error, intended to be suitable for display in a user interface."
},
"target": {
"type": "string",
"description": "The target resource of the error message"
"description": "The target of the particular error. For example, the name of the property in error."
},
"details": {
"type": "array",
"items": {
"$ref": "#/definitions/CloudErrorBody"
},
"description": "Extra error information"
"description": "A list of additional details about the error."
}
},
"x-ms-external": true,
"description": "The body of an error message"
"description": "An error response from the service."
}
},
"parameters": {
Expand Down
Loading