Skip to content

Conversation

@DanielMicrosoft
Copy link
Contributor

@DanielMicrosoft DanielMicrosoft commented Nov 10, 2025

Description

Fixes #23731

Add partial custom class to fix the nextLink issue and generate correct URI for pagination.

Checklist:

  • Test with < 100 results
  • Test with > 100 results
  • Test with > 200 results
  • Scenario test? (not sure about this as they dont exist for module), added pester test
  • Changelog

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@DanielMicrosoft DanielMicrosoft marked this pull request as ready for review November 12, 2025 01:21
Copilot AI review requested due to automatic review settings November 12, 2025 01:21
Copilot finished reviewing on behalf of DanielMicrosoft November 12, 2025 01:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a pagination issue (GitHub #23731) where Get-AzAppConfigurationKeyValue fails to retrieve results beyond the first 100 records. The API returns relative @nextLink URLs, but the AutoRest-generated code expects absolute URLs. The fix adds a custom partial class implementation to convert relative URLs to absolute ones before pagination continues.

Key changes:

  • Added custom C# override for pagination handling in GetAzAppConfigurationKeyValue_Get
  • Added Pester test to verify pagination works with >100 results
  • Updated ChangeLog to document the fix

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/AppConfiguration/AppConfigurationdata.Autorest/custom/GetAzAppConfigurationKeyValue_Get.cs New partial class that overrides pagination to handle relative nextLink URLs by converting them to absolute URLs
src/AppConfiguration/AppConfigurationdata.Autorest/test/AzAppConfigurationKeyValue.Tests.ps1 Added test case to verify pagination returns all results when >100 records exist
src/AppConfiguration/AppConfiguration/ChangeLog.md Updated with fix description and GitHub issue reference

@notyashhh notyashhh self-assigned this Nov 14, 2025
@notyashhh notyashhh added this to the Az 15.1.0 (12/02/2025) milestone Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with Get-AzAppConfigurationKeyValue when more that 100 records are present

2 participants