-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[App Configuration] : Handle pagination of Get-AzAppConfigurationKeyValue #28840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[App Configuration] : Handle pagination of Get-AzAppConfigurationKeyValue #28840
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a pagination issue (GitHub #23731) where Get-AzAppConfigurationKeyValue fails to retrieve results beyond the first 100 records. The API returns relative @nextLink URLs, but the AutoRest-generated code expects absolute URLs. The fix adds a custom partial class implementation to convert relative URLs to absolute ones before pagination continues.
Key changes:
- Added custom C# override for pagination handling in
GetAzAppConfigurationKeyValue_Get - Added Pester test to verify pagination works with >100 results
- Updated ChangeLog to document the fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/AppConfiguration/AppConfigurationdata.Autorest/custom/GetAzAppConfigurationKeyValue_Get.cs |
New partial class that overrides pagination to handle relative nextLink URLs by converting them to absolute URLs |
src/AppConfiguration/AppConfigurationdata.Autorest/test/AzAppConfigurationKeyValue.Tests.ps1 |
Added test case to verify pagination returns all results when >100 records exist |
src/AppConfiguration/AppConfiguration/ChangeLog.md |
Updated with fix description and GitHub issue reference |
Description
Fixes #23731
Add partial custom class to fix the
nextLinkissue and generate correct URI for pagination.Checklist:
Scenario test?(not sure about this as they dont exist for module), added pester testMandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.