Skip to content

Conversation

@Jingshu923
Copy link
Contributor

@Jingshu923 Jingshu923 commented Dec 14, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jingshu923 Anything change after the version is updated?

@msJinLei msJinLei added the needs-author-feedback More information is needed from author to address the issue. label Dec 15, 2021
@msJinLei
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@Jingshu923
Copy link
Contributor Author

@msJinLei There is a break change in swagger, so sdk need to upgrade a major version as reviewer suggest.

(Azure/azure-sdk-for-net#25595)

@Jingshu923 Jingshu923 requested a review from msJinLei December 16, 2021 05:52
@msJinLei
Copy link
Contributor

@msJinLei There is a break change in swagger, so sdk need to upgrade a major version as reviewer suggest.

(Azure/azure-sdk-for-net#25595)

But the change of sdk has no effect to your codes? That's why I ask the question.

@msJinLei
Copy link
Contributor

msJinLei commented Dec 23, 2021

Run a full test for the DataFactory. Will merge after pass.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1261819&view=results

@msJinLei msJinLei added Waiting for CI :shipit: and removed needs-author-feedback More information is needed from author to address the issue. labels Dec 23, 2021
@msJinLei msJinLei merged commit efcfb05 into Azure:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants