-
Notifications
You must be signed in to change notification settings - Fork 22
Fix: TerminateUnmatchedRequest should be bool? in Cors policy
#182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@drjonnicholson please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Hello @drjonnicholson ! Thank you for your contribution! I really appreciate that. I have two asks for you for this PR.
Thank you again for the contribution! |
|
Hi @Mielek, thanks for the great work on this project, think it's fab :) There's already 2 new test cases already included covering truthy and falsey cases, where unsupplied is already covered. Are they sufficient? Am currently trying to find out my company's stance on the license, trying to resolve asap |
Fixes #181