Improve header cache handling and ETag checks #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjn
reviewed
Oct 16, 2025
| // Respect ETags served with feeds. | ||
| $three04 = false; | ||
| if ( isset( $SERVER['HTTP_IF_NONE_MATCH'] ) && isset( $batcache->cache['headers']['ETag'][0] ) && $_SERVER['HTTP_IF_NONE_MATCH'] == $batcache->cache['headers']['ETag'][0] ) | ||
| if ( isset( $_SERVER['HTTP_IF_NONE_MATCH'] ) && isset( $batcache->cache['headers']['ETag'][0] ) && $_SERVER['HTTP_IF_NONE_MATCH'] === $batcache->cache['headers']['ETag'][0] ) |
tomjn
reviewed
Oct 16, 2025
| if ( !empty( $this->cache['headers'] ) && !empty( $this->uncached_headers ) ) { | ||
| foreach ( $this->uncached_headers as $header ) | ||
| unset( $this->cache['headers'][$header] ); | ||
| foreach ( $this->uncached_headers as $h ) { |
Contributor
There was a problem hiding this comment.
Any particular reason we can't use the full descriptive variable name? $h may be quicker to type but it hides the purpose of the variable and makes the rest of the code less readable
tomjn
reviewed
Oct 16, 2025
Comment on lines
+261
to
+268
| foreach ( $this->uncached_headers as $h ) { | ||
| foreach ( array_keys( $this->cache['headers'] ) as $k ) { | ||
| if ( strcasecmp( $k, $h ) === 0 ) { | ||
| unset( $this->cache['headers'][ $k ] ); | ||
| break; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is there any way we can reduce the nested for loops with array_map/filter/walk?
Contributor
|
@craftogrammer nice changes but could we add a PR description? I've left some feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.