Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/only-export-components.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,21 @@ const valid = [
code: "const MyComponent = () => {}; export default observer(MyComponent);",
options: [{ customHOCs: ["observer"] }],
},
{
name: "Curried HOC with styled (object form)",
code: "export const Flex = styled('div')({display: 'flex'});",
options: [{ customHOCs: ["styled"] }],
},
{
name: "Curried HOC with styled (template literal form)",
code: "export const Flex = styled('div')`display: flex;`;",
options: [{ customHOCs: ["styled"] }],
},
{
name: "Curried HOC only first call",
code: "export const Flex = styled('div');",
options: [{ customHOCs: ["styled"] }],
},
{
name: "Local constant with component casing and non component function",
code: "const SomeConstant = 42; export function someUtility() { return SomeConstant }",
Expand Down
17 changes: 12 additions & 5 deletions src/only-export-components.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,18 @@ export const onlyExportComponents: TSESLint.RuleModule<
if (!init) return false;
const jsInit = skipTSWrapper(init);
if (jsInit.type === "ArrowFunctionExpression") return true;
if (
jsInit.type === "CallExpression"
&& jsInit.callee.type === "Identifier"
) {
return reactHOCs.includes(jsInit.callee.name);
if (jsInit.type === "CallExpression") {
// memo(...)
if (jsInit.callee.type === "Identifier") {
return reactHOCs.includes(jsInit.callee.name);
}
// Curried HOC: styled('div')({...})
if (
jsInit.callee.type === "CallExpression"
&& jsInit.callee.callee.type === "Identifier"
) {
return reactHOCs.includes(jsInit.callee.callee.name);
}
}
return false;
};
Expand Down