Skip to content

Conversation

@zaoqi
Copy link
Contributor

@zaoqi zaoqi commented Dec 15, 2019

@probonopd
Copy link
Member

Do you see any issues with this @TheAssassin?

@TheAssassin
Copy link
Member

@probonopd the change itself is harmless, it won't interfere with our build system (if that macro doesn't exist, the extern C will just be ignored). However it doesn't quite seem right. @zaoqi please double-check your commit.

@TheAssassin TheAssassin merged commit 20ea487 into AppImage:master Feb 18, 2020
@probonopd
Copy link
Member

Thank you very much gentlemen 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants