MUON: process only best matching candidates #2612
Conversation
The MFT-MCH matching task now stores by default multiple matching candidates for each MCH standalone track. In order to properly assess the tracking quality and avoid a large combinatorial background, only the best matching candidate for each MCH track must be processed by the QC tracks task.
aferrero2707
requested review from
Barthelemy,
justonedev1 and
knopers8
as code owners
|
@Barthelemy @justonedev1 @knopers8 could you please have a look? The changes are rather small, and a similar method of selecting the best matching candidates is already used in O2Physics. It would be great if we could still include this PR in the online software before the start of the Pb-Pb data taking. |
| if (matchingCandidates.empty()) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This is probably not even reachable, but it looks harmless.
There was a problem hiding this comment.
Indeed this should never happen, but since below I am accessing the first element I prefer to be extra-safe.
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Assuming I understood correctly the lifetimes of objects and pointers in the new snippet, it seems safe.
|
macOS build failing in O2, but o2-dataflow-slc9 is green, merging and hoping for the best. |
* [MUON] process only best matching candidates The MFT-MCH matching task now stores by default multiple matching candidates for each MCH standalone track. In order to properly assess the tracking quality and avoid a large combinatorial background, only the best matching candidate for each MCH track must be processed by the QC tracks task. * [MUON] clang formatting
The map structure that temporarily keeps the indexes of the matching candidates is local to the code block that I have added, and only used to collect and sort the candidates. The rest reuses structures that were already used before. |
* [MUON] process only best matching candidates The MFT-MCH matching task now stores by default multiple matching candidates for each MCH standalone track. In order to properly assess the tracking quality and avoid a large combinatorial background, only the best matching candidate for each MCH track must be processed by the QC tracks task. * [MUON] clang formatting
2 participants
The MFT-MCH matching task now stores by default multiple matching candidates for each MCH standalone track.
In order to properly assess the tracking quality and avoid a large combinatorial background, only the best matching candidate for each MCH track must be processed by the QC tracks task.