Skip to content

GLO: hopefully improve fit logic for K0s for sync #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
Oct 17, 2025
Merged

GLO: hopefully improve fit logic for K0s for sync #2607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions Modules/GLO/include/GLO/Helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#include <TF1.h>
#include <TH1.h>
#include <TFitResult.h>
#include <TFitResultPtr.h>

namespace o2::quality_control_modules::glo::helpers
{
Expand Down Expand Up @@ -84,23 +86,41 @@ struct K0sFitter {

bool fit(TH1* h, bool add = false)
{
if (h->GetEntries() == 0) {
ILOG(Warning, Devel) << "Cannot fit empty histogram: " << h->GetName() << ENDM;
if (!h || h->GetEntries() == 0) {
ILOG(Warning, Devel) << "Cannot fit empty histogram: "
<< (h ? h->GetName() : "<null>") << ENDM;
return false;
}
Int_t res = h->Fit(mBackground.get(), "RNQ");
if (res) {
ILOG(Warning, Devel) << "Failed k0s background fit for histogram: " << h->GetName() << ENDM;

// --- First: background-only fit
auto bgResult = h->Fit(mBackground.get(), "RNQS");
if (bgResult.Get() == nullptr || bgResult->Status() != 0) {
ILOG(Warning, Devel) << "Failed k0s background fit for histogram: "
<< h->GetName()
<< " (status=" << (bgResult ? bgResult->Status() : -1) << ")"
<< ENDM;
return false;
}

// --- Initialize signal+background from background fit
mSignalAndBackground->SetParameter(Parameters::Pol0, mBackground->GetParameter(Parameters::Pol0));
mSignalAndBackground->SetParameter(Parameters::Pol1, mBackground->GetParameter(Parameters::Pol1));
mSignalAndBackground->SetParameter(Parameters::Pol2, mBackground->GetParameter(Parameters::Pol2));
mSignalAndBackground->SetParameter(Parameters::Amplitude, h->GetMaximum() - mBackground->Eval(mMassK0s));
mSignalAndBackground->SetParameter(Parameters::Mass, mMassK0s);
mSignalAndBackground->SetParameter(Parameters::Sigma, 0.005);
mSignalAndBackground->SetParLimits(Parameters::Sigma, 1e-6, 1);
h->Fit(mSignalAndBackground.get(), (add) ? "RMQ" : "RMQ0");
mSignalAndBackground->SetParLimits(Parameters::Sigma, 1e-6, 1.0);

// --- Fit signal+background
const std::string fitOpt = add ? "RMQS" : "RMQS0";
auto sbResult = h->Fit(mSignalAndBackground.get(), fitOpt.c_str());
if (sbResult.Get() == nullptr || sbResult->Status() != 0) {
ILOG(Warning, Devel) << "Failed k0s signal+background fit for histogram: "
<< h->GetName()
<< " (status=" << (sbResult ? sbResult->Status() : -1) << ")"
<< ENDM;
return false;
}
return true;
}

Expand Down
3 changes: 3 additions & 0 deletions Modules/GLO/src/ITSTPCmatchingCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,9 @@ void ITSTPCmatchingCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality ch
msg->AddText(Form("RError %.2f%%", rerr * 1e2));
msg->SetFillColor(kGreen);
}
if (TF1* fit = h->GetFunction("gloFitK0sMassSignal"); fit != nullptr) {
h->GetListOfFunctions()->Add(fit);
}
}
h->GetListOfFunctions()->Add(msg);
}
Expand Down