Fix wrong warnings about bad flags assigned to good qualities

[knopers8]

Due to the order of processing in WorstOfAllAggregator, we could get cases when a bad Flag (coming from Bad quality) would be assigned to Good quality, while the quality itself would be replaced just after. This commit reverses the order, which will silence the wrong warning.

[knopers8]

Hello @singiamtel , @ktf , it seems that our builds are all broken: o2 and o2-dataflow-slc9 do not report any status, while macOS-arm fails:

Finished building on aido2osx8.cern.ch at 2025-07-22-08:57:23
Built commit aa8b935132f00e71ab58c504f95cac84c1d654ff from https://github.com/AliceO2Group/QualityControl/pull/2583
Nomad allocation:
    https://alinomad.cern.ch/ui/allocations/f984d447-2a9b-0a5f-eaef-c092e56fb1b2
To log into the build machine, use:
    nomad alloc exec f984d447 bash
To stream logs from the CI process, use:
    nomad alloc logs -stderr -tail -f f984d447
No logs found. Please check the aurora log.
See http://alisw.github.io/infrastructure-pr-testing for more instructions.

could you please have a look?

[singiamtel]

Hi @knopers8, we're investigating

[knopers8]

Thanks!

[singiamtel]

@knopers8 the issue should be fixed now. Thanks for the report

[justonedev1]

I am sorry but it isn't obvious for me how just reversing order of these two operations in one loop would fix the issue. you are creating Quality object, setting it's quality to the one you find as worse (finding the worst) ... aka setting it's level and name... and than adding all flags from all of the qualities encountered in check. So unless I am missing something I don't understand how you achieve with different situation than before.

[justonedev1]

nevermind, I understand, there are internal checks in addFlag ... but just reading the PR isn't obvious why this should fix anything. I would expect that addFlag is just adding flag without any internal checks.

[knopers8]

I think it's quite normal that functions validate their inputs, but indeed I could have mentioned where the warning was coming from.